From: Takayuki 'January June' Suwa <jjsuwa_sys3175@yahoo.co.jp>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Subject: [PATCH 1/2] xtensa: Tune "*btrue" insn pattern
Date: Thu, 12 Jan 2023 13:25:58 +0900 [thread overview]
Message-ID: <92692f27-76e3-ce45-bc25-95b9a7d2b64f@yahoo.co.jp> (raw)
In-Reply-To: <92692f27-76e3-ce45-bc25-95b9a7d2b64f.ref@yahoo.co.jp>
This branch instruction has short encoding if EQ/NE comparison against
immediate zero when the Code Density Option is enabled, but its "length"
attribute was only for normal encoding. This patch fixes it.
This patch also prevents undesireable replacement the comparison immediate
zero of the instruction (short encoding, as mentioned above) with a
register that has value of zero (normal encoding) by the postreload pass.
gcc/ChangeLog:
* config/xtensa/xtensa.md (*btrue):
Correct value of the attribute "length" that depends on
TARGET_DENSITY and operands, and add '?' character to the register
constraint of the compared operand.
---
gcc/config/xtensa/xtensa.md | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/gcc/config/xtensa/xtensa.md b/gcc/config/xtensa/xtensa.md
index db1d68ee658..b4989832169 100644
--- a/gcc/config/xtensa/xtensa.md
+++ b/gcc/config/xtensa/xtensa.md
@@ -1679,7 +1679,7 @@
[(set (pc)
(if_then_else (match_operator 3 "branch_operator"
[(match_operand:SI 0 "register_operand" "r,r")
- (match_operand:SI 1 "branch_operand" "K,r")])
+ (match_operand:SI 1 "branch_operand" "K,?r")])
(label_ref (match_operand 2 "" ""))
(pc)))]
""
@@ -1688,7 +1688,14 @@
}
[(set_attr "type" "jump,jump")
(set_attr "mode" "none")
- (set_attr "length" "3,3")])
+ (set (attr "length")
+ (if_then_else (match_test "TARGET_DENSITY
+ && CONST_INT_P (operands[1])
+ && INTVAL (operands[1]) == 0
+ && (GET_CODE (operands[3]) == EQ
+ || GET_CODE (operands[3]) == NE)")
+ (const_int 2)
+ (const_int 3)))])
(define_insn "*ubtrue"
[(set (pc)
--
2.30.2
next parent reply other threads:[~2023-01-12 4:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <92692f27-76e3-ce45-bc25-95b9a7d2b64f.ref@yahoo.co.jp>
2023-01-12 4:25 ` Takayuki 'January June' Suwa [this message]
2023-01-12 12:46 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92692f27-76e3-ce45-bc25-95b9a7d2b64f@yahoo.co.jp \
--to=jjsuwa_sys3175@yahoo.co.jp \
--cc=gcc-patches@gcc.gnu.org \
--cc=jcmvbkbc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).