From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 4B3F43858D33 for ; Fri, 17 Nov 2023 14:20:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B3F43858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4B3F43858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::432 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700230825; cv=none; b=WpMuaz9UzMMySr07SwBt2WtLavWWv6mh8X448ArFC1OAy7t5n2LOMigslnbeopUiojhsagVsN4lhGu30gWd1Y4RoEoG8AXeKH4y5YcQsz2rpPIi8X18/sF8qLxZWKwxXbpOHTnIgfiIk2p1ymbg0hz9ByEOH8akZ3oMCO5UR0Z4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700230825; c=relaxed/simple; bh=m9t888w/ORzhKCC0zmjZ1jtOSKyR5P7SQ2ucBhkY5j4=; h=DKIM-Signature:From:Message-Id:Mime-Version:Subject:Date:To; b=gM5klZYsERk6Ou40EjdezkXidyKkhSp7uagGSen+z0I4w7jHCCX7DCeovGCc0byNGQ5IjZmQAVHQmduafJMR7RtG4iDTleIlrc343duyHLgTp+/Cvvn7hbMIFcl8OADC526Kqfxf0NnJFv/4tHma8uj55Z8MBhC60SWgwrivf/g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-32fc2720c47so411979f8f.0 for ; Fri, 17 Nov 2023 06:20:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700230823; x=1700835623; darn=gcc.gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=jLDB/7yQd6FjzKHJvvz5i2+cA6W4gASh2v+7y3PC0ao=; b=EWcRefUZAzywaDb+vVlYyZeWuBsQtoJA11A71e/YmUNhCJ95XZl7lloLVjOtRzbHLH 4a/+Z9FTjkWQzva8uFemX849jERca6kTk+8CfZhi7+c+qqYYWBVbCnBlLYRkDUcIMr+e Y6uhS7zpNpxL8sG3lIOqFW9NzaFZCFqY883pHhE0Pwmkgb4RcRE0tspSJZiZ83DGoFD+ Hk9ZjjpbjX6h+7DalKD8Usih6izSlF8iCOIfAjG6W3QGc6/N3ymG+E2AeCwKRqakmH/j 04nJzKv3q3A19A4iAH0tNkxmU3VxqDvPgtjN1dgbT7TtlccgOYVGvHFuCRjedxEPAM6G zLKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700230823; x=1700835623; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jLDB/7yQd6FjzKHJvvz5i2+cA6W4gASh2v+7y3PC0ao=; b=ktfy61nIveet1eQOUtTX2K3tX8mLwh2PxsapN1R37KGCb/0NDzauan+PPXTJ6SwUGF 9oPrB6MihO95J6Orci/Ph9Bc0DbDyoQZqxddm2YEEaM/mN/6W90lcgvUIJRlET3kA46n bWpId3I3HxVq9f7c36nYT3yn3PhdcHToqplq068XcxfaVCs4wHbW2lAFxmjC90tltzP1 W2CGVyKMqkVf2eG8y0RORmzgDhFXuiDhIx6YngWkty4HgtYuc6oAH3mWEUiyVDdiG4f2 jaoeqlq6AaZN1bygKP7LixLHj4eJST24nqYQXiemBaDDc3QZncvxkXJ526cfO0QlfZ0z 3etg== X-Gm-Message-State: AOJu0YxC6GcOV+mBD7bZy0iybTGYNukpzYKpuaChJq/E9VTfQSs3cix0 JRkynNtjl7gQ/0qf/VPiCeM= X-Google-Smtp-Source: AGHT+IE57mW985YOWmAOFTcW/w9EK83EWGMIom0rdcPU/LHc8UVReq2pUDzMgVmHiSx5K25P5kWQ1w== X-Received: by 2002:a05:6000:1ac6:b0:32d:e445:a663 with SMTP id i6-20020a0560001ac600b0032de445a663mr8010209wry.2.1700230822486; Fri, 17 Nov 2023 06:20:22 -0800 (PST) Received: from smtpclient.apple (chp127.enscp.fr. [193.51.253.127]) by smtp.gmail.com with ESMTPSA id z5-20020adff745000000b0032d829e10c0sm2443420wrp.28.2023.11.17.06.20.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Nov 2023 06:20:21 -0800 (PST) From: FX Coudert Message-Id: <92736664-0EF6-4A62-B309-31311B736892@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_470433E9-B66F-450E-8E41-D02EA9BA0371" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Subject: Re: Darwin: Replace environment runpath with embedded [PR88590] Date: Fri, 17 Nov 2023 15:20:11 +0100 In-Reply-To: <87zfzc1st3.fsf@euler.schwinge.homeip.net> Cc: Iain Sandoe , gcc-patches@gcc.gnu.org, Martin Jambor To: Thomas Schwinge References: <653fd72a.050a0220.a6a20.de86SMTPIN_ADDED_BROKEN@mx.google.com> <5D574615-8242-439C-A4A8-B66CF896D66D@gmail.com> <2C6A1839-8D61-4AEE-A9CB-F40971F61AF7@gmail.com> <8734x6vktd.fsf@euler.schwinge.homeip.net> <22AC949A-3CE2-47E0-83F6-9D0CC6B52C99@gmail.com> <9CB59C76-0451-487C-A708-BBCBEF32D448@gmail.com> <87zfzc1st3.fsf@euler.schwinge.homeip.net> X-Mailer: Apple Mail (2.3774.200.91.1.1) X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --Apple-Mail=_470433E9-B66F-450E-8E41-D02EA9BA0371 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii >> I have done a full rebuild, and having looked more at the structure = of libtool.m4 I am now convinced that having that line outside of the = scope of _LT_DARWIN_LINKER_FEATURES is simply wrong (probably a = copy-pasto or leftover from earlier code). >> Having rebuilt everything, it only manifests itself in = fixincludes/ChangeLog. Iain is traveling right now, but when he is back = I would like to submit this patch if he agrees with the above. It was = regtested on x86_64-apple-darwin21. With the correct patch attached. --Apple-Mail=_470433E9-B66F-450E-8E41-D02EA9BA0371 Content-Disposition: attachment; filename=0001-Build-fix-error-in-fixinclude-configure.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Build-fix-error-in-fixinclude-configure.patch" Content-Transfer-Encoding: quoted-printable =46rom=205394acd8f7c746b264d9b2a7290e4a07f47918cc=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Francois-Xavier=20Coudert=20= =0ADate:=20Fri,=2017=20Nov=202023=2012:50:42=20= +0100=0ASubject:=20[PATCH]=20Build:=20fix=20error=20in=20fixinclude=20= configure=0A=0AThe=20stray=20line=20defining=20enable_darwin_at_rpath=20= outside=20of=20the=20scope=20of=0A_LT_DARWIN_LINKER_FEATURES=20is=20a=20= mistake=20and=20should=20be=20removed.=20It=20leads=0Ato=20a=20wrong=20= line=20in=20fixincludes/ChangeLog=20because=20there=20is=20no=20$1=20= argument=0Aat=20that=20point.=0A=0AChangeLog:=0A=0A=09*=20libtool.m4:=20= Fix=20stray=20call=0A=0Afixincludes/ChangeLog:=0A=0A=09*=20configure:=20= Regenerated.=0A---=0A=20fixincludes/configure=20|=201=20-=0A=20= libtool.m4=20=20=20=20=20=20=20=20=20=20=20=20|=201=20-=0A=202=20files=20= changed,=202=20deletions(-)=0A=0Adiff=20--git=20a/fixincludes/configure=20= b/fixincludes/configure=0Aindex=201bb547a1724..662c94dc112=20100755=0A= ---=20a/fixincludes/configure=0A+++=20b/fixincludes/configure=0A@@=20= -3027,7=20+3027,6=20@@=20ac_configure=3D"$SHELL=20$ac_aux_dir/configure"=20= =20#=20Please=20don't=20use=20this=20var.=0A=20#=20= ---------------------------=0A=20#=20_LT_COMPILER_PIC=0A=20=0A= -enable_darwin_at_rpath_$1=3Dno=0A=20=0A=20#=20= _LT_LINKER_SHLIBS([TAGNAME])=0A=20#=20----------------------------=0A= diff=20--git=20a/libtool.m4=20b/libtool.m4=0Aindex=20= 7f8ae26db62..add2d4a1e23=20100644=0A---=20a/libtool.m4=0A+++=20= b/libtool.m4=0A@@=20-4312,7=20+4312,6=20@@=20= _LT_TAGDECL([link_static_flag],=20[lt_prog_compiler_static],=20[1],=0A=20= =09[Compiler=20flag=20to=20prevent=20dynamic=20linking])=0A=20])#=20= _LT_COMPILER_PIC=0A=20=0A-_LT_TAGVAR(enable_darwin_at_rpath,=20$1)=3Dno=0A= =20=0A=20#=20_LT_LINKER_SHLIBS([TAGNAME])=0A=20#=20= ----------------------------=0A--=20=0A2.39.3=20(Apple=20Git-145)=0A=0A= --Apple-Mail=_470433E9-B66F-450E-8E41-D02EA9BA0371--