From: Mike Stump <mikestump@comcast.net>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: Nicholas Clifton <nickc@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: RFA: Fix calculation of size of builtin setjmp buffer
Date: Thu, 15 May 2014 14:49:00 -0000 [thread overview]
Message-ID: <92837E08-F838-42A8-A614-522CFB1CC868@comcast.net> (raw)
In-Reply-To: <2347976.UgdYmbUUr8@polaris>
On May 15, 2014, at 12:55 AM, Eric Botcazou <ebotcazou@adacore.com> wrote:
> No, that's too complicated and risky, just do the following:
>
> /* builtin_setjmp takes a pointer to 5 words or pointers. */
> if (POINTER_SIZE > BITS_PER_WORD)
> tmp = size_int (4);
> else
> tmp = size_int (5 * BITS_PER_WORD / POINTER_SIZE - 1);
>
> which is simple and safe.
But, fails whenever the size of the mode of the save area is bigger than a certain amount… On my port, the size taken up by the save area is large enough to cause this to fail. :-( The correct bug fix would have my port not fail.
next prev parent reply other threads:[~2014-05-15 14:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 12:55 Nick Clifton
2014-05-06 13:15 ` Jakub Jelinek
2014-05-06 14:34 ` Nicholas Clifton
2014-05-06 14:38 ` Richard Biener
2014-05-06 14:40 ` Jakub Jelinek
2014-05-06 15:07 ` Nicholas Clifton
2014-05-06 20:17 ` Mike Stump
2014-05-08 14:25 ` Nicholas Clifton
2014-05-08 16:08 ` Mike Stump
2014-05-14 8:23 ` Eric Botcazou
2014-05-14 8:17 ` Eric Botcazou
2014-05-14 13:32 ` Nicholas Clifton
2014-05-15 7:56 ` Eric Botcazou
2014-05-15 14:49 ` Mike Stump [this message]
2014-05-16 16:56 ` Eric Botcazou
2014-05-16 8:29 ` Nicholas Clifton
2014-05-16 16:57 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92837E08-F838-42A8-A614-522CFB1CC868@comcast.net \
--to=mikestump@comcast.net \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).