From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 12F4C3858D28 for ; Fri, 31 Mar 2023 19:48:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 12F4C3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680292107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4y7ero9KKLmb6R2S2RPUQ7qcU6HQxB5w8X68xU4AA1o=; b=LGnL0rF+rSGBSdCTs6CCoIA9I9tDASI5spGCGKWP78YZlxvHT40AiD8g5hXkC26e7C32pM U88/h/4mdBpg9hjdUxvDBg5UGttsUOUbxLA85wwyPvjDMFDNfa2TiJsl2Jb2Cht1Eox8Fa CUnNh/xBVyefnmPqheW/Z/5N5X5WzlM= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-253-daVUNR3nONKapMeT3ybxuA-1; Fri, 31 Mar 2023 15:48:25 -0400 X-MC-Unique: daVUNR3nONKapMeT3ybxuA-1 Received: by mail-qt1-f197.google.com with SMTP id n10-20020a05622a11ca00b003e4e30c6c98so12550420qtk.19 for ; Fri, 31 Mar 2023 12:48:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680292105; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FxDxs3W0Rr+j7QESrlmRHL94On+j4m2IBgzVIx+0nqc=; b=goMk58Rjf+3Jhxg7DrIjRzZOUrCNIrXkOnvXHZWq0UXbcoPYFAw3UUvrKl64Y6q11f +If/47E/G9dVPnZgbPNXs/p04l5gCMZNYFMtaVOSWs9tlOH8qi+9xhu5z5o4rO0c1XZk Ovz1sOR/ou70v9RBczRYqCeTm55dD7R9xAXCT8hLKhJTRyzaA/5WoZAaqCmmSenMTcwe ba1nMMkuCLnZTuhrh7chvtLCxALQroqN2vBIAPXsN5KXbqEuhDB76ZMJmrLTVyYK2LjV A8IdZi5VOXyv/XpOttsu6G76yFuEXouSlL0+nHrPXm0yp2MTmaPCBVBzmCaPA588dN8b 890Q== X-Gm-Message-State: AAQBX9f92M8KryZLlTMSwcQKMDDy59jqgnTN7W/E5uV/BfkfINwwuzJf mq1OzGUvArDx2dSxvPscVikI+fElsAHKuvGiGTouYjFS46+ueotR/dxQPkxy38O1v9KlKOWIrT/ O/XsZOtXS+eIJPhRkww== X-Received: by 2002:ad4:5c88:0:b0:5dd:aee7:e008 with SMTP id o8-20020ad45c88000000b005ddaee7e008mr49661097qvh.7.1680292105504; Fri, 31 Mar 2023 12:48:25 -0700 (PDT) X-Google-Smtp-Source: AKy350ZnXQ8lZWLxhfPRaVydibACtmbshnKeycb2I2TsQyc3WX+dJsjeSbKWxVE0u/T+B2J4MYJsdA== X-Received: by 2002:ad4:5c88:0:b0:5dd:aee7:e008 with SMTP id o8-20020ad45c88000000b005ddaee7e008mr49661062qvh.7.1680292105179; Fri, 31 Mar 2023 12:48:25 -0700 (PDT) Received: from ?IPV6:2607:fea8:51dd:1100::1edc? ([2607:fea8:51dd:1100::1edc]) by smtp.gmail.com with ESMTPSA id mk14-20020a056214580e00b005dd8b9345e8sm800989qvb.128.2023.03.31.12.48.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 12:48:24 -0700 (PDT) Message-ID: <929816f5-885c-a17b-219d-ddffd88a83e4@redhat.com> Date: Fri, 31 Mar 2023 15:48:22 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Regression with "recomputation and PR 109154" To: Jakub Jelinek Cc: Jeff Law , Hans-Peter Nilsson , gcc-patches@gcc.gnu.org, richard.guenther@gmail.com, aldyh@redhat.com References: <54bb3bc9-e0c1-b5ab-4447-5908b09fd19f@redhat.com> <20230331161207.DB49620444@pchp3.se.axis.com> <5c5825b2-c4f0-8aa7-c324-8256829e52f5@gmail.com> From: Andrew MacLeod In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------Nzttuvv9loLDtZ4gj7UkrRJo" Content-Language: en-US X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------Nzttuvv9loLDtZ4gj7UkrRJo Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit should we do something like this to tweak the testcases?   or does someone have something else in mind? Richi opened a PR for the STL failure (109350) Andrew On 3/31/23 13:37, Jakub Jelinek wrote: > On Fri, Mar 31, 2023 at 01:02:18PM -0400, Andrew MacLeod wrote: >> I guess it figures the recip is safe to put in, there will not be a divide >> by zero. > I think the problem was that 1/d was hoisted before the loop; as long as > it is guarded with the d > 0.01 or e > 0.005 condition, it is fine. > The test probably should have been a runtime test, doing the main stuff > in some other noipa function and doing fetestexcept after it or something > similar. > >> I guess the test is no longer testing what it should be? >> >> And yes, we could set he param back to 1 for the test... >> add   --param=ranger-recompute-depth=1   makes the "issue" go away :-)  for >> now. > That looks reasonable unless we rewrite the test into runtime one (but we'd > then need to double check that it was really miscompiled and would fail back > then in 4.0). > > Jakub > --------------Nzttuvv9loLDtZ4gj7UkrRJo Content-Type: text/x-patch; charset=UTF-8; name="tc.diff" Content-Disposition: attachment; filename="tc.diff" Content-Transfer-Encoding: base64 Y29tbWl0IDU1YmY0ZjBkNDQzZTVhZGJhY2ZjZGJiZWJmNGIyZTBjNzRkMWRjYzgKQXV0aG9yOiBB bmRyZXcgTWFjTGVvZCA8YW1hY2xlb2RAcmVkaGF0LmNvbT4KRGF0ZTogICBGcmkgTWFyIDMxIDE1 OjQyOjQzIDIwMjMgLTA0MDAKCiAgICBBZGp1c3QgdGVzdGNhc2VzIHRvIG5vdCBwcm9kdWNlIGVy cm9ycy4uCiAgICAKICAgICAgICAgICAgdHJlZS1vcHRpbWl6YXRpb24vMTA5MzYzCiAgICAgICAg ICAgIGdjYy90ZXN0c3VpdGUvCiAgICAgICAgICAgICogZysrLmRnL3dhcm4vV3N0cmluZ29wLW92 ZXJmbG93LTQuQzogQWx3YXlzIGNlaGNrIGJvZ3VzIG1lc3NhZ2UuCiAgICAgICAgICAgICogZ2Nj LmRnL3RyZWUtc3NhL3ByMjMxMDkuYzogRGlzYWJsZSBiZXR0ZXIgcmVjb21wdXRhdGlvbnMuCgpk aWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9nKysuZGcvd2Fybi9Xc3RyaW5nb3Atb3ZlcmZsb3ct NC5DIGIvZ2NjL3Rlc3RzdWl0ZS9nKysuZGcvd2Fybi9Xc3RyaW5nb3Atb3ZlcmZsb3ctNC5DCmlu ZGV4IDM1ZmI1OWUwMjMyLi5mYWFkNWJlZDA3NCAxMDA2NDQKLS0tIGEvZ2NjL3Rlc3RzdWl0ZS9n KysuZGcvd2Fybi9Xc3RyaW5nb3Atb3ZlcmZsb3ctNC5DCisrKyBiL2djYy90ZXN0c3VpdGUvZysr LmRnL3dhcm4vV3N0cmluZ29wLW92ZXJmbG93LTQuQwpAQCAtMTQxLDcgKzE0MSw3IEBAIHZvaWQg dGVzdF9zdHJjcHlfbmV3X2ludDE2X3QgKHNpemVfdCBuLCBjb25zdCBzaXplX3QgdmFsc1tdKQog CiAgIGludCByX2ltaW5faW1heCA9IFNSIChJTlRfTUlOLCBJTlRfTUFYKTsKICAgVCAoUyAoMSks IG5ldyBpbnQxNl90W3JfaW1pbl9pbWF4XSk7Ci0gIFQgKFMgKDIpLCBuZXcgaW50MTZfdFtyX2lt aW5faW1heCArIDFdKTsgLy8geyBkZy1ib2d1cyAiaW50byBhIHJlZ2lvbiBvZiBzaXplIiAicHIx MDYxMjAiIHsgeGZhaWwgeyBpbHAzMiAmJiBjKys5OF9vbmx5IH0gfSB9CisgIFQgKFMgKDIpLCBu ZXcgaW50MTZfdFtyX2ltaW5faW1heCArIDFdKTsgLy8geyBkZy1ib2d1cyAiaW50byBhIHJlZ2lv biBvZiBzaXplIiAicHIxMDYxMjAiIHsgeGZhaWwgeyBjKys5OF9vbmx5IH0gfSB9CiAgIFQgKFMg KDkpLCBuZXcgaW50MTZfdFtyX2ltaW5faW1heCAqIDIgKyAxXSk7CiAKICAgaW50IHJfMF9pbWF4 ID0gU1IgKDAsIElOVF9NQVgpOwpkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvdHJl ZS1zc2EvcHIyMzEwOS5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvdHJlZS1zc2EvcHIyMzEwOS5j CmluZGV4IDdjZGYxZDA1ZWU3Li4wNTlmNjU4ZWEyMCAxMDA2NDQKLS0tIGEvZ2NjL3Rlc3RzdWl0 ZS9nY2MuZGcvdHJlZS1zc2EvcHIyMzEwOS5jCisrKyBiL2djYy90ZXN0c3VpdGUvZ2NjLmRnL3Ry ZWUtc3NhL3ByMjMxMDkuYwpAQCAtMSw2ICsxLDcgQEAKIC8qIHsgZGctZG8gY29tcGlsZSB9ICov Ci0vKiB7IGRnLW9wdGlvbnMgIi1PMiAtZnVuc2FmZS1tYXRoLW9wdGltaXphdGlvbnMgLWZ0cmFw cGluZy1tYXRoIC1mZHVtcC10cmVlLXJlY2lwIC1mZHVtcC10cmVlLWxpbTIiIH0gKi8KKy8qIHsg ZGctb3B0aW9ucyAiLU8yIC1mdW5zYWZlLW1hdGgtb3B0aW1pemF0aW9ucyAtZnRyYXBwaW5nLW1h dGggLWZkdW1wLXRyZWUtcmVjaXAgLWZkdW1wLXRyZWUtbGltMiAtLXBhcmFtPXJhbmdlci1yZWNv bXB1dGUtZGVwdGg9MSIgfSAqLwogLyogeyBkZy13YXJuaW5nICInLWZhc3NvY2lhdGl2ZS1tYXRo JyBkaXNhYmxlZCIgIiIgeyB0YXJnZXQgKi0qLSogfSAwIH0gKi8KKy8qIHJhbmdlci1yZWNvbXB1 dGUtZGVwdGggcHJldmVudHMgdGhlIG9wdGltaXplcnMgZnJvbSBiZWluZyB0b28gc21hcnQuICAq LwogCiBkb3VibGUgRlsyXSA9IHsgMC4sIDAuIH0sIGUgPSAwLjsKIAo= --------------Nzttuvv9loLDtZ4gj7UkrRJo--