From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id F094F386480A for ; Fri, 18 Aug 2023 20:17:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F094F386480A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="6.01,184,1684828800"; d="scan'208";a="16587141" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 18 Aug 2023 12:17:23 -0800 IronPort-SDR: xoGJtWo0zR7m5jYfRSu8sHHihRZPLjFzc5Tpv/kWkJB7ZoF0TDMBStKs6EgRZs712okQnQlG7s 6Kf07N0sw/2VGYlX02/gfrQ7FcBBL4QhfS93TY7VV9k+C1tLkM/QWaIRK232vXlXWOWElV5HgT u7EH9bv1rcpv3hXhUTPnUoj5fGLBTHE+J+C2p+mSAZNx3aR/0Wxwy4ii4/gpwf5uljfCTKK8KE Ef4OYZSTH10gpX+QDRklbzce3a9lMSN5l2+5OD3AsmgbkcaC/R8TA5QcrCVvzoKQb2eXvcbXKK N/U= Date: Fri, 18 Aug 2023 20:17:19 +0000 From: Joseph Myers To: FX Coudert CC: , Iain Sandoe Subject: Re: Darwin: Replace environment runpath with embedded [PR88590] In-Reply-To: Message-ID: <92993a50-9667-45da-a62-5089e7e052f8@codesourcery.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3104.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 15 Aug 2023, FX Coudert via Gcc-patches wrote: > I am currently retesting the patches on various archs (Linux and Darwin) > after a final rebase, but various previous versions were > regression-tested, and have been shipped for a long time in Homebrew. > > OK to commit? The driver changes are OK. I think the new configure options and the new -nodefaultrpaths compiler option need documenting (I suppose there might be a case for the configure option defined in libtool code being documented somewhere in libtool, if there's somewhere appropriate, but I don't see that in the libtool patch submission). The help text for --enable-darwin-at-rpath refers to it as --enable-darwin-at-path. Somewhere the documentation ought to discuss the considerations around embedding such paths in binaries, and what's appropriate for building a binary on the system where it's going to be used, versus using the compiler to build redistributed binaries that will be run on a system that doesn't have the compiler installed (and so shouldn't have hardcoded paths that were only applicable on the system with the compiler, but will need to be able to find shared libraries - probably shipped with the binary - somehow). -- Joseph S. Myers joseph@codesourcery.com