From: FX <fxcoudert@gmail.com>
To: Jack Howarth <howarth.at.gcc@gmail.com>,
Richard Henderson <rth@redhat.com>,
Jakub Jelinek <jakub@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Fortran List <fortran@gcc.gnu.org>
Subject: Re: [patch,libgomp] Make libgomp Fortran modules multilib-aware
Date: Mon, 09 Jan 2017 10:04:00 -0000 [thread overview]
Message-ID: <929E41CA-3ADF-4C09-90D5-CD13660F5E35@gmail.com> (raw)
In-Reply-To: <765E0C1E-597F-427F-909A-1DD909512431@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 118 bytes --]
Given lack of review of this Fortran-specific patch for libgomp, can a Fortran maintainer approve it please?
FX
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 612 bytes --]
Index: libgomp/Makefile.am
===================================================================
--- libgomp/Makefile.am (revision 235843)
+++ libgomp/Makefile.am (working copy)
@@ -10,7 +10,7 @@ config_path = @config_path@
search_path = $(addprefix $(top_srcdir)/config/, $(config_path)) $(top_srcdir) \
$(top_srcdir)/../include
-fincludedir = $(libdir)/gcc/$(target_alias)/$(gcc_version)/finclude
+fincludedir = $(libdir)/gcc/$(target_alias)/$(gcc_version)$(MULTISUBDIR)/finclude
libsubincludedir = $(libdir)/gcc/$(target_alias)/$(gcc_version)/include
vpath % $(strip $(search_path))
[-- Attachment #3: Type: text/plain, Size: 988 bytes --]
> *ping*
>
> This patch from May makes libgomp install its Fortran modules in the correct multilib-aware directories, following what libgfortran does.
>
>
>
>
>> The attached patch allows libgomp to install its Fortran modules in the correct multilib-aware directories, just like libgfortran does.
>> Without it, multilib Fortran OpenMP code using the modules fails to compile because the modules are not found:
>>
>> $ gfortran -fopenmp a.f90
>> $ gfortran -fopenmp a.f90 -m32
>> a.f90:1:6:
>>
>> use omp_lib
>> 1
>> Fatal Error: Can't open module file ‘omp_lib.mod’ for reading at (1): No such file or directory
>> compilation terminated.
>>
>>
>>
>> Bootstrapped and tested on x86_64-apple-darwin15. OK to commit?
>>
>> FX
>>
>>
>>
>>
>>
>>
>> 2016-05-03 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
>>
>> PR libgomp/60670
>> * Makefile.am: Make fincludedir multilib-aware.
>> * Makefile.in: Regenerate.
next prev parent reply other threads:[~2017-01-09 10:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4795FF84-EC6B-448F-991E-AAA8948D5EE4@gmail.com>
[not found] ` <CAJMcOU-k8ni+y05YH6CaxH3KAmHNjSYkXAqs-NYPWaNztK+Xtw@mail.gmail.com>
[not found] ` <93D9F5BF-2BFD-4DC9-957E-EB3CAA41E7D9@gmail.com>
[not found] ` <AD0AE248-C557-4A37-87C5-BFE14DCA4F96@gmail.com>
2016-12-26 11:28 ` FX
2017-01-09 10:04 ` FX [this message]
2017-01-09 18:50 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=929E41CA-3ADF-4C09-90D5-CD13660F5E35@gmail.com \
--to=fxcoudert@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=howarth.at.gcc@gmail.com \
--cc=jakub@redhat.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).