From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59859 invoked by alias); 28 Apr 2017 12:41:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 59759 invoked by uid 89); 28 Apr 2017 12:41:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=that'll, thatll, investigator, H*MI:sk:c870583 X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Apr 2017 12:41:49 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 28984ACB7; Fri, 28 Apr 2017 12:41:49 +0000 (UTC) Subject: Re: [PATCH 5/8] Make gcno more precise about BBs really belonging to a line (PR gcov-profile/79891). To: Nathan Sidwell , gcc-patches@gcc.gnu.org References: Cc: hubicka@ucw.cz From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <929d909d-415f-b6cc-e04e-6dd27ca8ee13@suse.cz> Date: Fri, 28 Apr 2017 13:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg01486.txt.bz2 On 04/28/2017 01:41 PM, Nathan Sidwell wrote: > On 04/25/2017 09:08 AM, marxin wrote: >> gcc/ChangeLog: >> >> 2017-04-26 Martin Liska >> >> PR gcov-profile/79891 >> * gcov.c (add_line_counts): Assign BBs to lines just if the BB >> is marked by compiler as living on a line. >> (get_cycles_count): Remove usage of the union. >> (output_intermediate_file): Likewise. >> (find_source): Fix GNU coding style. >> (accumulate_line_counts): Remove old non-all block mode. >> (output_lines): Remove usage of the union. >> * profile.c (output_location): Include all BBs, even if >> belonging to a same line (and file) as a previous BB. >> > > >> @@ -2269,32 +2262,32 @@ add_line_counts (coverage_t *coverage, function_t *fn) >> block->cycle.arc = NULL; >> block->cycle.ident = ~0U; >> + if (!has_any_line) >> + has_any_line = true; > > You know, you're allowed to set a true bool to true :) Heh, stupid mistake. Actually, can be funny warning candidate. I guess I'm not first who did it. > > Could you annotate the testcase with what the original problem was? Sure, however I do not expect any PRs related to this commit. No, I'm kidding, the patch make a significant changes :) Martin > I think that'll help a future regression investigator. > > otherwise ok. > > nathan >