From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: SenthilKumar.Selvaraj@microchip.com,
"SenthilKumar.Selvaraj--- via Gcc-patches"
<gcc-patches@gcc.gnu.org>,
richard.guenther@gmail.com
Cc: gcc-patches@gcc.gnu.org, chertykov@gmail.com
Subject: Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]
Date: Fri, 19 May 2023 16:02:08 +0200 [thread overview]
Message-ID: <92A00825-A5ED-4AAC-925E-117B5D9422FF@gmail.com> (raw)
In-Reply-To: <F9C516B1-0A96-4960-B15A-6E3A681442E2@microchip.com>
On 19 May 2023 07:58:48 CEST, "SenthilKumar.Selvaraj--- via Gcc-patches" <gcc-patches@gcc.gnu.org> wrote:
Just a nit:
>+static bool
>+avr_addr_space_zero_address_valid (addr_space_t as ATTRIBUTE_UNUSED)
>+{
>+ return flag_delete_null_pointer_checks == 0;
>+}
Since we are c++ nowadays, you can omit the parameter name for unused arguments. I.e.:
static bool
avr_addr_space_zero_address_valid (addr_space_t)
{
...
next prev parent reply other threads:[~2023-05-19 14:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 9:00 SenthilKumar.Selvaraj
2023-04-26 9:42 ` Richard Biener
2023-04-26 9:43 ` Richard Biener
2023-04-26 10:56 ` SenthilKumar.Selvaraj
2023-04-26 12:19 ` Richard Biener
2023-05-19 5:58 ` SenthilKumar.Selvaraj
2023-05-19 14:02 ` Bernhard Reutner-Fischer [this message]
2023-05-19 16:51 ` Jeff Law
2023-05-22 12:05 ` Richard Biener
2023-06-02 7:02 ` SenthilKumar.Selvaraj
2023-06-16 10:17 ` [Ping] " SenthilKumar.Selvaraj
2023-06-17 16:56 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92A00825-A5ED-4AAC-925E-117B5D9422FF@gmail.com \
--to=rep.dot.nop@gmail.com \
--cc=SenthilKumar.Selvaraj@microchip.com \
--cc=chertykov@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).