public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: FX <fxcoudert@gmail.com>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	nd@arm.com, FranC'ois-Xavier Coudert <fxcoudert@gcc.gnu.org>,
	Jerry DeLisle <jvdelisle@gcc.gnu.org>,
	GCC-Fortran-ML <fortran@gcc.gnu.org>
Subject: Re: [PATCH][PR libgfortran/78314] Fix ieee_support_halting
Date: Tue, 15 Nov 2016 16:22:00 -0000	[thread overview]
Message-ID: <92DFB085-F0FF-4B30-B6BB-B10E598B6030@gmail.com> (raw)
In-Reply-To: <582B3331.30402@arm.com>

Hi,

> There seems to be a separate api for checking trapping support:
> ieee_support_halting, but it only checked if the exception status
> flags are available, so check trapping support too by enabling
> and disabling traps.

Thanks for the patch.

I am worried about the unnecessary operations that we’re doing here: doesn’t glibc have a way to tell you what it supports without having to do it (twice, enabling then disabling)?

Also, the glibc doc states that: "Each of the macros FE_DIVBYZERO, FE_INEXACT, FE_INVALID, FE_OVERFLOW, FE_UNDERFLOW is defined when the implementation supports handling of the corresponding exception”. It evens says:

> Each constant is defined if and only if the FPU you are compiling for supports that exception, so you can test for FPU support with ‘#ifdef’.

So it seems rather clear that compile-time tests are the recommended way to go.

FX

  reply	other threads:[~2016-11-15 16:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15 16:09 Szabolcs Nagy
2016-11-15 16:22 ` FX [this message]
2016-11-15 16:38   ` Szabolcs Nagy
2016-11-15 16:56     ` FX
2016-11-16 16:53       ` [PATCH v2][PR " Szabolcs Nagy
2016-11-16 17:18         ` FX
2016-11-18 17:20         ` Szabolcs Nagy
     [not found]           ` <10A25923-4354-4032-86A1-D97D2A5CB58E@gmail.com>
2016-11-21 14:16             ` FX
2016-11-21 15:43               ` Szabolcs Nagy
2016-11-22 10:06               ` Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92DFB085-F0FF-4B30-B6BB-B10E598B6030@gmail.com \
    --to=fxcoudert@gmail.com \
    --cc=fortran@gcc.gnu.org \
    --cc=fxcoudert@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jvdelisle@gcc.gnu.org \
    --cc=nd@arm.com \
    --cc=szabolcs.nagy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).