From: Iain Sandoe <idsandoe@googlemail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Hongtao Liu <crazylht@gmail.com>,
liuhongt <hongtao.liu@intel.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH] Explicitly add -msse2 to compile HF related libgcc source file.
Date: Mon, 6 Sep 2021 08:49:27 +0100 [thread overview]
Message-ID: <92E99F52-C804-4F37-870F-C559A46A8C38@googlemail.com> (raw)
In-Reply-To: <20210906070855.GL920497@tucnak>
> On 6 Sep 2021, at 08:08, Jakub Jelinek via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
>
> On Mon, Sep 06, 2021 at 09:42:32AM +0800, Hongtao Liu wrote:
>>> Also, shouldn't the *hf* and *hc* APIs be exported from libgcc_s.so.1?
>>>
>>> 254: 0000000000011960 968 FUNC LOCAL DEFAULT 13 __floattihf
>>> 256: 00000000000116f0 315 FUNC LOCAL DEFAULT 13 __fixhfti
>>> 263: 000000000000f950 1358 FUNC LOCAL DEFAULT 13 __truncsfhf2
>>> 264: 000000000000db10 272 FUNC LOCAL DEFAULT 13 __extendhfsf2
>>> 265: 000000000000df70 399 FUNC LOCAL DEFAULT 13 __extendhfxf2
>>> 267: 0000000000011fe0 469 FUNC LOCAL DEFAULT 13 __eqhf2
>>> 268: 0000000000011d30 681 FUNC LOCAL DEFAULT 13 __floatuntihf
>>> 271: 000000000000dc20 374 FUNC LOCAL DEFAULT 13 __extendhfdf2
>>> 274: 0000000000011830 292 FUNC LOCAL DEFAULT 13 __fixunshfti
>>> 281: 000000000000dda0 460 FUNC LOCAL DEFAULT 13 __extendhftf2
>>> 283: 000000000000e860 1439 FUNC LOCAL DEFAULT 13 __trunctfhf2
>>> 285: 0000000000011fe0 469 FUNC LOCAL DEFAULT 13 __nehf2
>>> 286: 0000000000006290 1627 FUNC LOCAL DEFAULT 13 __divhc3
>>> 290: 000000000000ee00 1499 FUNC LOCAL DEFAULT 13 __truncxfhf2
>>> 292: 000000000000f3e0 1392 FUNC LOCAL DEFAULT 13 __truncdfhf2
>>> 296: 0000000000005150 1931 FUNC LOCAL DEFAULT 13 __mulhc3
>>>
>>> So, don't we want GCC_12.0 with those symbols
>>> in config/i386/libgcc-glibc.ver and perhaps others?
>>>
>>> Jakub
>>>
>>
>> Here is an updated patch.
>
> Ok. The *.ver changes are still needed (see above), but that can be done
> incrementally.
I can commit the .ver change if that’s approved, sure - for the record I haven’t checked
any targets other than Darwin and Linux.
Iain
next prev parent reply other threads:[~2021-09-06 7:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 7:41 liuhongt
2021-09-03 9:00 ` Jakub Jelinek
2021-09-03 12:32 ` Iain Sandoe
2021-09-03 12:33 ` Jakub Jelinek
2021-09-03 12:36 ` Iain Sandoe
2021-09-06 8:01 ` Jakub Jelinek
2021-09-06 1:42 ` Hongtao Liu
2021-09-06 7:08 ` Jakub Jelinek
2021-09-06 7:49 ` Iain Sandoe [this message]
2021-09-06 8:58 ` [PATCH] libgcc, i386: Export *hf* and *hc* from libgcc_s.so.1 Jakub Jelinek
2021-09-07 12:28 ` Jakub Jelinek
2021-09-08 0:54 ` Hongtao Liu
2021-09-08 2:37 ` Hongtao Liu
2021-09-08 9:09 ` Jakub Jelinek
2021-09-08 9:31 ` Hongtao Liu
2021-09-18 19:13 ` Iain Sandoe
2021-09-19 3:49 ` Hongtao Liu
2021-09-06 1:43 ` [PATCH] Explicitly add -msse2 to compile HF related libgcc source file Hongtao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92E99F52-C804-4F37-870F-C559A46A8C38@googlemail.com \
--to=idsandoe@googlemail.com \
--cc=crazylht@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongtao.liu@intel.com \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).