From: Bill Schmidt <wschmidt@linux.vnet.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
jakub@redhat.com, David Edelsohn <dje.gcc@gmail.com>
Subject: Re: [PATCH, rs6000] Clean up capitalized diagnostic messages
Date: Thu, 03 Aug 2017 18:28:00 -0000 [thread overview]
Message-ID: <92EDD1B5-A18B-40A2-A01A-3A42AA43B633@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170802234336.GU13471@gate.crashing.org>
> On Aug 2, 2017, at 6:43 PM, Segher Boessenkool <segher@kernel.crashing.org> wrote:
>
> Hi Bill,
>
> On Wed, Aug 02, 2017 at 10:29:20AM -0500, Bill Schmidt wrote:
>> I don't anticipate backporting any of this.
>
> Good :-)
>
>> @@ -6802,7 +6802,7 @@ altivec_resolve_overloaded_builtin (location_t loc
>> if (unsupported_builtin)
>> {
>> const char *name = rs6000_overloaded_builtin_name (fcode);
>> - error ("Builtin function %s not supported in this compiler configuration",
>> + error ("builtin function %s not supported in this compiler configuration",
>> name);
>
> As Martin says, %qs for this and similar (see the documentation before
> pp_format in pretty-print.c). Can be a separate patch of course, this
> one is big enough already.
>
>> Index: gcc/config/rs6000/rs6000.c
>> ===================================================================
>> --- gcc/config/rs6000/rs6000.c (revision 250791)
>> +++ gcc/config/rs6000/rs6000.c (working copy)
>> @@ -4132,7 +4132,7 @@ rs6000_option_override_internal (bool global_init_
>> || rs6000_cpu == PROCESSOR_PPCE5500)
>> {
>> if (TARGET_ALTIVEC)
>> - error ("AltiVec not supported in this target");
>> + error ("altivec not supported in this target");
>> }
>>
>> /* If we are optimizing big endian systems for space, use the load/store
>
> Let's either keep AltiVec or say -maltivec. We only have this warning
> because we allow -maltivec with CPUs that do not support it; and this
> warning is only for some of the FSL CPUs. It isn't very consistent.
Back to AltiVec it goes! Thanks.
>
>> @@ -4250,7 +4250,7 @@ rs6000_option_override_internal (bool global_init_
>> rs6000_isa_flags |= (ISA_3_0_MASKS_SERVER & ~ignore_masks);
>> }
>> else
>> - error ("Power9 target option is incompatible with -mcpu=<xxx> for "
>> + error ("power9 target option is incompatible with -mcpu=<xxx> for "
>> "<xxx> less than power9");
>> }
>> else if ((ISA_3_0_MASKS_SERVER & rs6000_isa_flags_explicit)
>
> See also PR79477. Since many of these options are going away it is
> probably not worth spending too much time on this, not until stage 3
> or so anyway.
Yeah, let's address that later in the year after Mike finishes his cleanups.
>
>> @@ -11226,7 +11226,7 @@ rs6000_return_in_memory (const_tree type, const_tr
>> static bool warned_for_return_big_vectors = false;
>> if (!warned_for_return_big_vectors)
>> {
>> - warning (OPT_Wpsabi, "GCC vector returned by reference: "
>> + warning (OPT_Wpsabi, "gcc vector returned by reference: "
>> "non-standard ABI extension with no compatibility guarantee");
>> warned_for_return_big_vectors = true;
>> }
>
> Maybe the warning should just say "big vector"? Or "generic vector"?
>
> (Vectors that fit in one VR, or in GPRs in 8 bytes or less, do not have
> the problem this warns for. Kind of hard to express tersely and
> precisely though).
I looked in the GCC manual and couldn't find a better way of expressing
this than just "GCC vector," so I will return it to the way it was. "GCC
vector extension vector" is accurate but hardly trips lightly off the
tongue...
>
> Approved for trunk with whichever of the suggested changes you think
> are good. Thanks,
Thanks much!
Bill
>
>
> Segher
>
next prev parent reply other threads:[~2017-08-03 18:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 15:29 Bill Schmidt
2017-08-02 15:55 ` Jakub Jelinek
2017-08-02 16:04 ` Joseph Myers
2017-08-02 18:50 ` Bill Schmidt
2017-08-02 16:49 ` Martin Sebor
2017-08-02 23:44 ` Segher Boessenkool
2017-08-03 18:28 ` Bill Schmidt [this message]
2017-08-06 8:08 ` Andreas Schwab
2017-08-07 10:51 ` Segher Boessenkool
2017-08-08 12:46 ` Bill Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92EDD1B5-A18B-40A2-A01A-3A42AA43B633@linux.vnet.ibm.com \
--to=wschmidt@linux.vnet.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).