public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH, rs6000] Clean up capitalized diagnostic messages
@ 2017-08-02 15:29 Bill Schmidt
  2017-08-02 15:55 ` Jakub Jelinek
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Bill Schmidt @ 2017-08-02 15:29 UTC (permalink / raw)
  To: GCC Patches; +Cc: Segher Boessenkool, jakub, David Edelsohn

Hi,

Jakub pointed out that we've had several error messages slip into the POWER back end
that incorrectly start with a capital letter.  This patch hunts those down and cleans
them up.

Bootstrapped and tested on powerpc64le-linux-gnu with no regressions.  Is this ok for
trunk?  I don't anticipate backporting any of this.

Thanks,
Bill


[gcc]

2017-08-02  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

	* config/rs6000/rs6000-c.c (altivec_resolve_overloaded_builtin):
	Don't start diagnostic messages with a capital letter.
	* config/rs6000/rs6000.c (rs6000_option_override_internal):
	Likewise.
	(rs6000_return_in_memory): Likewise.
	(rs6000_pass_by_reference): Likewise.
	(rs6000_invalid_builtin): Likewise.
	(rs6000_trampoline_init): Likewise.

[gcc/testsuite]

2017-08-02  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>

	* gcc.dg/pr35442.c: Adjust for error messages that used to start
	with a capital letter.
	* gcc.target/powerpc/bfp/scalar-cmp-exp-eq-2.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-cmp-exp-gt-2.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-cmp-exp-lt-2.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-cmp-unordered-2.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-extract-exp-1.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-extract-exp-4.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-extract-sig-1.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-extract-sig-4.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-insert-exp-1.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-insert-exp-10.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-insert-exp-4.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-insert-exp-7.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-test-data-class-11.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-test-data-class-6.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-test-data-class-7.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-test-neg-2.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-test-neg-3.c: Likewise.
	* gcc.target/powerpc/bfp/scalar-test-neg-5.c: Likewise.
	* gcc.target/powerpc/bfp/vec-extract-exp-2.c: Likewise.
	* gcc.target/powerpc/bfp/vec-extract-exp-3.c: Likewise.
	* gcc.target/powerpc/bfp/vec-extract-sig-2.c: Likewise.
	* gcc.target/powerpc/bfp/vec-extract-sig-3.c: Likewise.
	* gcc.target/powerpc/bfp/vec-insert-exp-2.c: Likewise.
	* gcc.target/powerpc/bfp/vec-insert-exp-3.c: Likewise.
	* gcc.target/powerpc/bfp/vec-insert-exp-6.c: Likewise.
	* gcc.target/powerpc/bfp/vec-insert-exp-7.c: Likewise.
	* gcc.target/powerpc/bfp/vec-test-data-class-2.c: Likewise.
	* gcc.target/powerpc/bfp/vec-test-data-class-3.c: Likewise.
	* gcc.target/powerpc/byte-in-either-range-1.c: Likewise.
	* gcc.target/powerpc/byte-in-range-1.c: Likewise.
	* gcc.target/powerpc/byte-in-set-1.c: Likewise.
	* gcc.target/powerpc/crypto-builtin-2.c: Likewise.
	* gcc.target/powerpc/dfp/dtstsfi-1.c: Likewise.
	* gcc.target/powerpc/dfp/dtstsfi-11.c: Likewise.
	* gcc.target/powerpc/dfp/dtstsfi-16.c: Likewise.
	* gcc.target/powerpc/dfp/dtstsfi-21.c: Likewise.
	* gcc.target/powerpc/dfp/dtstsfi-26.c: Likewise.
	* gcc.target/powerpc/dfp/dtstsfi-31.c: Likewise.
	* gcc.target/powerpc/dfp/dtstsfi-36.c: Likewise.
	* gcc.target/powerpc/dfp/dtstsfi-41.c: Likewise.
	* gcc.target/powerpc/dfp/dtstsfi-46.c: Likewise.
	* gcc.target/powerpc/dfp/dtstsfi-51.c: Likewise.
	* gcc.target/powerpc/dfp/dtstsfi-56.c: Likewise.
	* gcc.target/powerpc/dfp/dtstsfi-6.c: Likewise.
	* gcc.target/powerpc/dfp/dtstsfi-61.c: Likewise.
	* gcc.target/powerpc/dfp/dtstsfi-66.c: Likewise.
	* gcc.target/powerpc/dfp/dtstsfi-71.c: Likewise.
	* gcc.target/powerpc/dfp/dtstsfi-76.c: Likewise.
	* gcc.target/powerpc/vsu/vec-all-nez-7.c: Likewise.
	* gcc.target/powerpc/vsu/vec-any-eqz-7.c: Likewise.
	* gcc.target/powerpc/vsu/vec-cmpnez-7.c: Likewise.
	* gcc.target/powerpc/vsu/vec-cntlz-lsbb-2.c: Likewise.
	* gcc.target/powerpc/vsu/vec-cnttz-lsbb-2.c: Likewise.
	* gcc.target/powerpc/vsu/vec-xl-len-12.c: Likewise.
	* gcc.target/powerpc/vsu/vec-xlx-7.c: Likewise.
	* gcc.target/powerpc/vsu/vec-xrx-7.c: Likewise.
	* gcc.target/powerpc/vsu/vec-xst-len-12.c: Likewise.


Index: gcc/config/rs6000/rs6000-c.c
===================================================================
--- gcc/config/rs6000/rs6000-c.c	(revision 250791)
+++ gcc/config/rs6000/rs6000-c.c	(working copy)
@@ -6802,7 +6802,7 @@ altivec_resolve_overloaded_builtin (location_t loc
     if (unsupported_builtin)
       {
 	const char *name = rs6000_overloaded_builtin_name (fcode);
-	error ("Builtin function %s not supported in this compiler configuration",
+	error ("builtin function %s not supported in this compiler configuration",
 	       name);
 	return error_mark_node;
       }
Index: gcc/config/rs6000/rs6000.c
===================================================================
--- gcc/config/rs6000/rs6000.c	(revision 250791)
+++ gcc/config/rs6000/rs6000.c	(working copy)
@@ -4132,7 +4132,7 @@ rs6000_option_override_internal (bool global_init_
       || rs6000_cpu == PROCESSOR_PPCE5500)
     {
       if (TARGET_ALTIVEC)
-	error ("AltiVec not supported in this target");
+	error ("altivec not supported in this target");
     }
 
   /* If we are optimizing big endian systems for space, use the load/store
@@ -4250,7 +4250,7 @@ rs6000_option_override_internal (bool global_init_
 	      rs6000_isa_flags |= (ISA_3_0_MASKS_SERVER & ~ignore_masks);
 	    }
 	  else
-	    error ("Power9 target option is incompatible with -mcpu=<xxx> for "
+	    error ("power9 target option is incompatible with -mcpu=<xxx> for "
 		   "<xxx> less than power9");
 	}
       else if ((ISA_3_0_MASKS_SERVER & rs6000_isa_flags_explicit)
@@ -11226,7 +11226,7 @@ rs6000_return_in_memory (const_tree type, const_tr
       static bool warned_for_return_big_vectors = false;
       if (!warned_for_return_big_vectors)
 	{
-	  warning (OPT_Wpsabi, "GCC vector returned by reference: "
+	  warning (OPT_Wpsabi, "gcc vector returned by reference: "
 		   "non-standard ABI extension with no compatibility guarantee");
 	  warned_for_return_big_vectors = true;
 	}
@@ -12773,7 +12773,7 @@ rs6000_pass_by_reference (cumulative_args_t cum AT
 	fprintf (stderr, "function_arg_pass_by_reference: synthetic vector\n");
       if (!warned_for_pass_big_vectors)
 	{
-	  warning (OPT_Wpsabi, "GCC vector passed by reference: "
+	  warning (OPT_Wpsabi, "gcc vector passed by reference: "
 		   "non-standard ABI extension with no compatibility guarantee");
 	  warned_for_pass_big_vectors = true;
 	}
@@ -16060,45 +16060,45 @@ rs6000_invalid_builtin (enum rs6000_builtins fncod
 
   gcc_assert (name != NULL);
   if ((fnmask & RS6000_BTM_CELL) != 0)
-    error ("Builtin function %s is only valid for the cell processor", name);
+    error ("builtin function %s is only valid for the cell processor", name);
   else if ((fnmask & RS6000_BTM_VSX) != 0)
-    error ("Builtin function %s requires the -mvsx option", name);
+    error ("builtin function %s requires the -mvsx option", name);
   else if ((fnmask & RS6000_BTM_HTM) != 0)
-    error ("Builtin function %s requires the -mhtm option", name);
+    error ("builtin function %s requires the -mhtm option", name);
   else if ((fnmask & RS6000_BTM_ALTIVEC) != 0)
-    error ("Builtin function %s requires the -maltivec option", name);
+    error ("builtin function %s requires the -maltivec option", name);
   else if ((fnmask & RS6000_BTM_PAIRED) != 0)
-    error ("Builtin function %s requires the -mpaired option", name);
+    error ("builtin function %s requires the -mpaired option", name);
   else if ((fnmask & (RS6000_BTM_DFP | RS6000_BTM_P8_VECTOR))
 	   == (RS6000_BTM_DFP | RS6000_BTM_P8_VECTOR))
-    error ("Builtin function %s requires the -mhard-dfp and"
+    error ("builtin function %s requires the -mhard-dfp and"
 	   " -mpower8-vector options", name);
   else if ((fnmask & RS6000_BTM_DFP) != 0)
-    error ("Builtin function %s requires the -mhard-dfp option", name);
+    error ("builtin function %s requires the -mhard-dfp option", name);
   else if ((fnmask & RS6000_BTM_P8_VECTOR) != 0)
-    error ("Builtin function %s requires the -mpower8-vector option", name);
+    error ("builtin function %s requires the -mpower8-vector option", name);
   else if ((fnmask & (RS6000_BTM_P9_VECTOR | RS6000_BTM_64BIT))
 	   == (RS6000_BTM_P9_VECTOR | RS6000_BTM_64BIT))
-    error ("Builtin function %s requires the -mcpu=power9 and"
+    error ("builtin function %s requires the -mcpu=power9 and"
 	   " -m64 options", name);
   else if ((fnmask & RS6000_BTM_P9_VECTOR) != 0)
-    error ("Builtin function %s requires the -mcpu=power9 option", name);
+    error ("builtin function %s requires the -mcpu=power9 option", name);
   else if ((fnmask & (RS6000_BTM_P9_MISC | RS6000_BTM_64BIT))
 	   == (RS6000_BTM_P9_MISC | RS6000_BTM_64BIT))
-    error ("Builtin function %s requires the -mcpu=power9 and"
+    error ("builtin function %s requires the -mcpu=power9 and"
 	   " -m64 options", name);
   else if ((fnmask & RS6000_BTM_P9_MISC) == RS6000_BTM_P9_MISC)
-    error ("Builtin function %s requires the -mcpu=power9 option", name);
+    error ("builtin function %s requires the -mcpu=power9 option", name);
   else if ((fnmask & (RS6000_BTM_HARD_FLOAT | RS6000_BTM_LDBL128))
 	   == (RS6000_BTM_HARD_FLOAT | RS6000_BTM_LDBL128))
-    error ("Builtin function %s requires the -mhard-float and"
+    error ("builtin function %s requires the -mhard-float and"
 	   " -mlong-double-128 options", name);
   else if ((fnmask & RS6000_BTM_HARD_FLOAT) != 0)
-    error ("Builtin function %s requires the -mhard-float option", name);
+    error ("builtin function %s requires the -mhard-float option", name);
   else if ((fnmask & RS6000_BTM_FLOAT128) != 0)
-    error ("Builtin function %s requires the -mfloat128 option", name);
+    error ("builtin function %s requires the -mfloat128 option", name);
   else
-    error ("Builtin function %s is not supported with the current options",
+    error ("builtin function %s is not supported with the current options",
 	   name);
 }
 
@@ -32272,7 +32272,7 @@ rs6000_trampoline_init (rtx m_tramp, tree fndecl,
 	rtx fnmem, fn_reg, toc_reg;
 
 	if (!TARGET_POINTERS_TO_NESTED_FUNCTIONS)
-	  error ("You cannot take the address of a nested function if you use "
+	  error ("you cannot take the address of a nested function if you use "
 		 "the -mno-pointers-to-nested-functions option.");
 
 	fnmem = gen_const_mem (Pmode, force_reg (Pmode, fnaddr));
Index: gcc/testsuite/gcc.dg/pr35442.c
===================================================================
--- gcc/testsuite/gcc.dg/pr35442.c	(revision 250791)
+++ gcc/testsuite/gcc.dg/pr35442.c	(working copy)
@@ -12,4 +12,4 @@ foo (A a)
 }
 
 /* Ignore a warning that is irrelevant to the purpose of this test.  */
-/* { dg-prune-output "(.*GCC vector passed by reference.*|.*ABI for * passing parameters with.*)" } */
+/* { dg-prune-output "(.*gcc vector passed by reference.*|.*ABI for * passing parameters with.*)" } */
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-cmp-exp-eq-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-cmp-exp-eq-2.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-cmp-exp-eq-2.c	(working copy)
@@ -12,5 +12,5 @@ compare_exponents_eq (double *exponent1_p, double
   double exponent1 = *exponent1_p;
   double exponent2 = *exponent2_p;
 
-  return __builtin_vec_scalar_cmp_exp_eq (exponent1, exponent2);	/* { dg-error "Builtin function __builtin_vsx_scalar_cmp_exp_dp_eq requires" } */
+  return __builtin_vec_scalar_cmp_exp_eq (exponent1, exponent2);	/* { dg-error "builtin function __builtin_vsx_scalar_cmp_exp_dp_eq requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-cmp-exp-gt-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-cmp-exp-gt-2.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-cmp-exp-gt-2.c	(working copy)
@@ -12,5 +12,5 @@ compare_exponents_gt (double *exponent1_p, double
   double exponent1 = *exponent1_p;
   double exponent2 = *exponent2_p;
 
-  return __builtin_vec_scalar_cmp_exp_gt (exponent1, exponent2); /* { dg-error "Builtin function __builtin_vsx_scalar_cmp_exp_dp_gt requires" } */
+  return __builtin_vec_scalar_cmp_exp_gt (exponent1, exponent2); /* { dg-error "builtin function __builtin_vsx_scalar_cmp_exp_dp_gt requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-cmp-exp-lt-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-cmp-exp-lt-2.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-cmp-exp-lt-2.c	(working copy)
@@ -12,5 +12,5 @@ compare_exponents_lt (double *exponent1_p, double
   double exponent1 = *exponent1_p;
   double exponent2 = *exponent2_p;
 
-  return __builtin_vec_scalar_cmp_exp_lt (exponent1, exponent2);	/* { dg-error "Builtin function __builtin_vsx_scalar_cmp_exp_dp_lt requires" } */
+  return __builtin_vec_scalar_cmp_exp_lt (exponent1, exponent2);	/* { dg-error "builtin function __builtin_vsx_scalar_cmp_exp_dp_lt requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-cmp-exp-unordered-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-cmp-exp-unordered-2.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-cmp-exp-unordered-2.c	(working copy)
@@ -12,5 +12,5 @@ compare_exponents_unordered (double *exponent1_p,
   double exponent1 = *exponent1_p;
   double exponent2 = *exponent2_p;
 
-  return __builtin_vec_scalar_cmp_exp_unordered (exponent1, exponent2);	/* { dg-error "Builtin function __builtin_vsx_scalar_cmp_exp_dp_unordered requires" } */
+  return __builtin_vec_scalar_cmp_exp_unordered (exponent1, exponent2);	/* { dg-error "builtin function __builtin_vsx_scalar_cmp_exp_dp_unordered requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-1.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-1.c	(working copy)
@@ -12,7 +12,7 @@ get_exponent (double *p)
 {
   double source = *p;
 
-  return __builtin_vec_scalar_extract_exp (source); /* { dg-error "Builtin function __builtin_vsx_scalar_extract_exp requires" } */
+  return __builtin_vec_scalar_extract_exp (source); /* { dg-error "builtin function __builtin_vsx_scalar_extract_exp requires" } */
 }
 
 
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-4.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-4.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-4.c	(working copy)
@@ -12,7 +12,7 @@ get_exponent (__ieee128 *p)
 {
   __ieee128 source = *p;
 
-  return __builtin_vec_scalar_extract_exp (source); /* { dg-error "Builtin function __builtin_vsx_scalar_extract_expq requires" } */
+  return __builtin_vec_scalar_extract_exp (source); /* { dg-error "builtin function __builtin_vsx_scalar_extract_expq requires" } */
 }
 
 
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-sig-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-sig-1.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-sig-1.c	(working copy)
@@ -12,5 +12,5 @@ get_significand (double *p)
 {
   double source = *p;
 
-  return __builtin_vec_scalar_extract_sig (source);	/* { dg-error "Builtin function __builtin_vsx_scalar_extract_sig requires" } */
+  return __builtin_vec_scalar_extract_sig (source);	/* { dg-error "builtin function __builtin_vsx_scalar_extract_sig requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-sig-4.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-sig-4.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-sig-4.c	(working copy)
@@ -12,5 +12,5 @@ get_significand (__ieee128 *p)
 {
   __ieee128 source = *p;
 
-  return __builtin_vec_scalar_extract_sig (source);	/* { dg-error "Builtin function __builtin_vsx_scalar_extract_sigq requires" } */
+  return __builtin_vec_scalar_extract_sig (source);	/* { dg-error "builtin function __builtin_vsx_scalar_extract_sigq requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-1.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-1.c	(working copy)
@@ -14,5 +14,5 @@ insert_exponent (unsigned long long int *significa
   unsigned long long int significand = *significand_p;
   unsigned long long int exponent = *exponent_p;
 
-  return __builtin_vec_scalar_insert_exp (significand, exponent); /* { dg-error "Builtin function __builtin_vsx_scalar_insert_exp requires" } */
+  return __builtin_vec_scalar_insert_exp (significand, exponent); /* { dg-error "builtin function __builtin_vsx_scalar_insert_exp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-10.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-10.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-10.c	(working copy)
@@ -14,5 +14,5 @@ insert_exponent (__ieee128 *significand_p,
   __ieee128 significand = *significand_p;
   unsigned long long int exponent = *exponent_p;
 
-  return __builtin_vec_scalar_insert_exp (significand, exponent); /* { dg-error "Builtin function __builtin_vsx_scalar_insert_exp_qp requires" } */
+  return __builtin_vec_scalar_insert_exp (significand, exponent); /* { dg-error "builtin function __builtin_vsx_scalar_insert_exp_qp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-4.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-4.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-4.c	(working copy)
@@ -14,5 +14,5 @@ insert_exponent (double *significand_p,
   double significand = *significand_p;
   unsigned long long int exponent = *exponent_p;
 
-  return __builtin_vec_scalar_insert_exp (significand, exponent); /* { dg-error "Builtin function __builtin_vsx_scalar_insert_exp_dp requires" } */
+  return __builtin_vec_scalar_insert_exp (significand, exponent); /* { dg-error "builtin function __builtin_vsx_scalar_insert_exp_dp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-7.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-7.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-insert-exp-7.c	(working copy)
@@ -14,5 +14,5 @@ insert_exponent (unsigned __int128 *significand_p,
   unsigned __int128 significand = *significand_p;
   unsigned long long int exponent = *exponent_p;
 
-  return __builtin_vec_scalar_insert_exp (significand, exponent); /* { dg-error "Builtin function __builtin_vsx_scalar_insert_exp_q requires" } */
+  return __builtin_vec_scalar_insert_exp (significand, exponent); /* { dg-error "builtin function __builtin_vsx_scalar_insert_exp_q requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-data-class-11.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-data-class-11.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-data-class-11.c	(working copy)
@@ -11,5 +11,5 @@ test_data_class (__ieee128 *p)
 {
   __ieee128 source = *p;
 
-  return __builtin_vec_scalar_test_data_class (source, 3); /* { dg-error "Builtin function __builtin_vsx_scalar_test_data_class_qp requires" } */
+  return __builtin_vec_scalar_test_data_class (source, 3); /* { dg-error "builtin function __builtin_vsx_scalar_test_data_class_qp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-data-class-6.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-data-class-6.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-data-class-6.c	(working copy)
@@ -11,5 +11,5 @@ test_data_class (double *p)
 {
   double source = *p;
 
-  return __builtin_vec_scalar_test_data_class (source, 3); /* { dg-error "Builtin function __builtin_vsx_scalar_test_data_class_dp requires" } */
+  return __builtin_vec_scalar_test_data_class (source, 3); /* { dg-error "builtin function __builtin_vsx_scalar_test_data_class_dp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-data-class-7.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-data-class-7.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-data-class-7.c	(working copy)
@@ -11,5 +11,5 @@ test_data_class (float *p)
 {
   float source = *p;
 
-  return __builtin_vec_scalar_test_data_class (source, 3); /* { dg-error "Builtin function __builtin_vsx_scalar_test_data_class_sp requires" } */
+  return __builtin_vec_scalar_test_data_class (source, 3); /* { dg-error "builtin function __builtin_vsx_scalar_test_data_class_sp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-neg-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-neg-2.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-neg-2.c	(working copy)
@@ -11,5 +11,5 @@ test_neg (float *p)
 {
   float source = *p;
 
-  return __builtin_vec_scalar_test_neg_sp (source); /* { dg-error "Builtin function __builtin_vsx_scalar_test_neg_sp requires" } */
+  return __builtin_vec_scalar_test_neg_sp (source); /* { dg-error "builtin function __builtin_vsx_scalar_test_neg_sp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-neg-3.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-neg-3.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-neg-3.c	(working copy)
@@ -11,5 +11,5 @@ test_neg (double *p)
 {
   double source = *p;
 
-  return __builtin_vec_scalar_test_neg_dp (source); /* { dg-error "Builtin function __builtin_vsx_scalar_test_neg_dp requires" } */
+  return __builtin_vec_scalar_test_neg_dp (source); /* { dg-error "builtin function __builtin_vsx_scalar_test_neg_dp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-neg-5.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-neg-5.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/scalar-test-neg-5.c	(working copy)
@@ -11,5 +11,5 @@ test_neg (__ieee128 *p)
 {
   __ieee128 source = *p;
 
-  return __builtin_vec_scalar_test_neg_qp (source); /* { dg-error "Builtin function __builtin_vsx_scalar_test_neg_qp requires" } */
+  return __builtin_vec_scalar_test_neg_qp (source); /* { dg-error "builtin function __builtin_vsx_scalar_test_neg_qp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/vec-extract-exp-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/vec-extract-exp-2.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/vec-extract-exp-2.c	(working copy)
@@ -10,5 +10,5 @@ get_exponents (__vector double *p)
 {
   __vector double source = *p;
 
-  return __builtin_vec_extract_exp (source); /* { dg-error "Builtin function __builtin_vsx_extract_exp_dp requires" } */
+  return __builtin_vec_extract_exp (source); /* { dg-error "builtin function __builtin_vsx_extract_exp_dp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/vec-extract-exp-3.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/vec-extract-exp-3.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/vec-extract-exp-3.c	(working copy)
@@ -10,5 +10,5 @@ get_exponents (__vector float *p)
 {
   __vector float source = *p;
 
-  return __builtin_vec_extract_exp (source);	/* { dg-error "Builtin function __builtin_vsx_extract_exp_sp requires" } */
+  return __builtin_vec_extract_exp (source);	/* { dg-error "builtin function __builtin_vsx_extract_exp_sp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/vec-extract-sig-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/vec-extract-sig-2.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/vec-extract-sig-2.c	(working copy)
@@ -10,5 +10,5 @@ get_significands (__vector double *p)
 {
   __vector double source = *p;
 
-  return __builtin_vec_extract_sig (source);	/* { dg-error "Builtin function __builtin_vsx_extract_sig_dp requires" } */
+  return __builtin_vec_extract_sig (source);	/* { dg-error "builtin function __builtin_vsx_extract_sig_dp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/vec-extract-sig-3.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/vec-extract-sig-3.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/vec-extract-sig-3.c	(working copy)
@@ -10,5 +10,5 @@ get_significands (__vector float *p)
 {
   __vector float source = *p;
 
-  return __builtin_vec_extract_sig (source);	/* { dg-error "Builtin function __builtin_vsx_extract_sig_sp requires" } */
+  return __builtin_vec_extract_sig (source);	/* { dg-error "builtin function __builtin_vsx_extract_sig_sp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/vec-insert-exp-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/vec-insert-exp-2.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/vec-insert-exp-2.c	(working copy)
@@ -12,5 +12,5 @@ make_floats (__vector unsigned int *significands_p
   __vector unsigned int significands = *significands_p;
   __vector unsigned int exponents = *exponents_p;
 
-  return __builtin_vec_insert_exp (significands, exponents); /* { dg-error "Builtin function __builtin_vsx_insert_exp_sp requires" } */
+  return __builtin_vec_insert_exp (significands, exponents); /* { dg-error "builtin function __builtin_vsx_insert_exp_sp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/vec-insert-exp-3.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/vec-insert-exp-3.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/vec-insert-exp-3.c	(working copy)
@@ -12,5 +12,5 @@ make_doubles (__vector unsigned long long int *sig
   __vector unsigned long long int significands = *significands_p;
   __vector unsigned long long int exponents = *exponents_p;
 
-  return __builtin_vec_insert_exp (significands, exponents); /* { dg-error "Builtin function __builtin_vsx_insert_exp_dp requires" } */
+  return __builtin_vec_insert_exp (significands, exponents); /* { dg-error "builtin function __builtin_vsx_insert_exp_dp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/vec-insert-exp-6.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/vec-insert-exp-6.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/vec-insert-exp-6.c	(working copy)
@@ -12,5 +12,5 @@ make_floats (__vector float *significands_p,
   __vector float significands = *significands_p;
   __vector unsigned int exponents = *exponents_p;
 
-  return __builtin_vec_insert_exp (significands, exponents); /* { dg-error "Builtin function __builtin_vsx_insert_exp_sp requires" } */
+  return __builtin_vec_insert_exp (significands, exponents); /* { dg-error "builtin function __builtin_vsx_insert_exp_sp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/vec-insert-exp-7.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/vec-insert-exp-7.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/vec-insert-exp-7.c	(working copy)
@@ -12,5 +12,5 @@ make_doubles (__vector double *significands_p,
   __vector double significands = *significands_p;
   __vector unsigned long long int exponents = *exponents_p;
 
-  return __builtin_vec_insert_exp (significands, exponents); /* { dg-error "Builtin function __builtin_vsx_insert_exp_dp requires" } */
+  return __builtin_vec_insert_exp (significands, exponents); /* { dg-error "builtin function __builtin_vsx_insert_exp_dp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/vec-test-data-class-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/vec-test-data-class-2.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/vec-test-data-class-2.c	(working copy)
@@ -10,5 +10,5 @@ get_data_class_flags (__vector double *p)
 {
   __vector double source = *p;
 
-  return __builtin_vec_test_data_class (source, 0x37); /* { dg-error "Builtin function __builtin_vsx_test_data_class_dp requires" } */
+  return __builtin_vec_test_data_class (source, 0x37); /* { dg-error "builtin function __builtin_vsx_test_data_class_dp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/bfp/vec-test-data-class-3.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/vec-test-data-class-3.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/bfp/vec-test-data-class-3.c	(working copy)
@@ -10,5 +10,5 @@ get_data_class_flags (__vector float *p)
 {
   __vector float source = *p;
 
-  return __builtin_vec_test_data_class (source, 0x37); /* { dg-error "Builtin function __builtin_vsx_test_data_class_sp requires" } */
+  return __builtin_vec_test_data_class (source, 0x37); /* { dg-error "builtin function __builtin_vsx_test_data_class_sp requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/byte-in-either-range-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/byte-in-either-range-1.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/byte-in-either-range-1.c	(working copy)
@@ -18,5 +18,5 @@ test_byte_in_either_range (unsigned char b,
   range_encoding = ((first_hi_bound << 24) | (first_lo_bound << 16)
 		    | (second_hi_bound << 8) | second_lo_bound);
 
-  return __builtin_byte_in_either_range (b, range_encoding); /* { dg-error "Builtin function __builtin_scalar_byte_in_either_range requires" } */
+  return __builtin_byte_in_either_range (b, range_encoding); /* { dg-error "builtin function __builtin_scalar_byte_in_either_range requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/byte-in-range-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/byte-in-range-1.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/byte-in-range-1.c	(working copy)
@@ -11,6 +11,6 @@ test_byte_in_range (unsigned char b,
 		    unsigned char low_range, unsigned char high_range)
 {
   unsigned int range_encoding = (high_range << 8) | low_range;
-  return __builtin_byte_in_range (b, range_encoding); /* { dg-error "Builtin function __builtin_scalar_byte_in_range requires" } */
+  return __builtin_byte_in_range (b, range_encoding); /* { dg-error "builtin function __builtin_scalar_byte_in_range requires" } */
 }
 
Index: gcc/testsuite/gcc.target/powerpc/byte-in-set-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/byte-in-set-1.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/byte-in-set-1.c	(working copy)
@@ -10,5 +10,5 @@
 int
 test_byte_in_set (unsigned char b, unsigned long long set_members)
 {
-  return __builtin_byte_in_set (b, set_members); /* { dg-error "Builtin function __builtin_scalar_byte_in_set requires" } */
+  return __builtin_byte_in_set (b, set_members); /* { dg-error "builtin function __builtin_scalar_byte_in_set requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/crypto-builtin-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/crypto-builtin-2.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/crypto-builtin-2.c	(working copy)
@@ -6,14 +6,14 @@
 
 void use_builtins_d (__vector unsigned long long *p, __vector unsigned long long *q, __vector unsigned long long *r, __vector unsigned long long *s)
 {
-  p[0] = __builtin_crypto_vcipher (q[0], r[0]); /* { dg-error "Builtin function __builtin_crypto_vcipher is not supported with the current options" } */
-  p[1] = __builtin_crypto_vcipherlast (q[1], r[1]); /* { dg-error "Builtin function __builtin_crypto_vcipherlast is not supported with the current options" } */
-  p[2] = __builtin_crypto_vncipher (q[2], r[2]); /* { dg-error "Builtin function __builtin_crypto_vncipher is not supported with the current options" } */
-  p[3] = __builtin_crypto_vncipherlast (q[3], r[3]); /* { dg-error "Builtin function __builtin_crypto_vncipherlast is not supported with the current options" } */
+  p[0] = __builtin_crypto_vcipher (q[0], r[0]); /* { dg-error "builtin function __builtin_crypto_vcipher is not supported with the current options" } */
+  p[1] = __builtin_crypto_vcipherlast (q[1], r[1]); /* { dg-error "builtin function __builtin_crypto_vcipherlast is not supported with the current options" } */
+  p[2] = __builtin_crypto_vncipher (q[2], r[2]); /* { dg-error "builtin function __builtin_crypto_vncipher is not supported with the current options" } */
+  p[3] = __builtin_crypto_vncipherlast (q[3], r[3]); /* { dg-error "builtin function __builtin_crypto_vncipherlast is not supported with the current options" } */
   p[4] = __builtin_crypto_vpermxor (q[4], r[4], s[4]);
   p[5] = __builtin_crypto_vpmsumd (q[5], r[5]);
-  p[6] = __builtin_crypto_vshasigmad (q[6], 1, 15); /* { dg-error "Builtin function __builtin_crypto_vshasigmad is not supported with the current options" } */
-  p[7] = __builtin_crypto_vsbox (q[7]); /* { dg-error "Builtin function __builtin_crypto_vsbox is not supported with the current options" } */
+  p[6] = __builtin_crypto_vshasigmad (q[6], 1, 15); /* { dg-error "builtin function __builtin_crypto_vshasigmad is not supported with the current options" } */
+  p[7] = __builtin_crypto_vsbox (q[7]); /* { dg-error "builtin function __builtin_crypto_vsbox is not supported with the current options" } */
 }
 
 void use_builtins_w (__vector unsigned int *p, __vector unsigned int *q, __vector unsigned int *r, __vector unsigned int *s)
@@ -20,7 +20,7 @@ void use_builtins_w (__vector unsigned int *p, __v
 {
   p[0] = __builtin_crypto_vpermxor (q[0], r[0], s[0]);
   p[1] = __builtin_crypto_vpmsumw (q[1], r[1]);
-  p[2] = __builtin_crypto_vshasigmaw (q[2], 1, 15); /* { dg-error "Builtin function __builtin_crypto_vshasigmaw is not supported with the current options" } */
+  p[2] = __builtin_crypto_vshasigmaw (q[2], 1, 15); /* { dg-error "builtin function __builtin_crypto_vshasigmaw is not supported with the current options" } */
 }
 
 void use_builtins_h (__vector unsigned short *p, __vector unsigned short *q, __vector unsigned short *r, __vector unsigned short *s)
Index: gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-1.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-1.c	(working copy)
@@ -10,6 +10,6 @@ int doTestBCDSignificance (_Decimal64 *p)
 {
   _Decimal64 source = *p;
 
-  return __builtin_dfp_dtstsfi_lt (5, source);	/* { dg-error "Builtin function __builtin_dtstsfi_lt_dd requires" } */
+  return __builtin_dfp_dtstsfi_lt (5, source);	/* { dg-error "builtin function __builtin_dtstsfi_lt_dd requires" } */
 }
 
Index: gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-11.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-11.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-11.c	(working copy)
@@ -10,6 +10,6 @@ int doTestBCDSignificance (_Decimal64 *p)
 {
   _Decimal64 source = *p;
 
-  return __builtin_dfp_dtstsfi_lt_dd (5, source);	/* { dg-error "Builtin function __builtin_dtstsfi_lt_dd requires" } */
+  return __builtin_dfp_dtstsfi_lt_dd (5, source);	/* { dg-error "builtin function __builtin_dtstsfi_lt_dd requires" } */
 }
 
Index: gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-16.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-16.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-16.c	(working copy)
@@ -10,7 +10,7 @@ int doTestBCDSignificance (_Decimal128 *p)
 {
   _Decimal128 source = *p;
 
-  return __builtin_dfp_dtstsfi_lt_td (5, source);	/* { dg-error "Builtin function __builtin_dtstsfi_lt_td requires" } */
+  return __builtin_dfp_dtstsfi_lt_td (5, source);	/* { dg-error "builtin function __builtin_dtstsfi_lt_td requires" } */
 }
 
 
Index: gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-21.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-21.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-21.c	(working copy)
@@ -10,6 +10,6 @@ int doTestBCDSignificance (_Decimal64 *p)
 {
   _Decimal64 source = *p;
 
-  return __builtin_dfp_dtstsfi_gt (5, source);	/* { dg-error "Builtin function __builtin_dtstsfi_gt_dd requires" } */
+  return __builtin_dfp_dtstsfi_gt (5, source);	/* { dg-error "builtin function __builtin_dtstsfi_gt_dd requires" } */
 }
 
Index: gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-26.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-26.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-26.c	(working copy)
@@ -10,7 +10,7 @@ int doTestBCDSignificance (_Decimal128 *p)
 {
   _Decimal128 source = *p;
 
-  return __builtin_dfp_dtstsfi_gt (5, source);	/* { dg-error "Builtin function __builtin_dtstsfi_gt_td requires" } */
+  return __builtin_dfp_dtstsfi_gt (5, source);	/* { dg-error "builtin function __builtin_dtstsfi_gt_td requires" } */
 }
 
 
Index: gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-31.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-31.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-31.c	(working copy)
@@ -10,6 +10,6 @@ int doTestBCDSignificance (_Decimal64 *p)
 {
   _Decimal64 source = *p;
 
-  return __builtin_dfp_dtstsfi_gt_dd (5, source);	/* { dg-error "Builtin function __builtin_dtstsfi_gt_dd requires" } */
+  return __builtin_dfp_dtstsfi_gt_dd (5, source);	/* { dg-error "builtin function __builtin_dtstsfi_gt_dd requires" } */
 }
 
Index: gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-36.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-36.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-36.c	(working copy)
@@ -10,7 +10,7 @@ int doTestBCDSignificance (_Decimal128 *p)
 {
   _Decimal128 source = *p;
 
-  return __builtin_dfp_dtstsfi_gt_td (5, source);	/* { dg-error "Builtin function __builtin_dtstsfi_gt_td requires" } */
+  return __builtin_dfp_dtstsfi_gt_td (5, source);	/* { dg-error "builtin function __builtin_dtstsfi_gt_td requires" } */
 }
 
 
Index: gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-41.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-41.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-41.c	(working copy)
@@ -10,6 +10,6 @@ int doTestBCDSignificance (_Decimal64 *p)
 {
   _Decimal64 source = *p;
 
-  return __builtin_dfp_dtstsfi_eq (5, source);	/* { dg-error "Builtin function __builtin_dtstsfi_eq_dd requires" } */
+  return __builtin_dfp_dtstsfi_eq (5, source);	/* { dg-error "builtin function __builtin_dtstsfi_eq_dd requires" } */
 }
 
Index: gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-46.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-46.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-46.c	(working copy)
@@ -10,7 +10,7 @@ int doTestBCDSignificance (_Decimal128 *p)
 {
   _Decimal128 source = *p;
 
-  return __builtin_dfp_dtstsfi_eq (5, source);	/* { dg-error "Builtin function __builtin_dtstsfi_eq_td requires" } */
+  return __builtin_dfp_dtstsfi_eq (5, source);	/* { dg-error "builtin function __builtin_dtstsfi_eq_td requires" } */
 }
 
 
Index: gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-51.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-51.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-51.c	(working copy)
@@ -10,6 +10,6 @@ int doTestBCDSignificance (_Decimal64 *p)
 {
   _Decimal64 source = *p;
 
-  return __builtin_dfp_dtstsfi_eq_dd (5, source);	/* { dg-error "Builtin function __builtin_dtstsfi_eq_dd requires" } */
+  return __builtin_dfp_dtstsfi_eq_dd (5, source);	/* { dg-error "builtin function __builtin_dtstsfi_eq_dd requires" } */
 }
 
Index: gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-56.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-56.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-56.c	(working copy)
@@ -10,7 +10,7 @@ int doTestBCDSignificance (_Decimal128 *p)
 {
   _Decimal128 source = *p;
 
-  return __builtin_dfp_dtstsfi_eq_td (5, source);	/* { dg-error "Builtin function __builtin_dtstsfi_eq_td requires" } */
+  return __builtin_dfp_dtstsfi_eq_td (5, source);	/* { dg-error "builtin function __builtin_dtstsfi_eq_td requires" } */
 }
 
 
Index: gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-6.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-6.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-6.c	(working copy)
@@ -10,7 +10,7 @@ int doTestBCDSignificance (_Decimal128 *p)
 {
   _Decimal128 source = *p;
 
-  return __builtin_dfp_dtstsfi_lt (5, source);	/* { dg-error "Builtin function __builtin_dtstsfi_lt_td requires" } */
+  return __builtin_dfp_dtstsfi_lt (5, source);	/* { dg-error "builtin function __builtin_dtstsfi_lt_td requires" } */
 }
 
 
Index: gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-61.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-61.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-61.c	(working copy)
@@ -10,6 +10,6 @@ int doTestBCDSignificance (_Decimal64 *p)
 {
   _Decimal64 source = *p;
 
-  return __builtin_dfp_dtstsfi_ov (5, source);	/* { dg-error "Builtin function __builtin_dtstsfi_ov_dd requires" } */
+  return __builtin_dfp_dtstsfi_ov (5, source);	/* { dg-error "builtin function __builtin_dtstsfi_ov_dd requires" } */
 }
 
Index: gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-66.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-66.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-66.c	(working copy)
@@ -10,7 +10,7 @@ int doTestBCDSignificance (_Decimal128 *p)
 {
   _Decimal128 source = *p;
 
-  return __builtin_dfp_dtstsfi_ov (5, source);	/* { dg-error "Builtin function __builtin_dtstsfi_ov_td requires" } */
+  return __builtin_dfp_dtstsfi_ov (5, source);	/* { dg-error "builtin function __builtin_dtstsfi_ov_td requires" } */
 }
 
 
Index: gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-71.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-71.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-71.c	(working copy)
@@ -10,6 +10,6 @@ int doTestBCDSignificance (_Decimal64 *p)
 {
   _Decimal64 source = *p;
 
-  return __builtin_dfp_dtstsfi_ov_dd (5, source);	/* { dg-error "Builtin function __builtin_dtstsfi_ov_dd requires" } */
+  return __builtin_dfp_dtstsfi_ov_dd (5, source);	/* { dg-error "builtin function __builtin_dtstsfi_ov_dd requires" } */
 }
 
Index: gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-76.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-76.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dtstsfi-76.c	(working copy)
@@ -10,7 +10,7 @@ int doTestBCDSignificance (_Decimal128 *p)
 {
   _Decimal128 source = *p;
 
-  return __builtin_dfp_dtstsfi_ov_td (5, source);	/* { dg-error "Builtin function __builtin_dtstsfi_ov_td requires" } */
+  return __builtin_dfp_dtstsfi_ov_td (5, source);	/* { dg-error "builtin function __builtin_dtstsfi_ov_td requires" } */
 }
 
 
Index: gcc/testsuite/gcc.target/powerpc/vsu/vec-all-nez-7.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vsu/vec-all-nez-7.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/vsu/vec-all-nez-7.c	(working copy)
@@ -12,5 +12,5 @@ test_all_not_equal_and_not_zero (vector unsigned s
   vector unsigned short arg_1 = *arg1_p;
   vector unsigned short arg_2 = *arg2_p;
 
-  return __builtin_vec_vcmpnez_p (__CR6_LT, arg_1, arg_2);	/* { dg-error "Builtin function __builtin_vec_vcmpnez_p not supported in this compiler configuration" } */
+  return __builtin_vec_vcmpnez_p (__CR6_LT, arg_1, arg_2);	/* { dg-error "builtin function __builtin_vec_vcmpnez_p not supported in this compiler configuration" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/vsu/vec-any-eqz-7.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vsu/vec-any-eqz-7.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/vsu/vec-any-eqz-7.c	(working copy)
@@ -11,5 +11,5 @@ test_any_equal (vector unsigned int *arg1_p, vecto
   vector unsigned int arg_1 = *arg1_p;
   vector unsigned int arg_2 = *arg2_p;
 
-  return __builtin_vec_vcmpnez_p (__CR6_LT_REV, arg_1, arg_2);	/* { dg-error "Builtin function __builtin_vec_vcmpnez_p not supported in this compiler configuration" } */
+  return __builtin_vec_vcmpnez_p (__CR6_LT_REV, arg_1, arg_2);	/* { dg-error "builtin function __builtin_vec_vcmpnez_p not supported in this compiler configuration" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/vsu/vec-cmpnez-7.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vsu/vec-cmpnez-7.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/vsu/vec-cmpnez-7.c	(working copy)
@@ -11,5 +11,5 @@ fetch_data (vector unsigned int *arg1_p, vector un
   vector unsigned int arg_1 = *arg1_p;
   vector unsigned int arg_2 = *arg2_p;
 
-  return __builtin_vec_vcmpnez (arg_1, arg_2);	/* { dg-error "Builtin function __builtin_altivec_vcmpnezw requires the -mcpu=power9 option" } */
+  return __builtin_vec_vcmpnez (arg_1, arg_2);	/* { dg-error "builtin function __builtin_altivec_vcmpnezw requires the -mcpu=power9 option" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/vsu/vec-cntlz-lsbb-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vsu/vec-cntlz-lsbb-2.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/vsu/vec-cntlz-lsbb-2.c	(working copy)
@@ -10,5 +10,5 @@ count_leading_zero_byte_bits (vector unsigned char
 {
   vector unsigned char arg_1 = *arg1_p;
 
-  return __builtin_vec_vclzlsbb (arg_1);	/* { dg-error "Builtin function __builtin_altivec_vclzlsbb requires the -mcpu=power9 option" } */
+  return __builtin_vec_vclzlsbb (arg_1);	/* { dg-error "builtin function __builtin_altivec_vclzlsbb requires the -mcpu=power9 option" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/vsu/vec-cnttz-lsbb-2.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vsu/vec-cnttz-lsbb-2.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/vsu/vec-cnttz-lsbb-2.c	(working copy)
@@ -10,5 +10,5 @@ count_trailing_zero_byte_bits (vector unsigned cha
 {
   vector unsigned char arg_1 = *arg1_p;
 
-  return __builtin_vec_vctzlsbb (arg_1);	/* { dg-error "Builtin function __builtin_altivec_vctzlsbb requires the -mcpu=power9 option" } */
+  return __builtin_vec_vctzlsbb (arg_1);	/* { dg-error "builtin function __builtin_altivec_vctzlsbb requires the -mcpu=power9 option" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/vsu/vec-xl-len-12.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vsu/vec-xl-len-12.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/vsu/vec-xl-len-12.c	(working copy)
@@ -12,5 +12,5 @@
 __vector float
 fetch_data (float *address, size_t length)
 {
-  return __builtin_vec_lxvl (address, length); /* { dg-error "Builtin function __builtin_vsx_lxvl requires" } */
+  return __builtin_vec_lxvl (address, length); /* { dg-error "builtin function __builtin_vsx_lxvl requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/vsu/vec-xlx-7.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vsu/vec-xlx-7.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/vsu/vec-xlx-7.c	(working copy)
@@ -11,5 +11,5 @@ fetch_data (unsigned int offset, vector signed int
 {
   vector signed int data = *datap;
 
-  return __builtin_vec_vextulx (offset, data);	/* { dg-error "Builtin function __builtin_altivec_vextuwlx requires" } */
+  return __builtin_vec_vextulx (offset, data);	/* { dg-error "builtin function __builtin_altivec_vextuwlx requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/vsu/vec-xrx-7.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vsu/vec-xrx-7.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/vsu/vec-xrx-7.c	(working copy)
@@ -11,5 +11,5 @@ fetch_data (unsigned short offset, vector signed s
 {
   vector signed short data = *datap;
 
-  return __builtin_vec_vexturx (offset, data);	/* { dg-error "Builtin function __builtin_altivec_vextuhrx requires" } */
+  return __builtin_vec_vexturx (offset, data);	/* { dg-error "builtin function __builtin_altivec_vextuhrx requires" } */
 }
Index: gcc/testsuite/gcc.target/powerpc/vsu/vec-xst-len-12.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vsu/vec-xst-len-12.c	(revision 250791)
+++ gcc/testsuite/gcc.target/powerpc/vsu/vec-xst-len-12.c	(working copy)
@@ -14,5 +14,5 @@ store_data (vector double *datap, double *address,
 {
   vector double data = *datap;
 
-  __builtin_vec_stxvl (data, address, length); /* { dg-error "Builtin function __builtin_vec_stxvl not supported in this compiler configuration" } */
+  __builtin_vec_stxvl (data, address, length); /* { dg-error "builtin function __builtin_vec_stxvl not supported in this compiler configuration" } */
 }

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH, rs6000] Clean up capitalized diagnostic messages
  2017-08-02 15:29 [PATCH, rs6000] Clean up capitalized diagnostic messages Bill Schmidt
@ 2017-08-02 15:55 ` Jakub Jelinek
  2017-08-02 16:04   ` Joseph Myers
  2017-08-02 16:49 ` Martin Sebor
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 10+ messages in thread
From: Jakub Jelinek @ 2017-08-02 15:55 UTC (permalink / raw)
  To: Bill Schmidt, Joseph S. Myers
  Cc: GCC Patches, Segher Boessenkool, David Edelsohn

On Wed, Aug 02, 2017 at 10:29:20AM -0500, Bill Schmidt wrote:
> --- gcc/config/rs6000/rs6000.c	(revision 250791)
> +++ gcc/config/rs6000/rs6000.c	(working copy)
> @@ -4132,7 +4132,7 @@ rs6000_option_override_internal (bool global_init_
>        || rs6000_cpu == PROCESSOR_PPCE5500)
>      {
>        if (TARGET_ALTIVEC)
> -	error ("AltiVec not supported in this target");
> +	error ("altivec not supported in this target");

If AltiVec is spelled that way always, then I think we want to keep it
capitalized, but CCing Joseph just to be sure.  Or the diagnostics
could be reworded not to have AltiVec first.

> @@ -4250,7 +4250,7 @@ rs6000_option_override_internal (bool global_init_
>  	      rs6000_isa_flags |= (ISA_3_0_MASKS_SERVER & ~ignore_masks);
>  	    }
>  	  else
> -	    error ("Power9 target option is incompatible with -mcpu=<xxx> for "
> +	    error ("power9 target option is incompatible with -mcpu=<xxx> for "
>  		   "<xxx> less than power9");
>  	}
>        else if ((ISA_3_0_MASKS_SERVER & rs6000_isa_flags_explicit)

Similarly, not sure about this one, but isn't it about -mpower9-minmax
being incompatible with -mcpu option not supporting power9 ISA?
The <xxx> and talking about less for strings that aren't necessarily ordered
is just weird.

> @@ -11226,7 +11226,7 @@ rs6000_return_in_memory (const_tree type, const_tr
>        static bool warned_for_return_big_vectors = false;
>        if (!warned_for_return_big_vectors)
>  	{
> -	  warning (OPT_Wpsabi, "GCC vector returned by reference: "
> +	  warning (OPT_Wpsabi, "gcc vector returned by reference: "
>  		   "non-standard ABI extension with no compatibility guarantee");
>  	  warned_for_return_big_vectors = true;
>  	}
> @@ -12773,7 +12773,7 @@ rs6000_pass_by_reference (cumulative_args_t cum AT
>  	fprintf (stderr, "function_arg_pass_by_reference: synthetic vector\n");
>        if (!warned_for_pass_big_vectors)
>  	{
> -	  warning (OPT_Wpsabi, "GCC vector passed by reference: "
> +	  warning (OPT_Wpsabi, "gcc vector passed by reference: "
>  		   "non-standard ABI extension with no compatibility guarantee");
>  	  warned_for_pass_big_vectors = true;
>  	}

GCC I think needs to be capitalized.  Not sure if talking about GCC vector
is clear, it is talking about the GNU vector extension, perhaps GNU instead?

The rest of the changes look good to me, but I'll defer review to the target
maintainers.

	Jakub

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH, rs6000] Clean up capitalized diagnostic messages
  2017-08-02 15:55 ` Jakub Jelinek
@ 2017-08-02 16:04   ` Joseph Myers
  2017-08-02 18:50     ` Bill Schmidt
  0 siblings, 1 reply; 10+ messages in thread
From: Joseph Myers @ 2017-08-02 16:04 UTC (permalink / raw)
  To: Jakub Jelinek
  Cc: Bill Schmidt, GCC Patches, Segher Boessenkool, David Edelsohn

On Wed, 2 Aug 2017, Jakub Jelinek wrote:

> On Wed, Aug 02, 2017 at 10:29:20AM -0500, Bill Schmidt wrote:
> > --- gcc/config/rs6000/rs6000.c	(revision 250791)
> > +++ gcc/config/rs6000/rs6000.c	(working copy)
> > @@ -4132,7 +4132,7 @@ rs6000_option_override_internal (bool global_init_
> >        || rs6000_cpu == PROCESSOR_PPCE5500)
> >      {
> >        if (TARGET_ALTIVEC)
> > -	error ("AltiVec not supported in this target");
> > +	error ("altivec not supported in this target");
> 
> If AltiVec is spelled that way always, then I think we want to keep it
> capitalized, but CCing Joseph just to be sure.  Or the diagnostics

Yes, if it would be capitalized mid-sentence then it should be capitalized 
at the start of a diagnostic (and if it wouldn't be capitalized 
mid-sentence, it shouldn't be capitalized at the start of a diagnostic).

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH, rs6000] Clean up capitalized diagnostic messages
  2017-08-02 15:29 [PATCH, rs6000] Clean up capitalized diagnostic messages Bill Schmidt
  2017-08-02 15:55 ` Jakub Jelinek
@ 2017-08-02 16:49 ` Martin Sebor
  2017-08-02 23:44 ` Segher Boessenkool
  2017-08-06  8:08 ` Andreas Schwab
  3 siblings, 0 replies; 10+ messages in thread
From: Martin Sebor @ 2017-08-02 16:49 UTC (permalink / raw)
  To: Bill Schmidt, GCC Patches; +Cc: Segher Boessenkool, jakub, David Edelsohn

On 08/02/2017 09:29 AM, Bill Schmidt wrote:
> Hi,
>
> Jakub pointed out that we've had several error messages slip into the POWER back end
> that incorrectly start with a capital letter.  This patch hunts those down and cleans
> them up.

Others have already commented on some aspects of the patch but
let me suggest that using the option that controls it instead
of changing the spelling of AltiVec would bypass the whole
capitalization issue and might also provide an additional detail
that may otherwise not be immediately obvious.

Also, while making changes to the diagnostics, it would be great
to also add quoting around the built-in names and option names as
in:

> --- gcc/config/rs6000/rs6000-c.c	(revision 250791)
> +++ gcc/config/rs6000/rs6000-c.c	(working copy)
> @@ -6802,7 +6802,7 @@ altivec_resolve_overloaded_builtin (location_t loc
>      if (unsupported_builtin)
>        {
>  	const char *name = rs6000_overloaded_builtin_name (fcode);
> -	error ("Builtin function %s not supported in this compiler configuration",
> +	error ("builtin function %s not supported in this compiler configuration",

use %qs instead:

   error ("builtin function %qs not supported in this compiler 
configuration", ...);

and similarly here:

> +	    error ("power9 target option is incompatible with -mcpu=<xxx> for "
>  		   "<xxx> less than power9");

Here too, I suggest to consider using and quoting an option that
enables the to power9 target rather than using power9 as a plain
word.

Martin

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH, rs6000] Clean up capitalized diagnostic messages
  2017-08-02 16:04   ` Joseph Myers
@ 2017-08-02 18:50     ` Bill Schmidt
  0 siblings, 0 replies; 10+ messages in thread
From: Bill Schmidt @ 2017-08-02 18:50 UTC (permalink / raw)
  To: Joseph Myers
  Cc: Jakub Jelinek, GCC Patches, Segher Boessenkool, David Edelsohn

On Aug 2, 2017, at 11:04 AM, Joseph Myers <joseph@codesourcery.com> wrote:
> 
> On Wed, 2 Aug 2017, Jakub Jelinek wrote:
> 
>> On Wed, Aug 02, 2017 at 10:29:20AM -0500, Bill Schmidt wrote:
>>> --- gcc/config/rs6000/rs6000.c	(revision 250791)
>>> +++ gcc/config/rs6000/rs6000.c	(working copy)
>>> @@ -4132,7 +4132,7 @@ rs6000_option_override_internal (bool global_init_
>>>       || rs6000_cpu == PROCESSOR_PPCE5500)
>>>     {
>>>       if (TARGET_ALTIVEC)
>>> -	error ("AltiVec not supported in this target");
>>> +	error ("altivec not supported in this target");
>> 
>> If AltiVec is spelled that way always, then I think we want to keep it
>> capitalized, but CCing Joseph just to be sure.  Or the diagnostics
> 
> Yes, if it would be capitalized mid-sentence then it should be capitalized 
> at the start of a diagnostic (and if it wouldn't be capitalized 
> mid-sentence, it shouldn't be capitalized at the start of a diagnostic).

Honestly, if I had my way we would retroactively change all the
"altivec/Altivec/AltiVec" inconsistencies to "VMX". ;-)  But given the
ubiquity of <altivec.h> (lowercase there) I suppose that's not practical...

I'll return this one to AltiVec, and change "GCC vector" to "GNU vector"
if that's okay with everyone.

Bill

> 
> -- 
> Joseph S. Myers
> joseph@codesourcery.com
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH, rs6000] Clean up capitalized diagnostic messages
  2017-08-02 15:29 [PATCH, rs6000] Clean up capitalized diagnostic messages Bill Schmidt
  2017-08-02 15:55 ` Jakub Jelinek
  2017-08-02 16:49 ` Martin Sebor
@ 2017-08-02 23:44 ` Segher Boessenkool
  2017-08-03 18:28   ` Bill Schmidt
  2017-08-06  8:08 ` Andreas Schwab
  3 siblings, 1 reply; 10+ messages in thread
From: Segher Boessenkool @ 2017-08-02 23:44 UTC (permalink / raw)
  To: Bill Schmidt; +Cc: GCC Patches, jakub, David Edelsohn

Hi Bill,

On Wed, Aug 02, 2017 at 10:29:20AM -0500, Bill Schmidt wrote:
> I don't anticipate backporting any of this.

Good :-)

> @@ -6802,7 +6802,7 @@ altivec_resolve_overloaded_builtin (location_t loc
>      if (unsupported_builtin)
>        {
>  	const char *name = rs6000_overloaded_builtin_name (fcode);
> -	error ("Builtin function %s not supported in this compiler configuration",
> +	error ("builtin function %s not supported in this compiler configuration",
>  	       name);

As Martin says, %qs for this and similar (see the documentation before
pp_format in pretty-print.c).  Can be a separate patch of course, this
one is big enough already.

> Index: gcc/config/rs6000/rs6000.c
> ===================================================================
> --- gcc/config/rs6000/rs6000.c	(revision 250791)
> +++ gcc/config/rs6000/rs6000.c	(working copy)
> @@ -4132,7 +4132,7 @@ rs6000_option_override_internal (bool global_init_
>        || rs6000_cpu == PROCESSOR_PPCE5500)
>      {
>        if (TARGET_ALTIVEC)
> -	error ("AltiVec not supported in this target");
> +	error ("altivec not supported in this target");
>      }
>  
>    /* If we are optimizing big endian systems for space, use the load/store

Let's either keep AltiVec or say -maltivec.  We only have this warning
because we allow -maltivec with CPUs that do not support it; and this
warning is only for some of the FSL CPUs.  It isn't very consistent.

> @@ -4250,7 +4250,7 @@ rs6000_option_override_internal (bool global_init_
>  	      rs6000_isa_flags |= (ISA_3_0_MASKS_SERVER & ~ignore_masks);
>  	    }
>  	  else
> -	    error ("Power9 target option is incompatible with -mcpu=<xxx> for "
> +	    error ("power9 target option is incompatible with -mcpu=<xxx> for "
>  		   "<xxx> less than power9");
>  	}
>        else if ((ISA_3_0_MASKS_SERVER & rs6000_isa_flags_explicit)

See also PR79477.  Since many of these options are going away it is
probably not worth spending too much time on this, not until stage 3
or so anyway.

> @@ -11226,7 +11226,7 @@ rs6000_return_in_memory (const_tree type, const_tr
>        static bool warned_for_return_big_vectors = false;
>        if (!warned_for_return_big_vectors)
>  	{
> -	  warning (OPT_Wpsabi, "GCC vector returned by reference: "
> +	  warning (OPT_Wpsabi, "gcc vector returned by reference: "
>  		   "non-standard ABI extension with no compatibility guarantee");
>  	  warned_for_return_big_vectors = true;
>  	}

Maybe the warning should just say "big vector"?  Or "generic vector"?

(Vectors that fit in one VR, or in GPRs in 8 bytes or less, do not have
the problem this warns for.  Kind of hard to express tersely and
precisely though).

Approved for trunk with whichever of the suggested changes you think
are good.  Thanks,


Segher

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH, rs6000] Clean up capitalized diagnostic messages
  2017-08-02 23:44 ` Segher Boessenkool
@ 2017-08-03 18:28   ` Bill Schmidt
  0 siblings, 0 replies; 10+ messages in thread
From: Bill Schmidt @ 2017-08-03 18:28 UTC (permalink / raw)
  To: Segher Boessenkool; +Cc: GCC Patches, jakub, David Edelsohn


> On Aug 2, 2017, at 6:43 PM, Segher Boessenkool <segher@kernel.crashing.org> wrote:
> 
> Hi Bill,
> 
> On Wed, Aug 02, 2017 at 10:29:20AM -0500, Bill Schmidt wrote:
>> I don't anticipate backporting any of this.
> 
> Good :-)
> 
>> @@ -6802,7 +6802,7 @@ altivec_resolve_overloaded_builtin (location_t loc
>>     if (unsupported_builtin)
>>       {
>> 	const char *name = rs6000_overloaded_builtin_name (fcode);
>> -	error ("Builtin function %s not supported in this compiler configuration",
>> +	error ("builtin function %s not supported in this compiler configuration",
>> 	       name);
> 
> As Martin says, %qs for this and similar (see the documentation before
> pp_format in pretty-print.c).  Can be a separate patch of course, this
> one is big enough already.
> 
>> Index: gcc/config/rs6000/rs6000.c
>> ===================================================================
>> --- gcc/config/rs6000/rs6000.c	(revision 250791)
>> +++ gcc/config/rs6000/rs6000.c	(working copy)
>> @@ -4132,7 +4132,7 @@ rs6000_option_override_internal (bool global_init_
>>       || rs6000_cpu == PROCESSOR_PPCE5500)
>>     {
>>       if (TARGET_ALTIVEC)
>> -	error ("AltiVec not supported in this target");
>> +	error ("altivec not supported in this target");
>>     }
>> 
>>   /* If we are optimizing big endian systems for space, use the load/store
> 
> Let's either keep AltiVec or say -maltivec.  We only have this warning
> because we allow -maltivec with CPUs that do not support it; and this
> warning is only for some of the FSL CPUs.  It isn't very consistent.

Back to AltiVec it goes!  Thanks.

> 
>> @@ -4250,7 +4250,7 @@ rs6000_option_override_internal (bool global_init_
>> 	      rs6000_isa_flags |= (ISA_3_0_MASKS_SERVER & ~ignore_masks);
>> 	    }
>> 	  else
>> -	    error ("Power9 target option is incompatible with -mcpu=<xxx> for "
>> +	    error ("power9 target option is incompatible with -mcpu=<xxx> for "
>> 		   "<xxx> less than power9");
>> 	}
>>       else if ((ISA_3_0_MASKS_SERVER & rs6000_isa_flags_explicit)
> 
> See also PR79477.  Since many of these options are going away it is
> probably not worth spending too much time on this, not until stage 3
> or so anyway.

Yeah, let's address that later in the year after Mike finishes his cleanups.

> 
>> @@ -11226,7 +11226,7 @@ rs6000_return_in_memory (const_tree type, const_tr
>>       static bool warned_for_return_big_vectors = false;
>>       if (!warned_for_return_big_vectors)
>> 	{
>> -	  warning (OPT_Wpsabi, "GCC vector returned by reference: "
>> +	  warning (OPT_Wpsabi, "gcc vector returned by reference: "
>> 		   "non-standard ABI extension with no compatibility guarantee");
>> 	  warned_for_return_big_vectors = true;
>> 	}
> 
> Maybe the warning should just say "big vector"?  Or "generic vector"?
> 
> (Vectors that fit in one VR, or in GPRs in 8 bytes or less, do not have
> the problem this warns for.  Kind of hard to express tersely and
> precisely though).

I looked in the GCC manual and couldn't find a better way of expressing
this than just "GCC vector," so I will return it to the way it was.  "GCC 
vector extension vector" is accurate but hardly trips lightly off the
tongue...

> 
> Approved for trunk with whichever of the suggested changes you think
> are good.  Thanks,

Thanks much!

Bill

> 
> 
> Segher
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH, rs6000] Clean up capitalized diagnostic messages
  2017-08-02 15:29 [PATCH, rs6000] Clean up capitalized diagnostic messages Bill Schmidt
                   ` (2 preceding siblings ...)
  2017-08-02 23:44 ` Segher Boessenkool
@ 2017-08-06  8:08 ` Andreas Schwab
  2017-08-07 10:51   ` Segher Boessenkool
  2017-08-08 12:46   ` Bill Schmidt
  3 siblings, 2 replies; 10+ messages in thread
From: Andreas Schwab @ 2017-08-06  8:08 UTC (permalink / raw)
  To: Bill Schmidt; +Cc: GCC Patches, Segher Boessenkool, jakub, David Edelsohn

FAIL: gcc.target/powerpc/bfp/scalar-extract-exp-2.c  (test for errors, line 18)
FAIL: gcc.target/powerpc/bfp/scalar-extract-exp-2.c (test for excess errors)
FAIL: gcc.target/powerpc/bfp/scalar-extract-exp-5.c  (test for errors, line 18)
FAIL: gcc.target/powerpc/bfp/scalar-extract-exp-5.c (test for excess errors)
FAIL: gcc.target/powerpc/bfp/scalar-extract-sig-2.c  (test for errors, line 16)
FAIL: gcc.target/powerpc/bfp/scalar-extract-sig-2.c (test for excess errors)
FAIL: gcc.target/powerpc/bfp/scalar-extract-sig-5.c  (test for errors, line 16)
FAIL: gcc.target/powerpc/bfp/scalar-extract-sig-5.c (test for excess errors)
FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-11.c  (test for errors, line 20)
FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-11.c (test for excess errors)
FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-2.c  (test for errors, line 20)
FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-2.c (test for excess errors)
FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-5.c  (test for errors, line 20)
FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-5.c (test for excess errors)
FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-8.c  (test for errors, line 20)
FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-8.c (test for excess errors)
FAIL: gcc.target/powerpc/cmpb-3.c  (test for errors, line 12)
FAIL: gcc.target/powerpc/cmpb-3.c (test for excess errors)
FAIL: gcc.target/powerpc/byte-in-set-2.c  (test for errors, line 15)
FAIL: gcc.target/powerpc/byte-in-set-2.c (test for excess errors)
FAIL: gcc.target/powerpc/vsu/vec-xl-len-13.c  (test for errors, line 17)
FAIL: gcc.target/powerpc/vsu/vec-xl-len-13.c (test for excess errors)
FAIL: gcc.target/powerpc/vsu/vec-xst-len-13.c  (test for errors, line 18)
FAIL: gcc.target/powerpc/vsu/vec-xst-len-13.c (test for excess errors)

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH, rs6000] Clean up capitalized diagnostic messages
  2017-08-06  8:08 ` Andreas Schwab
@ 2017-08-07 10:51   ` Segher Boessenkool
  2017-08-08 12:46   ` Bill Schmidt
  1 sibling, 0 replies; 10+ messages in thread
From: Segher Boessenkool @ 2017-08-07 10:51 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: Bill Schmidt, GCC Patches, jakub, David Edelsohn

Hi Andreas,

On Sun, Aug 06, 2017 at 10:08:23AM +0200, Andreas Schwab wrote:
> FAIL: gcc.target/powerpc/bfp/scalar-extract-exp-2.c  (test for errors, line 18)
> FAIL: gcc.target/powerpc/bfp/scalar-extract-exp-2.c (test for excess errors)
> FAIL: gcc.target/powerpc/bfp/scalar-extract-exp-5.c  (test for errors, line 18)
> FAIL: gcc.target/powerpc/bfp/scalar-extract-exp-5.c (test for excess errors)
> FAIL: gcc.target/powerpc/bfp/scalar-extract-sig-2.c  (test for errors, line 16)
> FAIL: gcc.target/powerpc/bfp/scalar-extract-sig-2.c (test for excess errors)
> FAIL: gcc.target/powerpc/bfp/scalar-extract-sig-5.c  (test for errors, line 16)
> FAIL: gcc.target/powerpc/bfp/scalar-extract-sig-5.c (test for excess errors)
> FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-11.c  (test for errors, line 20)
> FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-11.c (test for excess errors)
> FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-2.c  (test for errors, line 20)
> FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-2.c (test for excess errors)
> FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-5.c  (test for errors, line 20)
> FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-5.c (test for excess errors)
> FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-8.c  (test for errors, line 20)
> FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-8.c (test for excess errors)
> FAIL: gcc.target/powerpc/cmpb-3.c  (test for errors, line 12)
> FAIL: gcc.target/powerpc/cmpb-3.c (test for excess errors)
> FAIL: gcc.target/powerpc/byte-in-set-2.c  (test for errors, line 15)
> FAIL: gcc.target/powerpc/byte-in-set-2.c (test for excess errors)
> FAIL: gcc.target/powerpc/vsu/vec-xl-len-13.c  (test for errors, line 17)
> FAIL: gcc.target/powerpc/vsu/vec-xl-len-13.c (test for excess errors)
> FAIL: gcc.target/powerpc/vsu/vec-xst-len-13.c  (test for errors, line 18)
> FAIL: gcc.target/powerpc/vsu/vec-xst-len-13.c (test for excess errors)

What target?  What configure options?  What runtest options?  What
binutils version?  What is the actual CPU?

Or, do you have a link to a gcc-testresults post with that info?


Segher

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH, rs6000] Clean up capitalized diagnostic messages
  2017-08-06  8:08 ` Andreas Schwab
  2017-08-07 10:51   ` Segher Boessenkool
@ 2017-08-08 12:46   ` Bill Schmidt
  1 sibling, 0 replies; 10+ messages in thread
From: Bill Schmidt @ 2017-08-08 12:46 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: GCC Patches, Segher Boessenkool, jakub, David Edelsohn

Fixed with r250952.

Bill

> On Aug 6, 2017, at 3:08 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> 
> FAIL: gcc.target/powerpc/bfp/scalar-extract-exp-2.c  (test for errors, line 18)
> FAIL: gcc.target/powerpc/bfp/scalar-extract-exp-2.c (test for excess errors)
> FAIL: gcc.target/powerpc/bfp/scalar-extract-exp-5.c  (test for errors, line 18)
> FAIL: gcc.target/powerpc/bfp/scalar-extract-exp-5.c (test for excess errors)
> FAIL: gcc.target/powerpc/bfp/scalar-extract-sig-2.c  (test for errors, line 16)
> FAIL: gcc.target/powerpc/bfp/scalar-extract-sig-2.c (test for excess errors)
> FAIL: gcc.target/powerpc/bfp/scalar-extract-sig-5.c  (test for errors, line 16)
> FAIL: gcc.target/powerpc/bfp/scalar-extract-sig-5.c (test for excess errors)
> FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-11.c  (test for errors, line 20)
> FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-11.c (test for excess errors)
> FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-2.c  (test for errors, line 20)
> FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-2.c (test for excess errors)
> FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-5.c  (test for errors, line 20)
> FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-5.c (test for excess errors)
> FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-8.c  (test for errors, line 20)
> FAIL: gcc.target/powerpc/bfp/scalar-insert-exp-8.c (test for excess errors)
> FAIL: gcc.target/powerpc/cmpb-3.c  (test for errors, line 12)
> FAIL: gcc.target/powerpc/cmpb-3.c (test for excess errors)
> FAIL: gcc.target/powerpc/byte-in-set-2.c  (test for errors, line 15)
> FAIL: gcc.target/powerpc/byte-in-set-2.c (test for excess errors)
> FAIL: gcc.target/powerpc/vsu/vec-xl-len-13.c  (test for errors, line 17)
> FAIL: gcc.target/powerpc/vsu/vec-xl-len-13.c (test for excess errors)
> FAIL: gcc.target/powerpc/vsu/vec-xst-len-13.c  (test for errors, line 18)
> FAIL: gcc.target/powerpc/vsu/vec-xst-len-13.c (test for excess errors)
> 
> Andreas.
> 
> -- 
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2017-08-08 12:46 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-02 15:29 [PATCH, rs6000] Clean up capitalized diagnostic messages Bill Schmidt
2017-08-02 15:55 ` Jakub Jelinek
2017-08-02 16:04   ` Joseph Myers
2017-08-02 18:50     ` Bill Schmidt
2017-08-02 16:49 ` Martin Sebor
2017-08-02 23:44 ` Segher Boessenkool
2017-08-03 18:28   ` Bill Schmidt
2017-08-06  8:08 ` Andreas Schwab
2017-08-07 10:51   ` Segher Boessenkool
2017-08-08 12:46   ` Bill Schmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).