From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68522 invoked by alias); 3 Aug 2017 18:28:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 68504 invoked by uid 89); 3 Aug 2017 18:28:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=Approved X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Aug 2017 18:28:50 +0000 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v73INZqD092247 for ; Thu, 3 Aug 2017 14:28:48 -0400 Received: from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204]) by mx0b-001b2d01.pphosted.com with ESMTP id 2c44aqj2tw-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 03 Aug 2017 14:28:48 -0400 Received: from localhost by e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 3 Aug 2017 14:28:47 -0400 Received: from b01cxnp22036.gho.pok.ibm.com (9.57.198.26) by e14.ny.us.ibm.com (146.89.104.201) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 3 Aug 2017 14:28:44 -0400 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v73ISiog25559262; Thu, 3 Aug 2017 18:28:44 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 39847AE03B; Thu, 3 Aug 2017 14:28:59 -0400 (EDT) Received: from bigmac.rchland.ibm.com (unknown [9.10.86.172]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTPS id EBAE1AE034; Thu, 3 Aug 2017 14:28:58 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH, rs6000] Clean up capitalized diagnostic messages From: Bill Schmidt In-Reply-To: <20170802234336.GU13471@gate.crashing.org> Date: Thu, 03 Aug 2017 18:28:00 -0000 Cc: GCC Patches , jakub@redhat.com, David Edelsohn Content-Transfer-Encoding: quoted-printable References: <9a2980f0-01ed-1474-c4a2-f743695d60f8@linux.vnet.ibm.com> <20170802234336.GU13471@gate.crashing.org> To: Segher Boessenkool X-TM-AS-GCONF: 00 x-cbid: 17080318-0052-0000-0000-0000024A3DA9 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007478; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000216; SDB=6.00897073; UDB=6.00448826; IPR=6.00677256; BA=6.00005509; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016518; XFM=3.00000015; UTC=2017-08-03 18:28:46 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17080318-0053-0000-0000-0000518D0FC4 Message-Id: <92EDD1B5-A18B-40A2-A01A-3A42AA43B633@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-03_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1708030282 X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00344.txt.bz2 > On Aug 2, 2017, at 6:43 PM, Segher Boessenkool wrote: >=20 > Hi Bill, >=20 > On Wed, Aug 02, 2017 at 10:29:20AM -0500, Bill Schmidt wrote: >> I don't anticipate backporting any of this. >=20 > Good :-) >=20 >> @@ -6802,7 +6802,7 @@ altivec_resolve_overloaded_builtin (location_t loc >> if (unsupported_builtin) >> { >> const char *name =3D rs6000_overloaded_builtin_name (fcode); >> - error ("Builtin function %s not supported in this compiler configurati= on", >> + error ("builtin function %s not supported in this compiler configurati= on", >> name); >=20 > As Martin says, %qs for this and similar (see the documentation before > pp_format in pretty-print.c). Can be a separate patch of course, this > one is big enough already. >=20 >> Index: gcc/config/rs6000/rs6000.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- gcc/config/rs6000/rs6000.c (revision 250791) >> +++ gcc/config/rs6000/rs6000.c (working copy) >> @@ -4132,7 +4132,7 @@ rs6000_option_override_internal (bool global_init_ >> || rs6000_cpu =3D=3D PROCESSOR_PPCE5500) >> { >> if (TARGET_ALTIVEC) >> - error ("AltiVec not supported in this target"); >> + error ("altivec not supported in this target"); >> } >>=20 >> /* If we are optimizing big endian systems for space, use the load/sto= re >=20 > Let's either keep AltiVec or say -maltivec. We only have this warning > because we allow -maltivec with CPUs that do not support it; and this > warning is only for some of the FSL CPUs. It isn't very consistent. Back to AltiVec it goes! Thanks. >=20 >> @@ -4250,7 +4250,7 @@ rs6000_option_override_internal (bool global_init_ >> rs6000_isa_flags |=3D (ISA_3_0_MASKS_SERVER & ~ignore_masks); >> } >> else >> - error ("Power9 target option is incompatible with -mcpu=3D fo= r " >> + error ("power9 target option is incompatible with -mcpu=3D fo= r " >> " less than power9"); >> } >> else if ((ISA_3_0_MASKS_SERVER & rs6000_isa_flags_explicit) >=20 > See also PR79477. Since many of these options are going away it is > probably not worth spending too much time on this, not until stage 3 > or so anyway. Yeah, let's address that later in the year after Mike finishes his cleanups. >=20 >> @@ -11226,7 +11226,7 @@ rs6000_return_in_memory (const_tree type, const_= tr >> static bool warned_for_return_big_vectors =3D false; >> if (!warned_for_return_big_vectors) >> { >> - warning (OPT_Wpsabi, "GCC vector returned by reference: " >> + warning (OPT_Wpsabi, "gcc vector returned by reference: " >> "non-standard ABI extension with no compatibility guarantee"); >> warned_for_return_big_vectors =3D true; >> } >=20 > Maybe the warning should just say "big vector"? Or "generic vector"? >=20 > (Vectors that fit in one VR, or in GPRs in 8 bytes or less, do not have > the problem this warns for. Kind of hard to express tersely and > precisely though). I looked in the GCC manual and couldn't find a better way of expressing this than just "GCC vector," so I will return it to the way it was. "GCC=20 vector extension vector" is accurate but hardly trips lightly off the tongue... >=20 > Approved for trunk with whichever of the suggested changes you think > are good. Thanks, Thanks much! Bill >=20 >=20 > Segher >=20