From: Vladimir Makarov <vmakarov@redhat.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: patch to fix PR70703
Date: Wed, 05 Apr 2017 15:11:00 -0000 [thread overview]
Message-ID: <92d87dc9-0d07-4540-55cd-eca8177ae533@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 172 bytes --]
The following patch fixes
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70703
The patch was successfully bootstrapped and tested on x86-64.
Committed as rev. 246707
[-- Attachment #2: pr70703.patch --]
[-- Type: text/x-patch, Size: 2739 bytes --]
Index: ChangeLog
===================================================================
--- ChangeLog (revision 246706)
+++ ChangeLog (working copy)
@@ -1,3 +1,10 @@
+2017-04-05 Vladimir Makarov <vmakarov@redhat.com>
+
+ PR rtl-optimization/70703
+ * ira-color.c (update_costs_from_allocno): Use the smallest mode.
+ (update_conflict_hard_regno_costs): Use long instead of unsigned
+ arithmetic for cost calculation.
+
2017-04-05 Jakub Jelinek <jakub@redhat.com>
Bernd Edlinger <bernd.edlinger@hotmail.de>
Index: testsuite/ChangeLog
===================================================================
--- testsuite/ChangeLog (revision 246706)
+++ testsuite/ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2017-04-05 Vladimir Makarov <vmakarov@redhat.com>
+
+ PR rtl-optimization/70703
+ * gcc.target/i386/pr70703.c: New.
+
2017-04-05 Jakub Jelinek <jakub@redhat.com>
PR sanitizer/80308
Index: ira-color.c
===================================================================
--- ira-color.c (revision 246536)
+++ ira-color.c (working copy)
@@ -1367,6 +1367,16 @@ update_costs_from_allocno (ira_allocno_t
|| ALLOCNO_ASSIGNED_P (another_allocno))
continue;
+ if (GET_MODE_SIZE (ALLOCNO_MODE (cp->second)) < GET_MODE_SIZE (mode))
+ /* If we have different modes use the smallest one. It is
+ a sub-register move. It is hard to predict what LRA
+ will reload (the pseudo or its sub-register) but LRA
+ will try to minimize the data movement. Also for some
+ register classes bigger modes might be invalid,
+ e.g. DImode for AREG on x86. For such cases the
+ register move cost will be maximal. */
+ mode = ALLOCNO_MODE (cp->second);
+
cost = (cp->second == allocno
? ira_register_move_cost[mode][rclass][aclass]
: ira_register_move_cost[mode][aclass][rclass]);
@@ -1512,7 +1522,7 @@ update_conflict_hard_regno_costs (int *c
index = ira_class_hard_reg_index[aclass][hard_regno];
if (index < 0)
continue;
- cost = (int) ((unsigned) conflict_costs [i] * mult) / div;
+ cost = (int) (((long) conflict_costs [i] * mult) / div);
if (cost == 0)
continue;
cont_p = true;
Index: testsuite/gcc.target/i386/pr70703.c
===================================================================
--- testsuite/gcc.target/i386/pr70703.c (nonexistent)
+++ testsuite/gcc.target/i386/pr70703.c (working copy)
@@ -0,0 +1,9 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fomit-frame-pointer" } */
+/* { dg-require-effective-target ia32 } */
+/* { dg-final { scan-assembler "movl\t\\\$6700417, %eax" } } */
+
+unsigned ud_x_641_mul(unsigned x) {
+ /* optimized version of x / 641 */
+ return ((unsigned long long)x * 0x663d81) >> 32;
+}
next reply other threads:[~2017-04-05 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 15:11 Vladimir Makarov [this message]
2017-04-05 15:25 ` Jakub Jelinek
2017-04-05 16:07 ` Vladimir Makarov
2017-04-05 16:18 ` Vladimir Makarov
2017-04-06 10:24 ` Richard Biener
2017-04-07 16:07 ` Vladimir Makarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92d87dc9-0d07-4540-55cd-eca8177ae533@redhat.com \
--to=vmakarov@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).