From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 85E5E384B826 for ; Mon, 11 Jan 2021 20:03:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 85E5E384B826 Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-Al9Km2aYM8mOebKCaeWL8w-1; Mon, 11 Jan 2021 15:03:13 -0500 X-MC-Unique: Al9Km2aYM8mOebKCaeWL8w-1 Received: by mail-io1-f70.google.com with SMTP id x7so406129ion.12 for ; Mon, 11 Jan 2021 12:03:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7PyUi3X16pmZxTBldaAvftnF6bbbEHmLLC41zAZjmI4=; b=S2Hrje3FkDVEP/CzZeapeZLTREzVkbkkzFgZN1AM7jR/z3nuKiA9siaKus9jxWA6CE PDBlEsPmw9dg31h7s4Ll5LVsTZeXSOCQ+h8esx5+r5Hp5IVi1pquGRf6a1r/xMrPhXL0 3i6eoLYCSsEAjxthdmLEdM5P/j54gAQhHj7TUtWflgtnW15GhvQxUnxmOMPmaFM67XAB +ppIMHtT4628k/i4wBsPG0tQiPrZkCU64r2GXVs5hrf/NyISrmqSZ5IxHCKRIrPzUUo/ 09MlwxT6fhXz7WGA22JE3JxtcPObQfkHq2Z/2qRaRRRKl/h/VM3uPYd+pCIt6NneFgrt CEag== X-Gm-Message-State: AOAM531lVgKVC2Ntmm+cOJxwR7EZevedCW389sXcN8mbXjuVc7Ki0dc8 IxmqhFUmWtld4BzkxtTOdA8H3Kxi5VgveE78N5c+XHHzN0uoEZjqQNjR7CPIy/7C5milHCED6X2 qkgC3EZ/Qgn02gKYlfF2VLNQ/EirDurcaF5Nm1AHL4t3D5RHTgceW62z3ySBl2NIoug== X-Received: by 2002:a92:9509:: with SMTP id y9mr739601ilh.103.1610395392514; Mon, 11 Jan 2021 12:03:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJzGvax1M5p90jXDiVGfda72pfltXlN21D5pIGSBlni4qngSj0QdlDQA69bUafyOJNRDTR3ZSw== X-Received: by 2002:a92:9509:: with SMTP id y9mr739571ilh.103.1610395392120; Mon, 11 Jan 2021 12:03:12 -0800 (PST) Received: from [192.168.1.148] (209-6-216-142.s141.c3-0.smr-cbr1.sbo-smr.ma.cable.rcncustomer.com. [209.6.216.142]) by smtp.gmail.com with ESMTPSA id r11sm408767ilg.39.2021.01.11.12.03.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jan 2021 12:03:11 -0800 (PST) Subject: Re: [PATCH] c++: private inheritance access diagnostics fix [PR17314] To: Anthony Sharp Cc: gcc-patches@gcc.gnu.org References: <8beca582-97eb-3e4c-1437-162ae896f031@redhat.com> From: Jason Merrill Message-ID: <92edd773-5832-6371-4003-d29d1539202a@redhat.com> Date: Mon, 11 Jan 2021 15:03:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2021 20:03:17 -0000 On 1/8/21 7:38 PM, Anthony Sharp wrote: > Hi Jason, > > Thank you! > >> To start with, do you have a copyright assignment on file or in the >> works already? > > Good point. I incorrectly assumed it would only be a minor > contribution copyright-wise. > Mr Edelsohn gave me a template which I've > now filled out and sent to assign@gnu.org. I'm assuming I just need to > wait for them to send me the form. I'll update this thread when that's > sorted. In the meantime I've hopefully fixed some of the issues. Great. >> Second, your patch was mangled by word wrap so that it can't be applied >> without manual repair. If you can't prevent word wrap in your mail >> client, please send it as an attachment rather than inline. > > Oh yes I see where it's gotten mangled now. I'm attaching it as a > .patch file (I assume that's okay). > >> Also, there are a few whitespace issues in the patch; please run >> contrib/check_GNU_style.sh on the patch before submitting. > > Should be all fixed now (there is one style issue left but it's a > false positive). Visual Studio Code was lying to me about what the > file looks like so if there are any more formatting issues please let > me know. > >> If you use contrib/gcc-git-customization.sh and then git >> gcc-commit-mklog you don't need to touch ChangeLog files at all, just >> adjust the generated ChangeLog entries in the git commit message. I >> personally tend to commit first with a placeholder message and then use >> git gcc-commit-mklog --amend to generate the ChangeLog entries. > > Wouldn't that require read-write access? (Just from looking here > https://gcc.gnu.org/gitwrite.html.) You don't need write access to the main repository to use these commands on your local copy. One nice thing about git compared to svn is that you don't need to touch the server for anything but push and pull. Incidentally, how are you producing your patch? Maybe try git format-patch instead. >> Probably. Can you use sort/uniq/diff on the .sum testsuite output to >> determine which passes are missing in the patched sources? > > According to contrib/dg-cmp-results.sh ... > > I get a bunch of these weird NA->PASSes (and vice-versa), for example: > > PASS->NA: g++.dg/modules/alias-1_a.H module-cmi > (gcm.cache/home/anthony/Desktop/GCC/builds_and_source/source_clean/gcc/testsuite/g++.dg/modules/alias-1_a.H.gcm) > NA->PASS: g++.dg/modules/alias-1_a.H module-cmi > (gcm.cache/home/anthony/Desktop/GCC/builds_and_source/source_pr17314/gcc/testsuite/g++.dg/modules/alias-1_a.H.gcm) > PASS->NA: g++.dg/modules/alias-1_a.H module-cmi > (gcm.cache/home/anthony/Desktop/GCC/builds_and_source/source_clean/gcc/testsuite/g++.dg/modules/alias-1_a.H.gcm) > NA->PASS: g++.dg/modules/alias-1_a.H module-cmi > (gcm.cache/home/anthony/Desktop/GCC/builds_and_source/source_pr17314/gcc/testsuite/g++.dg/modules/alias-1_a.H.gcm) > > They're weird because I haven't actually touched those files (so I'm > assuming this is normal). There are about ~400 of those and they're > all .gcm files. They seem to balance out. The modules code and tests are very new and volatile, I wouldn't worry about them. > dr142.c reports: > > NA->PASS: g++.dg/tc1/dr142.C -std=c++14 (test for warnings, line 11) > PASS->NA: g++.dg/tc1/dr142.C -std=c++14 (test for warnings, line 5) > PASS->NA: g++.dg/tc1/dr142.C -std=c++14 (test for warnings, line 7) > PASS->NA: g++.dg/tc1/dr142.C -std=c++14 (test for warnings, line 8) > NA->PASS: g++.dg/tc1/dr142.C -std=c++17 (test for warnings, line 11) > PASS->NA: g++.dg/tc1/dr142.C -std=c++17 (test for warnings, line 5) > PASS->NA: g++.dg/tc1/dr142.C -std=c++17 (test for warnings, line 7) > PASS->NA: g++.dg/tc1/dr142.C -std=c++17 (test for warnings, line 8) > NA->PASS: g++.dg/tc1/dr142.C -std=c++2a (test for warnings, line 11) > PASS->NA: g++.dg/tc1/dr142.C -std=c++2a (test for warnings, line 5) > PASS->NA: g++.dg/tc1/dr142.C -std=c++2a (test for warnings, line 7) > PASS->NA: g++.dg/tc1/dr142.C -std=c++2a (test for warnings, line 8) > NA->PASS: g++.dg/tc1/dr142.C -std=c++98 (test for warnings, line 11) > PASS->NA: g++.dg/tc1/dr142.C -std=c++98 (test for warnings, line 5) > PASS->NA: g++.dg/tc1/dr142.C -std=c++98 (test for warnings, line 7) > PASS->NA: g++.dg/tc1/dr142.C -std=c++98 (test for warnings, line 8) These changes are because your patch changes that test to expect warnings in different places. > In other words, there are 12 PASS->NAs and 4 NA->PASSes in this file, > meaning a net change of -8 (which explains why there are eight fewer). > My other changes also report PASS->NAs and vice-versa, but for those > the number of new NAs equals the number of new PASSes, so they don't > cause a change in quantity. > > Thanks for being patient with me. I'll let you know when I've > completed the forms. > > Also if I need to adjust the .patch to deal with the changelogs issue > please let me know. > > Kind regards, > Anthony >