From: Matthieu Longo <matthieu.longo@arm.com>
To: Richard Earnshaw <Richard.Earnshaw@arm.com>, gcc-patches@gcc.gnu.org
Cc: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
Subject: [PATCH][GCC][Arm] Missing optimization pattern for rev16 on architectures with thumb1
Date: Mon, 12 Feb 2024 13:48:16 +0000 [thread overview]
Message-ID: <9336d774-4b6e-468b-93fe-98e96a7c4bd2@arm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 444 bytes --]
This patch marks a rev16 test as XFAIL for architectures having only
Thumb1 support. The generated code is functionally correct, but the
optimization is disabled when -mthumb is equivalent to Thumb1. Fixing
the root issue would requires changes that are not suitable for GCC14
stage 4.
More information at https://linaro.atlassian.net/browse/GNU-1141
gcc/testsuite/ChangeLog:
* gcc.target/arm/rev16_2.c: XFAIL when compiled with Thumb1.
[-- Attachment #2: 0001-arm-Missing-optimization-pattern-for-rev16-on-archit.patch --]
[-- Type: text/plain, Size: 1317 bytes --]
From 11be6a0feb1cbc0bca6e23dacf98c5817b71ba3d Mon Sep 17 00:00:00 2001
From: Matthieu Longo <matthieu.longo@arm.com>
Date: Thu, 8 Feb 2024 18:13:49 +0000
Subject: [PATCH] [arm] Missing optimization pattern for rev16 on architectures
with thumb1.
This patch marks a rev16 test as XFAIL for architectures having only Thumb1
support. The generated code is functionally correct, but the optimization is
disabled when -mthumb is equivalent to Thumb1. Fixing the root issue would
requires changes that are not suitable for GCC14 stage 4.
More information at https://linaro.atlassian.net/browse/GNU-1141
gcc/testsuite/ChangeLog:
* gcc.target/arm/rev16_2.c: XFAIL when compiled with Thumb1.
---
gcc/testsuite/gcc.target/arm/rev16_2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/testsuite/gcc.target/arm/rev16_2.c b/gcc/testsuite/gcc.target/arm/rev16_2.c
index c6553b38a00..dff66e10bb9 100644
--- a/gcc/testsuite/gcc.target/arm/rev16_2.c
+++ b/gcc/testsuite/gcc.target/arm/rev16_2.c
@@ -17,4 +17,4 @@ __rev16_32 (__u32 x)
| (((__u32)(x) & (__u32)0xff00ff00UL) >> 8);
}
-/* { dg-final { scan-assembler-times {rev16\tr[0-9]+, r[0-9]+} 2 } } */
+/* { dg-final { scan-assembler-times {rev16\tr[0-9]+, r[0-9]+} 2 { xfail arm_thumb1_ok } } } */
\ No newline at end of file
--
2.34.1
next reply other threads:[~2024-02-12 13:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 13:48 Matthieu Longo [this message]
2024-02-15 14:35 ` Richard Earnshaw (lists)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9336d774-4b6e-468b-93fe-98e96a7c4bd2@arm.com \
--to=matthieu.longo@arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).