Re: [PATCH V2 2/5] OpenMP: C front end support for imperfectly-nested loops

[Sandra Loosemore <sandra.loosemore@siemens.com>]

On 8/22/23 07:23, Jakub Jelinek wrote:
> 
>> diff --git a/gcc/testsuite/c-c++-common/goacc/collapse-1.c b/gcc/testsuite/c-c++-common/goacc/collapse-1.c
>> index 11b14383983..0feac8f8ddb 100644
>> --- a/gcc/testsuite/c-c++-common/goacc/collapse-1.c
>> +++ b/gcc/testsuite/c-c++-common/goacc/collapse-1.c
>> @@ -8,8 +8,8 @@ f1 (void)
>>   {
>>     #pragma acc parallel
>>     #pragma acc loop collapse (2)
>> -  for (i = 0; i < 5; i++)
>> -    ;					/* { dg-error "not enough perfectly nested" } */
>> +  for (i = 0; i < 5; i++)	/* { dg-error "not enough nested loops" } */
>> +    ;
>>     {
>>       for (j = 0; j < 5; j++)
>>         ;
> 
> All these c-c++-common testsuite changes will now FAIL after the C patch but
> before the C++.  It is nice to have the new c-c++-common tests in a separate
> patch, but these tweaks which can't be just avoided need the temporary
> { target c } vs. { target c++} hacks undone later in the C++ patch.

In spite of being in the c-c++-common subdirectory, this particular testcase is 
presently run only for C:

/* { dg-skip-if "not yet" { c++ } } */

I did previously do incremental testing between applying the the C and C++ 
parts of the series to confirm that there were no regressions.

BTW, thanks for your previous detailed review of the original version of this 
patch, and pointing out many things I'd overlooked; I feel that V2 is much more 
robust and correct as a result.  :-)

-Sandra