From: Jeff Law <law@redhat.com>
To: Aaron Sawdey <acsawdey@linux.ibm.com>, gcc-patches@gcc.gnu.org
Cc: segher@kernel.crashing.org, wschmidt@linux.ibm.com,
dje.gcc@gmail.com, rguenther@suse.de, jakub@redhat.com,
matz@suse.de
Subject: Re: [PATCH 31/30] Update documentation for movmem to cpymem change
Date: Wed, 26 Jun 2019 22:06:00 -0000 [thread overview]
Message-ID: <93410578-4b26-e70e-6a9c-2cbb4bd62e8a@redhat.com> (raw)
In-Reply-To: <71f0d015-7b96-0dbf-8776-1a1559902bb9@linux.ibm.com>
On 6/26/19 2:16 PM, Aaron Sawdey wrote:
> On 6/25/19 4:43 PM, Jeff Law wrote:
>> On 6/25/19 2:22 PM, acsawdey@linux.ibm.com wrote:
>>> From: Aaron Sawdey <acsawdey@linux.ibm.com>
>>>
>>> * builtins.c (get_memory_rtx): Fix comment.
>>> * optabs.def (movmem_optab): Change to cpymem_optab.
>>> * expr.c (emit_block_move_via_cpymem): Change movmem to cpymem.
>>> (emit_block_move_hints): Change movmem to cpymem.
>>> * defaults.h: Change movmem to cpymem.
>>> * targhooks.c (get_move_ratio): Change movmem to cpymem.
>>> (default_use_by_pieces_infrastructure_p): Ditto.
>> So I think you're missing an update to the RTL/MD documentation. This
>> is also likely to cause problems for any out-of-tree ports, so it's
>> probably worth a mention in the gcc-10 changes, which will need to be
>> created (in CVS no less, ugh).
>>
>> I think the stuff posted to-date is fine, but it shouldn't go in without
>> the corresponding docs and gcc-10 changes updates.
> This would be my proposed patch to update the documentation. I'll also work
> out what the entry in the gcc 10 changes and post that for review before
> this all goes in.
>
> OK for trunk along with the other 30 patches?
>
> Thanks,
> Aaron
>
>
>
> * doc/md.texi: Change movmem to cpymem and update description to match.
> * doc/rtl.texi: Change movmem to cpymem.
> * target.def (use_by_pieces_infrastructure_p): Change movmem to cpymem.
> * doc/tm.texi: Regenerate.
OK. The entire kit is OK for the trunk now.
jeff
next prev parent reply other threads:[~2019-06-26 22:06 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 20:23 [PATCH 00/30] Rename movmem pattern to cpymem acsawdey
2019-06-25 20:24 ` [PATCH 03/30] Changes for alpha acsawdey
2019-06-25 20:24 ` [PATCH 02/30] Changes for aarch64 acsawdey
2019-06-26 8:59 ` Richard Earnshaw (lists)
2019-06-25 20:24 ` [PATCH 04/30] Changes to arc acsawdey
2019-07-01 11:30 ` Andrew Burgess
2019-06-25 20:25 ` [PATCH 06/30] Changes to avr acsawdey
2019-06-25 20:25 ` [PATCH 07/30] Changes to bfin acsawdey
2019-06-25 20:25 ` [PATCH 05/30] Changes to arm acsawdey
2019-06-26 8:59 ` Richard Earnshaw
2019-06-25 20:26 ` [PATCH 09/30] Changes to frv acsawdey
2019-06-25 20:26 ` [PATCH 08/30] Changes to c6x acsawdey
2019-06-25 20:26 ` [PATCH 10/30] Changes to ft32 acsawdey
2019-06-25 20:26 ` [PATCH 11/30] Changes to h8300 acsawdey
2019-06-25 20:27 ` [PATCH 12/30] Changes to i386 acsawdey
2019-06-26 7:57 ` Uros Bizjak
2019-06-25 20:28 ` [PATCH 13/30] Changes to lm32 acsawdey
2019-06-25 20:28 ` [PATCH 14/30] Changes to m32c acsawdey
2019-06-25 20:28 ` [PATCH 01/30] Changes to machine independent code acsawdey
2019-06-25 21:43 ` Jeff Law
2019-06-26 8:37 ` Richard Sandiford
2019-06-26 8:58 ` Richard Earnshaw
2019-06-26 20:16 ` [PATCH 31/30] Update documentation for movmem to cpymem change Aaron Sawdey
2019-06-26 22:06 ` Jeff Law [this message]
2019-06-27 18:39 ` [PATCH 32/30] Document movmem/cpymem changes in gcc-10/changes.html Aaron Sawdey
2019-06-28 21:33 ` Jeff Law
2019-06-25 20:29 ` [PATCH 15/30] Changes to m32r acsawdey
2019-06-25 20:29 ` [PATCH 16/30] Changes to mcore acsawdey
2019-06-25 20:30 ` [PATCH 18/30] Changes to mips acsawdey
2019-06-25 20:30 ` [PATCH 17/30] Changes to microblaze acsawdey
2019-06-25 20:49 ` Michael Eager
2019-06-25 20:31 ` [PATCH 20/30] Changes to pa acsawdey
2019-06-25 20:31 ` [PATCH 19/30] Changes to nds32 acsawdey
2019-06-25 20:32 ` [PATCH 21/30] Changes to pdp11 acsawdey
2019-06-27 14:19 ` Paul Koning
2019-06-25 20:37 ` [PATCH 22/30] Changes to riscv acsawdey
2019-06-25 20:38 ` [PATCH 23/30] Changes to rs6000 acsawdey
2019-06-26 21:57 ` Segher Boessenkool
2019-06-25 20:38 ` [PATCH 24/30] Changes to rx acsawdey
2019-06-25 20:39 ` [PATCH 25/30] Changes to s390 acsawdey
2019-06-25 20:39 ` [PATCH 26/30] Changes to sh acsawdey
2019-06-29 0:50 ` Oleg Endo
2019-06-25 20:40 ` [PATCH 27/30] Changes to sparc acsawdey
2019-06-25 20:40 ` [PATCH 28/30] Changes to vax acsawdey
2019-06-25 20:40 ` [PATCH 29/30] Changes to visium acsawdey
2019-06-25 20:41 ` [PATCH 30/30] Changes to xtensa acsawdey
2019-06-25 20:41 ` augustine.sterling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93410578-4b26-e70e-6a9c-2cbb4bd62e8a@redhat.com \
--to=law@redhat.com \
--cc=acsawdey@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=matz@suse.de \
--cc=rguenther@suse.de \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).