From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54561 invoked by alias); 12 Aug 2019 15:18:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 54546 invoked by uid 89); 12 Aug 2019 15:18:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.8 required=5.0 tests=BAYES_00,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=1j, H*Ad:U*tkoenig, gang, trip X-HELO: cc-smtpout1.netcologne.de Received: from cc-smtpout1.netcologne.de (HELO cc-smtpout1.netcologne.de) (89.1.8.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Aug 2019 15:18:23 +0000 Received: from cc-smtpin2.netcologne.de (cc-smtpin2.netcologne.de [89.1.8.202]) by cc-smtpout1.netcologne.de (Postfix) with ESMTP id 09072133EC; Mon, 12 Aug 2019 17:18:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=netcologne.de; s=nc1116a; t=1565623101; bh=r59gguGJ4w+r8KkkiVrmqhaGF0NloU8Zd535Vrd9Puc=; h=To:From:Subject:Message-ID:Date:From; b=XHUBozh48k3wbJbtdbrdMEAlMG8WjjTND8Kb/s61KqZ/4ofH47DvWLWcKcaCCMpkn Q4GgNaVOCUCIvWq+fuAVGIFTPulxhlame5UTskP4FOF3YiWpj/xZGN2wQLUkZI9Mw9 IoLitIWZX9JIgXLcOJ5IZ7Uog256GAx+oBnM7CwSZ+llAjQ/gEwwozCyergbh+94Ed fH03Uow7P7jEtx/c3CKJmy+sqZUWyC3esNcMp4wskGb8llOfNhA21KWPyH7AE4LPPh WlJ/p2wTK2fumDkkCGlMB45jatcXU57YEwG81KPK9LAgRmFvQceWHqGDsIDIAEn+dV kSERqVdFxsO9Q== Received: from localhost (localhost [127.0.0.1]) by cc-smtpin2.netcologne.de (Postfix) with ESMTP id EE20311EF5; Mon, 12 Aug 2019 17:18:20 +0200 (CEST) Received: from [2001:4dd6:e4c:0:7285:c2ff:fe6c:992d] (helo=cc-smtpin2.netcologne.de) by localhost with ESMTP (eXpurgate 4.6.0) (envelope-from ) id 5d51833c-669a-7f0000012729-7f000001b206-1 for ; Mon, 12 Aug 2019 17:18:20 +0200 Received: from [IPv6:2001:4dd6:e4c:0:7285:c2ff:fe6c:992d] (2001-4dd6-e4c-0-7285-c2ff-fe6c-992d.ipv6dyn.netcologne.de [IPv6:2001:4dd6:e4c:0:7285:c2ff:fe6c:992d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by cc-smtpin2.netcologne.de (Postfix) with ESMTPSA; Mon, 12 Aug 2019 17:18:19 +0200 (CEST) To: "fortran@gcc.gnu.org" , gcc-patches From: Thomas Koenig Subject: [patch, fortran] Some corrections for DO loop index warnings Message-ID: <93ba61ec-0db4-1888-9a3f-856a4c59d9ba@netcologne.de> Date: Mon, 12 Aug 2019 16:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------5C73425D6874C6C50DE6978A" X-SW-Source: 2019-08/txt/msg00751.txt.bz2 This is a multi-part message in MIME format. --------------5C73425D6874C6C50DE6978A Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1006 Hello world, the attached patch fixes three problems with DO loop index warnings: - DO loops in contained procedures were not checked - Zero-trip loops gave a false positive - DO loops in blocks gave the same warning twice plus it fixes the resulting fallout from the test suite. Regression-tested. OK for trunk? I also think that this is something that could be safely backported to gcc-9. 2019-08-12 Thomas Koenig PR fortran/91424 * frontend-passes.c (do_subscript): Do not warn for an expression a second time. Do not warn about a zero-trip loop. (doloop_warn): Also look at contained namespaces. 2019-08-12 Thomas Koenig PR fortran/91424 * gfortran.dg/do_subscript_3.f90: New test. * gfortran.dg/do_subscript_4.f90: New test. * gfortran.dg/pr70754.f90: Use indices that to not overflow. 2019-08-12 Thomas Koenig PR fortran/91422 * testsuite/libgomp.oacc-fortran/routine-7.f90: Correct array dimension. --------------5C73425D6874C6C50DE6978A Content-Type: text/x-fortran; name="do_subscript_3.f90" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="do_subscript_3.f90" Content-length: 526 ! { dg-do compile } ! PR fortran/91424 ! Check that only one warning is issued inside blocks, and that ! warnings are also issued for contained subroutines. program main real :: a(5) block integer :: j do j=0, 5 ! { dg-warning "out of bounds" } a(j) = 2. ! { dg-warning "out of bounds" } end do end block call x contains subroutine x integer :: i do i=1,6 ! { dg-warning "out of bounds" } a(i) = 2. ! { dg-warning "out of bounds" } end do end subroutine x end program main --------------5C73425D6874C6C50DE6978A Content-Type: text/x-patch; name="p3.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="p3.diff" Content-length: 2835 Index: gcc/fortran/frontend-passes.c =================================================================== --- gcc/fortran/frontend-passes.c (revision 273855) +++ gcc/fortran/frontend-passes.c (working copy) @@ -2556,6 +2556,12 @@ do_subscript (gfc_expr **e) if (in_assoc_list) return 0; + /* We already warned about this. */ + if (v->do_not_warn) + return 0; + + v->do_not_warn = 1; + for (ref = v->ref; ref; ref = ref->next) { if (ref->type == REF_ARRAY && ref->u.ar.type == AR_ELEMENT) @@ -2608,7 +2614,6 @@ do_subscript (gfc_expr **e) else have_do_start = false; - if (dl->ext.iterator->end->expr_type == EXPR_CONSTANT) { have_do_end = true; @@ -2620,6 +2625,17 @@ do_subscript (gfc_expr **e) if (!have_do_start && !have_do_end) return 0; + /* No warning inside a zero-trip loop. */ + if (have_do_start && have_do_end) + { + int sgn, cmp; + + sgn = mpz_cmp_ui (do_step, 0); + cmp = mpz_cmp (do_end, do_start); + if ((sgn > 0 && cmp < 0) || (sgn < 0 && cmp > 0)) + break; + } + /* May have to correct the end value if the step does not equal one. */ if (have_do_start && have_do_end && mpz_cmp_ui (do_step, 1) != 0) @@ -2761,6 +2777,12 @@ static void doloop_warn (gfc_namespace *ns) { gfc_code_walker (&ns->code, doloop_code, do_function, NULL); + + for (ns = ns->contained; ns; ns = ns->sibling) + { + if (ns->code == NULL || ns->code->op != EXEC_BLOCK) + doloop_warn (ns); + } } /* This selction deals with inlining calls to MATMUL. */ Index: gcc/testsuite/gfortran.dg/pr70754.f90 =================================================================== --- gcc/testsuite/gfortran.dg/pr70754.f90 (revision 273855) +++ gcc/testsuite/gfortran.dg/pr70754.f90 (working copy) @@ -18,12 +18,13 @@ contains integer (ii4), dimension(40,40) :: c integer i, j - do i=1,20 - b(i,j) = 123 * a(i,j) + 34 * a(i,j+1) & - + 34 * a(i,j-1) + a(i+1,j+1) & - + a(i+1,j-1) + a(i-1,j+1) & - + a(i-1,j-1) - c(i,j) = 123 + j = 10 + do i=11,30 + b(i,j) = 123 * a(i,j) + 34 * a(i,j+1) & + + 34 * a(i,j-1) + a(i+1,j+1) & + + a(i+1,j-1) + a(i-1,j+1) & + + a(i-1,j-1) + c(i,j) = 123 end do where ((xyz(:,:,2) /= 0) .and. (c /= 0)) Index: libgomp/testsuite/libgomp.oacc-fortran/routine-7.f90 =================================================================== --- libgomp/testsuite/libgomp.oacc-fortran/routine-7.f90 (revision 273855) +++ libgomp/testsuite/libgomp.oacc-fortran/routine-7.f90 (working copy) @@ -109,7 +109,7 @@ end subroutine gang subroutine seq (a) !$acc routine seq - integer, intent (inout) :: a(M) + integer, intent (inout) :: a(N) integer :: i do i = 1, N --------------5C73425D6874C6C50DE6978A Content-Type: text/x-fortran; name="do_subscript_4.f90" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="do_subscript_4.f90" Content-length: 212 ! { dg-do compile } ! PR 91424 - this used to warn although the DO loop is zero trip. program main implicit none integer :: i real :: a(2) do i=1,3,-1 a(i) = 2. end do print *,a end program main --------------5C73425D6874C6C50DE6978A--