From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id 739CE3858D1E for ; Sat, 24 Sep 2022 20:37:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 739CE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1032.google.com with SMTP id fs14so3025548pjb.5 for ; Sat, 24 Sep 2022 13:37:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=EAaUier1BdR8FVKDDGHODbyE7WTVvi7iuwI6IsZSfXQ=; b=lrG/NJTTSE/JyWiXl10tczEz5w6rxpoNS2rKDjrq6KFTOhC/0aoKnhDXiYZxWFsk1o MUvnELv+qmBeCQkjSWi5x8/C1zwbKwI0D6pMQAk0nweZyolHf+ooF25n1s+fODwXDN/R bAiwSkdaySzFOQCoLnRrQgCcK8xXy0AMG2fGXHRDFdGa6VCIMr1UWsoqt7oiagFWkkWe VJhJkhDjjM1Om6tTA7j+sYM37/lUY+HJbL7Fve+1+Avoygg0WAZjBnHziSy9nuCkH+LC TBwpPkPDZMXkbRyL7VN0PVe3dQC9in857ATRZ36pYDw1guDFFMQiM1FSf2411Oo6+h35 b63A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=EAaUier1BdR8FVKDDGHODbyE7WTVvi7iuwI6IsZSfXQ=; b=Li+lYkDtPnPJH08TsQC5iE7PL1jRtheygSMH8DSM5WVXJqwNFH5c3oVRQGp8V626c0 X4vKqe4qSnqYZ/CgSIEfIte9qWF97lxBwPubR1yPww8Hu/FZYxuHDhiAvIAXjTkA4xHH NOYSbOst2o0kCaMdG2pDjpf4PLRQgKlRqWrBsiTZkH/kuRh1dRw23kQsOYW/MYWURaQZ ILOpRPczo62ocjPG6SawWf7JmKbOyhGUsLleBBVPMln8JhdFeNCUR5MmjSmqS10gLRgi 2tKfcNPXH63Vmf8UerLiXkbyfZ9VsrWAI4bIsVEZ2ujcLdrbMJ7QIGI0c4Fib+Au5RMR 6lEw== X-Gm-Message-State: ACrzQf1kCE3xmqdo3fmiRrrkikGEc8WgbfimF0OlZY6gXykqpgc3A3TU uAgJB3/Rmo0pM5vAx02jUS4= X-Google-Smtp-Source: AMsMyM4chWrXadAFTuhECJDtWAOqI9FpKVEHiF+G8hbFPfxQd+VncNFNGord2s/r2Htmxh8us9KUGQ== X-Received: by 2002:a17:903:1cb:b0:178:4689:8f8b with SMTP id e11-20020a17090301cb00b0017846898f8bmr15164532plh.44.1664051849147; Sat, 24 Sep 2022 13:37:29 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id m3-20020a17090a2c0300b001fdbb2e38acsm3817992pjd.5.2022.09.24.13.37.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Sep 2022 13:37:28 -0700 (PDT) Message-ID: <93fb0c92-c6a4-450b-2d0a-eddd30543fae@gmail.com> Date: Sat, 24 Sep 2022 14:37:26 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] Ignore debug insns with CONCAT and CONCATN for insn scheduling Content-Language: en-US To: "H.J. Lu" Cc: gcc-patches@gcc.gnu.org References: <20220902143639.2464892-1-hjl.tools@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/21/22 16:11, H.J. Lu wrote: > On Wed, Sep 7, 2022 at 10:03 AM Jeff Law via Gcc-patches > wrote: >> >> >> On 9/2/2022 8:36 AM, H.J. Lu via Gcc-patches wrote: >>> CONCAT and CONCATN never appear in the insn chain. They are only used >>> in debug insn. Ignore debug insns with CONCAT and CONCATN for insn >>> scheduling to avoid different insn orders with and without debug insn. >>> >>> gcc/ >>> >>> PR rtl-optimization/106746 >>> * sched-deps.cc (sched_analyze_2): Ignore debug insns with CONCAT >>> and CONCATN. >> Shouldn't we be ignoring everything in a debug insn? I don't see why >> CONCAT/CONCATN are special here. > Debug insns are processed by insn scheduling. I think it is to improve debug > experiences. It is just that there are no matching usages of CONCAT/CONCATN > in non-debug insns. But from a dependency standpoint ISTM all debug insn can be ignored.  I still don't see why concat/concatn should be special here. jeff