From: Robin Dapp <rdapp.gcc@gmail.com>
To: Lehua Ding <lehua.ding@rivai.ai>, gcc-patches@gcc.gnu.org
Cc: rdapp.gcc@gmail.com, juzhe.zhong@rivai.ai, kito.cheng@gmail.com,
palmer@rivosinc.com, jeffreyalaw@gmail.com
Subject: Re: [PATCH V3] RISC-V: Support combine cond extend and reduce sum to widen reduce sum
Date: Thu, 21 Sep 2023 10:12:18 +0200 [thread overview]
Message-ID: <9419fbea-5038-d3ba-f855-9bd1634e6919@gmail.com> (raw)
In-Reply-To: <20230921053259.1382886-1-lehua.ding@rivai.ai>
Hi Lehua,
> V3 Change: Back to the original method.
Was there an original method even before the first patch?
Anyway, I prefer this v3 over the others even though the large
pattern is not exactly pretty :)
What about the VLS changes? Are they necessary for the patterns/tests?
I mean they are reasonable in themselves but are they related?
If so, please specify. If not please split them off into a small
(pre-approved) patch. OK with this adjusted.
Regards
Robin
next prev parent reply other threads:[~2023-09-21 8:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 5:32 Lehua Ding
2023-09-21 8:12 ` Robin Dapp [this message]
2023-09-21 8:27 ` Lehua Ding
2023-09-22 3:03 ` Lehua Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9419fbea-5038-d3ba-f855-9bd1634e6919@gmail.com \
--to=rdapp.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=lehua.ding@rivai.ai \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).