From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by sourceware.org (Postfix) with ESMTPS id C01B13858C52 for ; Thu, 21 Sep 2023 08:12:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C01B13858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2c00b37ad84so10565981fa.0 for ; Thu, 21 Sep 2023 01:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695283940; x=1695888740; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pnKy+ErK4kEauU/SuesUAAa9TD9Gf1F2vN4A4dvA9jg=; b=Q42hpoOkudhQhGGtPS28mHn81Y78/L/0sSBj1vl45rYo2vQc2uqDkgbOfCfwgFOnWN QSOCQf2YeODSPrbnXqyFHdHXcY1S4oxXJ5Ry4hr5xwIC9C8ZC7ZVOPB2c6xW6ZuJ9pV+ wFdQ7T7vAv0ClDTbvq6EHpP4s3wmhsd8OzLgGldsAWM8W2XZfci5jfy4fW3ECV+XFQzD 0LILUjUVWPmil9/nPkzoIdKn7/dOKqf7KoIf+uh8a50+D+SiOCgs7091Q+h47q8XV+uN ooFgwQaYgVRqalXsJyti6UhLAD/b/rGlLUAKJLnTs2iS42Yij914zo3H9r9sMOFfRal5 EoiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695283940; x=1695888740; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pnKy+ErK4kEauU/SuesUAAa9TD9Gf1F2vN4A4dvA9jg=; b=l+Gj9GjVsg3iqL82DsYYHNQ6NSOEx4YHM1304vqb03j/v4vF+UTV3IVgOKiSppFSM9 6NMgbLXn3Crw2WCm9fN72GabDQDyhbtmLBJKvp87icJhUKALSvlSHcj7B+y1lV5KCJsB 2j8NuawTIhPGIK3QgWwkrtfGst5gsWT8vGBo1p71LphF+vCghP+q7uPlIng1UbB6ogiI /R76JoMrH9sjWjP14/TtYbOhsIG9xhaBPvzrWw6etHygoxdgXgmFa2ensRvjwLuy/XFx EC+GJlUGXRrArEcQ9ACa31eOnzCsBWHvgPsRq6diznnXD2zLgO1WhRDy5csl96/+26sZ LMWw== X-Gm-Message-State: AOJu0YwuY8R9/FiOIw/NjQ/uBF0oxQgsZaUt2YkppJTNIQ+oSNbY2ZpY cjb4GyKQlH51skpZnKRs6nA= X-Google-Smtp-Source: AGHT+IEhAUXJCGTZm7bxozXqt0wx/SFnlcLX949n5xYG9WsQ+ffRMIYk7Lq4O5u7nvKrIc5I+gtJ2Q== X-Received: by 2002:a2e:9cd4:0:b0:2c0:32a1:71dd with SMTP id g20-20020a2e9cd4000000b002c032a171ddmr4227192ljj.28.1695283939608; Thu, 21 Sep 2023 01:12:19 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id rh27-20020a17090720fb00b0099b6becb107sm672702ejb.95.2023.09.21.01.12.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Sep 2023 01:12:19 -0700 (PDT) Message-ID: <9419fbea-5038-d3ba-f855-9bd1634e6919@gmail.com> Date: Thu, 21 Sep 2023 10:12:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: rdapp.gcc@gmail.com, juzhe.zhong@rivai.ai, kito.cheng@gmail.com, palmer@rivosinc.com, jeffreyalaw@gmail.com Subject: Re: [PATCH V3] RISC-V: Support combine cond extend and reduce sum to widen reduce sum To: Lehua Ding , gcc-patches@gcc.gnu.org References: <20230921053259.1382886-1-lehua.ding@rivai.ai> Content-Language: en-US From: Robin Dapp In-Reply-To: <20230921053259.1382886-1-lehua.ding@rivai.ai> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Lehua, > V3 Change: Back to the original method. Was there an original method even before the first patch? Anyway, I prefer this v3 over the others even though the large pattern is not exactly pretty :) What about the VLS changes? Are they necessary for the patterns/tests? I mean they are reasonable in themselves but are they related? If so, please specify. If not please split them off into a small (pre-approved) patch. OK with this adjusted. Regards Robin