[ping] allow target (OS) SUBTARGET_OVERRIDE_OPTIONS on aarch64

[ping] allow target (OS) SUBTARGET_OVERRIDE_OPTIONS on aarch64

[Olivier Hainque]

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

Ping for one of the changes last proposed here:

 https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00761.html

Submitted separately as an attempt to facilitate the review
process.

This one proposes the possibility for target (OS) configurations
to provide a SUBTARGET_OVERRIDE_OPTIONS macro as other CPU ports
do, needed by our aarch64-vxworks7 port to come.

Got access to a linux box, so in addition to the Ada nighty
testing we do on the cross port, bootstrapped and regression
tested on aarch64-linux.

OK to commit ?

Thanks in advance,

With Kind Regards,

Olivier


2018-12-12  Olivier Hainque  <hainque@adacore.com>

	* config/aarch64/aarch64.c (aarch64_override_options): Once arch,
	cpu and tune were validated, insert SUBTARGET_OVERRIDE_OPTIONS if
	defined.


[-- Attachment #2: 0002-Add-support-for-SUBTARGET_OVERRIDE_OPTIONS-on-aarch6.patch --]
[-- Type: application/octet-stream, Size: 1095 bytes --]

From 4267b4ef20007b5fa71b83c0ab8447771a80856d Mon Sep 17 00:00:00 2001
From: Olivier Hainque <hainque@adacore.com>
Date: Wed, 12 Dec 2018 06:53:04 -0800
Subject: [PATCH 2/4] Add support for SUBTARGET_OVERRIDE_OPTIONS on aarch64

	* config/aarch64/aarch64.c (aarch64_override_options): Once arch,
	cpu and tune were validated, insert SUBTARGET_OVERRIDE_OPTIONS if
	defined.
---
 gcc/config/aarch64/aarch64.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index 891de75..5e19370 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -11355,6 +11355,10 @@ aarch64_override_options (void)
   if (aarch64_tune_string)
     valid_tune = aarch64_validate_mtune (aarch64_tune_string, &selected_tune);
 
+#ifdef SUBTARGET_OVERRIDE_OPTIONS
+  SUBTARGET_OVERRIDE_OPTIONS;
+#endif
+
   /* If the user did not specify a processor, choose the default
      one for them.  This will be the CPU set during configuration using
      --with-cpu, otherwise it is "generic".  */
-- 
1.9.1

Re: [ping] allow target (OS) SUBTARGET_OVERRIDE_OPTIONS on aarch64

[James Greenhalgh]

On Wed, Dec 12, 2018 at 09:42:05AM -0600, Olivier Hainque wrote:
> Ping for one of the changes last proposed here:
> 
>  https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00761.html
> 
> Submitted separately as an attempt to facilitate the review
> process.
> 
> This one proposes the possibility for target (OS) configurations
> to provide a SUBTARGET_OVERRIDE_OPTIONS macro as other CPU ports
> do, needed by our aarch64-vxworks7 port to come.
> 
> Got access to a linux box, so in addition to the Ada nighty
> testing we do on the cross port, bootstrapped and regression
> tested on aarch64-linux.
> 
> OK to commit ?

OK.

Thanks,
James

> 2018-12-12  Olivier Hainque  <hainque@adacore.com>
> 
> 	* config/aarch64/aarch64.c (aarch64_override_options): Once arch,
> 	cpu and tune were validated, insert SUBTARGET_OVERRIDE_OPTIONS if
> 	defined.

Re: [ping] allow target (OS) SUBTARGET_OVERRIDE_OPTIONS on aarch64

[Olivier Hainque]

> On 12 Dec 2018, at 17:57, James Greenhalgh <james.greenhalgh@arm.com> wrote:

>> This one proposes the possibility for target (OS) configurations
>> to provide a SUBTARGET_OVERRIDE_OPTIONS macro as other CPU ports
>> do, needed by our aarch64-vxworks7 port to come.
> 
> OK.

Great :-) Thanks for your review James !