From: Jason Merrill <jason@redhat.com>
To: Paolo Carlini <paolo.carlini@oracle.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ Patch] Use declarator->id_loc in three additional places
Date: Tue, 04 Jun 2019 14:50:00 -0000 [thread overview]
Message-ID: <949e6bbb-47e4-7412-ab5f-a998eeaf706d@redhat.com> (raw)
In-Reply-To: <59ac4b84-5400-8c6f-7666-95e5e900faf6@oracle.com>
On 6/4/19 10:31 AM, Paolo Carlini wrote:
> + permerror (loc, "member functions are implicitly "
> + "friends of their class");
Wouldn't it be better to use the location of "friend" in this diagnostic?
The rest of the patch is OK.
Jason
next prev parent reply other threads:[~2019-06-04 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 14:32 Paolo Carlini
2019-06-04 14:50 ` Jason Merrill [this message]
2019-06-04 15:57 ` Paolo Carlini
2019-06-05 17:45 ` Jason Merrill
2019-06-05 18:09 ` Paolo Carlini
2019-06-05 18:37 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=949e6bbb-47e4-7412-ab5f-a998eeaf706d@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).