From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id DE3613858C20 for ; Mon, 25 Dec 2023 10:38:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE3613858C20 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DE3613858C20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703500708; cv=none; b=gBc3HrlPEey/+1SCGBXU9CgDVK57+p9f9nXgWCfARqCkj/ew5kBHqqYB9W7NdAHiOl0fE2wMh0pwu/PLo2rs6vvorF7gZOxdO7qxXIuxu3XjN7rtc67KxiE+56Mb2/tMi6Fm2jFPZje+q4w5zra5VFc3Qx7FL7BIdFmjwwlS74c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703500708; c=relaxed/simple; bh=gqjgx3IpbpNlpTAWp9W1yuCnFLbSvB//gHmRMVgou0w=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=R0q0xEigwieZhzjPiDxTHqkmA+GhelIrt51Si9qTppRDn2ipJdVzv5dn3xOyraZxlEqxG9xuYOdIGiyayo9db5KkNSwV+OR0onGNuG6MmtqV+111PNzpYHDHX4wqwBSviSPHb+2iqefdhIwzpMsSzNfSL4Gqc0s7SJWUiirETTs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1703500706; bh=gqjgx3IpbpNlpTAWp9W1yuCnFLbSvB//gHmRMVgou0w=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=BTwULCAUOajsNFp7issw0J2DgAgWcZQZ0b6Gzg30D4R0MBmQt6NQ8cofLlG05T/lk HMNyREBbgow/TPHRcOzGinC30iNchdy8fV8iRP+ZW2NNjL3tdvpkGL035bNNc3qyTv 2oaZwd9EVqTCPqhaOPV/C0TSdBB7C57Qq+XndXGI= Received: from [IPv6:240e:358:113a:1b00:dc73:854d:832e:2] (unknown [IPv6:240e:358:113a:1b00:dc73:854d:832e:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384)) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 8EF5666CAB; Mon, 25 Dec 2023 05:38:23 -0500 (EST) Message-ID: <94a60685a9f485ac54a77cd80d54b5320502ab63.camel@xry111.site> Subject: Re: Ping: [PATCH] LoongArch: Replace -mexplicit-relocs=auto simple-used address peephole2 with combine From: Xi Ruoyao To: chenglulu , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn Date: Mon, 25 Dec 2023 18:38:19 +0800 In-Reply-To: <5e431ffa-8097-7168-6338-9699afef61a9@loongson.cn> References: <20231212064754.6623-1-xry111@xry111.site> <64af9171-de9f-df27-1a84-b31fd0876a82@loongson.cn> <64c1875873aee3d8f196a4dd84fdf9f6fb3ee53d.camel@xry111.site> <8bb6e0c3-8e3c-7dc4-947d-fd338725fe16@loongson.cn> <0ca9482388b17b964b37a535ddd7c3e64b11fd93.camel@xry111.site> <1a13ff935218c67f72bc83175960e819677e317a.camel@xry111.site> <5e431ffa-8097-7168-6338-9699afef61a9@loongson.cn> Autocrypt: addr=xry111@xry111.site; prefer-encrypt=mutual; keydata=mDMEYnkdPhYJKwYBBAHaRw8BAQdAsY+HvJs3EVKpwIu2gN89cQT/pnrbQtlvd6Yfq7egugi0HlhpIFJ1b3lhbyA8eHJ5MTExQHhyeTExMS5zaXRlPoiTBBMWCgA7FiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQrKrSDhnnEOPHFgD8D9vUToTd1MF5bng9uPJq5y3DfpcxDp+LD3joA3U2TmwA/jZtN9xLH7CGDHeClKZK/ZYELotWfJsqRcthOIGjsdAPuDgEYnkdPhIKKwYBBAGXVQEFAQEHQG+HnNiPZseiBkzYBHwq/nN638o0NPwgYwH70wlKMZhRAwEIB4h4BBgWCgAgFiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwwACgkQrKrSDhnnEOPjXgD/euD64cxwqDIqckUaisT3VCst11RcnO5iRHm6meNIwj0BALLmWplyi7beKrOlqKfuZtCLbiAPywGfCNg8LOTt4iMD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 2023-12-25 at 10:08 +0800, chenglulu wrote: >=20 > =E5=9C=A8 2023/12/24 =E4=B8=8B=E5=8D=888:59, Xi Ruoyao =E5=86=99=E9=81=93= : > > On Sat, 2023-12-23 at 18:47 +0800, Xi Ruoyao wrote: > > > On Sat, 2023-12-23 at 18:44 +0800, Xi Ruoyao wrote: > > > > On Sat, 2023-12-23 at 10:29 +0800, chenglulu wrote: > > > > > > The performance drop has nothing to do with this patch. I > > > > > > found that the h264 performance compiled > > > > > > by r14-6787 compared to r14-6421 dropped by 6.4%. > > > > Then I guess we should create a bug report... > > > >=20 > > > > > =C2=A0=C2=A0But there is a problem. My regression test has the fo= llowing > > > > > two fail items.(based on r14-6787) > > > > > +FAIL: gcc.dg/cpp/_Pragma3.c (test for excess errors) > > > I guess this is https://gcc.gnu.org/PR28123. > > >=20 > > > > > +FAIL: gcc.dg/pr86617.c scan-rtl-dump-times final "mem/v" 6 > > > I'll take a look on this.=C2=A0 Maybe it will show up with Binutils > > > trunk (I > > > just realized I tested this patch with Binutils 2.41, and it's not > > > sufficient to really test the change). > > I cannot reproduce the issue on a Gentoo dev machine with Binutils > > 2.41.50.20231218 and the patch on top of r14-6819.=C2=A0 And in my manu= al > > testing (for ruling out the difference caused by default PIE and > > SSP) > > the test also passes: > >=20 > > xry111@nanmen2 ~/git-repos/gcc-build $ /home/xry111/git-repos/gcc- > > build/gcc/xgcc -B/home/xry111/git-repos/gcc-build/gcc/ > > /home/xry111/git- > > repos/gcc/gcc/testsuite/gcc.dg/pr86617.c -fdiagnostics-plain-output > > -Os > > -fdump-rtl-final -ffat-lto-objects -S -o pr86617.s -fno-stack- > > protector > > -fno-pie && grep -c mem/v pr86617.c.348r.final > > 6 > >=20 > > Could you recheck with latest GCC master? > Ok, I'll test again with the latest code. Per https://gcc.gnu.org/pipermail/gcc-patches/2023-December/641407.html I need to and "&& true" into the split condition. I'll test it and send V2. --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University