From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93551 invoked by alias); 25 Aug 2017 16:48:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 70815 invoked by uid 89); 25 Aug 2017 16:48:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1257 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Aug 2017 16:48:40 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C2E3FC04B94A; Fri, 25 Aug 2017 16:48:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C2E3FC04B94A Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law@redhat.com Received: from localhost.localdomain (ovpn-117-47.phx2.redhat.com [10.3.117.47]) by smtp.corp.redhat.com (Postfix) with ESMTP id 831677F399; Fri, 25 Aug 2017 16:48:37 +0000 (UTC) Subject: Re: [77/77] Add a complex_mode class To: gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org References: <8760ewohsv.fsf@linaro.org> <87wp7caeqq.fsf@linaro.org> From: Jeff Law Message-ID: <94bad2e4-e595-fc5d-76db-8c420cf7f8fd@redhat.com> Date: Fri, 25 Aug 2017 17:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <87wp7caeqq.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg01518.txt.bz2 On 07/13/2017 03:05 AM, Richard Sandiford wrote: > This patch adds another machine_mode wrapper for modes that are > known to be COMPLEX_MODE_P. There aren't yet many places that make > use of it, but that might change in future. > > 2017-07-13 Richard Sandiford > Alan Hayward > David Sherwood > > gcc/ > * coretypes.h (complex_mode): New type. > * gdbhooks.py (build_pretty_printer): Handle it. > * machmode.h (complex_mode): New class. > (complex_mode::includes_p): New function. > (is_complex_int_mode): Likewise. > (is_complex_float_mode): Likewise. > * genmodes.c (get_mode_class): Handle complex mode classes. > * function.c (expand_function_end): Use is_complex_int_mode. > > gcc/go/ > * go-lang.c (go_langhook_type_for_mode): Use is_complex_float_mode. OK. I think that's the whole set. I want to go back and review the API issue raised early in the kit, but otherwise I don't see any concerns. Obviously the trunk has continued to evolve since the kit was posted. It's safe to assume there'll be minor updates as a result -- I trust your judgment on addressing any such fallout without going through another review cycle. Jeff