From: Mike Stump <mikestump@comcast.net>
To: Janis Johnson <janisjo@codesourcery.com>
Cc: Richard Earnshaw <rearnsha@arm.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [testsuite] skip ARM neon-fp16 tests for other -mcpu values
Date: Sun, 26 Jun 2011 04:29:00 -0000 [thread overview]
Message-ID: <9579E79E-0CFD-4B57-ADFB-5510EE95C872@comcast.net> (raw)
In-Reply-To: <4DF954EE.30802@codesourcery.com>
On Jun 15, 2011, at 5:57 PM, Janis Johnson wrote:
> The bug was in my attempt to run the tests with other -mfpu values, so
> I'm very glad you caught that. I tried again, getting rid of the neon
> requirement along the way, and found a way to run the VFP fp16 tests
> with any of the fp16 values that Joseph listed.
>
> This patch renames *arm_neon_fp16* to *arm_fp16* and skips tests if the
> multilib does not support arm32, includes -mfpu that is not fp16, or
> includes -mfloat-abi=soft. If the multilib uses -mfpu= with an fp16
> value then that is used, otherwise -mfpu=vfpv4 is used. Added flags
> include -mfloat-abi=softfp in case the default is "soft".
> OK for trunk, and for 4.6 a few days later?
Ok. Ok for 4.6. For 4.6, as also please ensure that the RMs don't have the branch locked down.
General comment, I'm happy to have the front-end, target and library maintainers review and approve the normal additions to the .exp files to support testing their bits.
next prev parent reply other threads:[~2011-06-25 23:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 1:29 Janis Johnson
2011-06-08 2:05 ` Mike Stump
2011-06-08 2:14 ` Janis Johnson
2011-06-08 10:24 ` Joseph S. Myers
2011-06-08 16:16 ` Janis Johnson
2011-06-10 0:04 ` Janis Johnson
2011-06-15 13:07 ` Richard Earnshaw
2011-06-16 6:28 ` Janis Johnson
2011-06-26 4:29 ` Mike Stump [this message]
2011-06-27 5:08 ` Janis Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9579E79E-0CFD-4B57-ADFB-5510EE95C872@comcast.net \
--to=mikestump@comcast.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=janisjo@codesourcery.com \
--cc=joseph@codesourcery.com \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).