From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32299 invoked by alias); 25 Jun 2011 23:56:42 -0000 Received: (qmail 32291 invoked by uid 22791); 25 Jun 2011 23:56:41 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,TW_MF,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from qmta09.emeryville.ca.mail.comcast.net (HELO qmta09.emeryville.ca.mail.comcast.net) (76.96.30.96) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 25 Jun 2011 23:56:28 +0000 Received: from omta18.emeryville.ca.mail.comcast.net ([76.96.30.74]) by qmta09.emeryville.ca.mail.comcast.net with comcast id 0Pjq1h0011bwxycA9PwSgh; Sat, 25 Jun 2011 23:56:26 +0000 Received: from up.mrs.kithrup.com ([24.4.193.8]) by omta18.emeryville.ca.mail.comcast.net with comcast id 0Px31h00v0BKwT48ePx5K5; Sat, 25 Jun 2011 23:57:08 +0000 Subject: Re: [testsuite] skip ARM neon-fp16 tests for other -mcpu values Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Mike Stump In-Reply-To: <4DF954EE.30802@codesourcery.com> Date: Sun, 26 Jun 2011 04:29:00 -0000 Cc: Richard Earnshaw , "Joseph S. Myers" , "gcc-patches@gcc.gnu.org" Content-Transfer-Encoding: quoted-printable Message-Id: <9579E79E-0CFD-4B57-ADFB-5510EE95C872@comcast.net> References: <4DEECB2D.9000403@codesourcery.com> <4DF15AAD.6090109@codesourcery.com> <4DF8AB4D.9040604@arm.com> <4DF954EE.30802@codesourcery.com> To: Janis Johnson X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01928.txt.bz2 On Jun 15, 2011, at 5:57 PM, Janis Johnson wrote: > The bug was in my attempt to run the tests with other -mfpu values, so > I'm very glad you caught that. I tried again, getting rid of the neon > requirement along the way, and found a way to run the VFP fp16 tests > with any of the fp16 values that Joseph listed. >=20 > This patch renames *arm_neon_fp16* to *arm_fp16* and skips tests if the > multilib does not support arm32, includes -mfpu that is not fp16, or > includes -mfloat-abi=3Dsoft. If the multilib uses -mfpu=3D with an fp16 > value then that is used, otherwise -mfpu=3Dvfpv4 is used. Added flags > include -mfloat-abi=3Dsoftfp in case the default is "soft". > OK for trunk, and for 4.6 a few days later? Ok. Ok for 4.6. For 4.6, as also please ensure that the RMs don't have th= e branch locked down. General comment, I'm happy to have the front-end, target and library mainta= iners review and approve the normal additions to the .exp files to support = testing their bits.