From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70665 invoked by alias); 14 Jan 2020 09:04:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 70657 invoked by uid 89); 14 Jan 2020 09:04:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,HTML_MESSAGE,KAM_LOTSOFHASH,KAM_SHORT,SPF_PASS autolearn=no version=3.3.1 spammy=worldwide, Moreover, sk:gcc-10-, sk:gcc10 X-HELO: smtp.ispras.ru Received: from winnie.ispras.ru (HELO smtp.ispras.ru) (83.149.199.91) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Jan 2020 09:04:08 +0000 Received: from [10.10.3.54] (utre4ko.intra.ispras.ru [10.10.3.54]) by smtp.ispras.ru (Postfix) with ESMTP id 56B8D203C1; Tue, 14 Jan 2020 12:04:04 +0300 (MSK) Subject: Re: [PATCH] contrib: git descr/undescr aliases To: Jakub Jelinek , "Richard Earnshaw (lists)" Cc: "gcc-patches@gcc.gnu.org" References: <54834f12-32b1-492f-fb9e-b2c74df23167@arm.com> <95dfd77a-3361-545e-8b86-01078304ae29@arm.com> <20200113113740.GQ10088@tucnak> From: Roman Zhuykov Message-ID: <9588e460-45d8-5187-864f-c3719e635218@ispras.ru> Date: Tue, 14 Jan 2020 10:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200113113740.GQ10088@tucnak> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00773.txt.bz2 13.01.2020 14:37, Jakub Jelinek wrote: > The following patch adds the descr/undescr aliases (for converting to > monotonically increasing revision numbers and back) there next to svn-rev. > Both have been changed to use basepoints/gcc-* tags instead of > branchpoints/gcc-*, the first one now supports --full option, where > $ git descr origin/master > r10-5835 > $ git descr --full origin/master > r10-5835-g1fc15853e301337b46d7f1234966a6244ef0cdab > where the second form is what is used in gcc-cvs mail bodies and bugzilla > comments from commits, the former what is used in the subjects. > The second alias has been tweaked to use git config --get gcc-config.upstream > with fallback to origin to be able to deal with non-default upstream > configurations. > It was a bit confusing to see "git descr" here in posted patch and "git gcc-descr" actually committed. Moreover "git gcc-descr" doesn't work for me with old git: ~$ git --version git version 2.7.4 ~$ git clone git://gcc.gnu.org/git/gcc test <...> ~$ cd test/ ~/test$ ~/test$ ./contrib/gcc-git-customization.sh <...> ~/test$ git describe --all --abbrev=40 --match 'basepoints/gcc-[0-9]*' origin/master basepoints/gcc-10-5938-gedabbec31e3bfc9a9757f80c8610706ed00e5a1a ~/test$ git gcc-descr origin/master ~/test$ So, locally I have to fix alias removing "tags/" part in commands like "sed -n 's,^tags/basepoints/gcc-,r,p'". With new git v2.24.0 alias works fine. Investigation shows it was changed inside git by commit https://github.com/git/git/commit/1bba00130a1a0332ec0ad2f878a09ca9b2b18ee2 two years ago. So, only git v2.16.2, v2.17.0 or newer versions correctly run current alias. Not sure we want to bother about supporting older versions. -- Roman PS. We at ISPRAS see that for ~28 hours (11 Jan 2020, 18:00 UTC - 12 Jan 2020, 22:00 UTC) our servers haven't received any gcc mailing list letters, but they are available at https://gcc.gnu.org/ml/ archives (totally 6 mails on gcc@ and 16 on gcc-patches@ were lost). Looking also at obviously corruptedhttps://gcc.gnu.org/ml/gcc-patches/2020-01/msg00674.html it is reasonable to assume that it was some worldwide issue because of high "git clone" server load, and I wonder not to see any discussion here.