From: pinskia@gmail.com
To: Steven Bosscher <stevenb.gcc@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Andi Kleen <ak@linux.intel.com>,
David Malcolm <dmalcolm@redhat.com>
Subject: Re: [PATCH] Force rtl templates to be inlined
Date: Tue, 02 Sep 2014 08:42:00 -0000 [thread overview]
Message-ID: <958F9B7B-E80E-48F1-843F-C6F1ECE9A81E@gmail.com> (raw)
In-Reply-To: <CABu31nO=TQKLatDFRvJBZo_JfCMstSzxm=_PGiig97fQqkHUxQ@mail.gmail.com>
> On Sep 2, 2014, at 1:36 AM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
>
>> On Tue, Sep 2, 2014 at 9:22 AM, Andrew Pinski wrote:
>>> On Tue, Sep 2, 2014 at 12:20 AM, Andi Kleen wrote:
>>>
>>>> there have been bugs in the past in the area of always_inline too.
>>>
>>> You're arguing for my patch. It would find those bugs.
>>
>>
>> No I am arguing against it since the older versions of GCC we cannot change.
>
> Should such bugs turn up, we can account for them in ansidecl.h.
>
> I think Andi's patch should go in.
I does hurt debug ability with older compilers too. So if we need to figure out why stage is being miscompiled it is harder to figure how to work around it.
I think stage should really be -O0 even with respect of inline. I think we should never force inline inside gcc even at -O0 as it is just a hack (we know it as we added the attribute in the first place).
Thanks,
Andrew
>
> Ciao!
> Steven
next prev parent reply other threads:[~2014-09-02 8:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 7:05 Andi Kleen
2014-09-02 7:09 ` Andrew Pinski
2014-09-02 7:20 ` Andi Kleen
2014-09-02 7:22 ` Andrew Pinski
2014-09-02 8:37 ` Steven Bosscher
2014-09-02 8:42 ` pinskia [this message]
2014-09-02 8:43 ` Richard Biener
2014-09-02 16:52 ` Andi Kleen
2014-09-03 9:50 ` Richard Biener
2014-09-04 3:58 ` Andi Kleen
2014-09-04 13:02 ` Richard Biener
2014-09-04 18:52 ` Jan Hubicka
2014-09-03 9:52 ` Richard Biener
2014-09-02 14:59 ` David Malcolm
2014-09-02 17:50 ` Andi Kleen
2014-09-04 20:07 ` [PATCH] Add XINSN macro and use it within NEXT_INSN/PREV_INSN (was Re: [PATCH] Force rtl templates to be inlined) David Malcolm
2014-09-04 20:46 ` Jakub Jelinek
2014-09-04 21:23 ` David Malcolm
2014-09-05 18:41 ` Jeff Law
2014-09-05 18:32 ` Jeff Law
2014-09-05 18:45 ` Jeff Law
2014-09-05 19:05 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=958F9B7B-E80E-48F1-843F-C6F1ECE9A81E@gmail.com \
--to=pinskia@gmail.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=stevenb.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).