From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 8FE26385783D for ; Mon, 21 Sep 2020 23:15:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8FE26385783D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-320-zTnwmGKnNLG0GIus5AJoRw-1; Mon, 21 Sep 2020 19:15:02 -0400 X-MC-Unique: zTnwmGKnNLG0GIus5AJoRw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 545941074654; Mon, 21 Sep 2020 23:15:01 +0000 (UTC) Received: from ovpn-112-230.phx2.redhat.com (ovpn-112-230.phx2.redhat.com [10.3.112.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7629155781; Mon, 21 Sep 2020 23:15:00 +0000 (UTC) Message-ID: <9597b8e20d5b50ad4e501d4506e578107474d55f.camel@redhat.com> Subject: Re: New modref/ipa_modref optimization passes From: David Malcolm To: Jan Hubicka Cc: David =?UTF-8?Q?=C4=8Cepel=C3=ADk?= , gcc-patches@gcc.gnu.org Date: Mon, 21 Sep 2020 19:14:59 -0400 In-Reply-To: <20200920173043.GD6758@kam.mff.cuni.cz> References: <157394261677.27454.2367573047582814412@a285.localdomain> <20200919223255.GA69342@kam.mff.cuni.cz> <20200920173043.GD6758@kam.mff.cuni.cz> User-Agent: Evolution 3.32.5 (3.32.5-1.fc30) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2020 23:15:07 -0000 On Sun, 2020-09-20 at 19:30 +0200, Jan Hubicka wrote: > > On Sun, 2020-09-20 at 00:32 +0200, Jan Hubicka wrote: > > > Hi, > > > this is cleaned up version of the patch. I removed unfinished > > > bits, > > > fixed > > > propagation, cleaned it up and fixed fallout. > > > > [...] > > > > > While there are several areas for improvements but I think it is > > > not > > > in shape > > > for mainline and rest can be dealt with incrementally. > > > > FWIW I think you typoed: > > "not in shape for mainline" > > when you meant: > > "now in shape for mainline" > > given... > > Yep, sorry for that :) I've started seeing crashes in the jit testsuite even with trivial inputs, which are happening at pass_modref::~pass_modref at: 772 ggc_delete (summaries); on the first in-process iteration of the code, with: (gdb) p summaries $3 = (fast_function_summary *) 0x0 I'm still investigating (but may have to call halt for the night), but this could be an underlying issue with the new passes; the jit testsuite runs with the equivalent of: --param=ggc-min-expand=0 --param=ggc-min-heapsize=0 throughout to shake out GC issues (to do a full collection at each GC opportunity). Was this code tested with the jit? Do you see issues in cc1 if you set those params? Anyone else seeing "random" crashes? Thanks Dave