From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by sourceware.org (Postfix) with ESMTPS id 37B083858D33 for ; Fri, 10 Nov 2023 03:49:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 37B083858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 37B083858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699588171; cv=none; b=suNNMO0zfG1mPikpJKL8i3GColiMx0rUcOp+11p6CDA4falVyFmcRSF3o9x225skueO0woBVzjLa13A8NfQYEt1tO7BhFCN8miT/28mPSKiMTawn3SoiBKM5JAjd8saADTzgJ4BBvZk1dLrZjAXX6Acdt3mJ0C4x7W3ztGHDp4I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699588171; c=relaxed/simple; bh=VG0GFtWo/6mFU1UTJNfXwtP6Y9+s/2e/+PeZ9ZQXiWk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=fLcXBlpIhIjhUuhEzkJXegO7yseVgI53H6o73hmPim+llLya9lLD2JipjxnHX1PkQ6PV9emwRKpvDpR+s/Uido1pyXxJg8F51MkFD/VW+FBsjnT1bBK3UD7HtWvienELvCk7IW6JrFl4jy0IRjDiXaZST8CG8H6CXiYGx8J90nU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-7a93b7fedb8so55774039f.3 for ; Thu, 09 Nov 2023 19:49:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699588169; x=1700192969; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VTFUfIchZIUYd4K4NOLrUFa+eXmMnG5MrbzGGJ82u18=; b=OODKOj0FN6aIWYdIIth6FgGEE9C2nRn+S1mS5o5OQvzA28I7WqxsUaJr0hqbkUrR+M lg0W+DFDD6HUzcY6WAEg9RKvDe9+sn5SaOKE973kFXHpEE5gKkYGgdgOrkN+/pUlDt/W 41F40SpNwMzbYoSKkpTvxnsxaO9OVDEn7OEzUd+R4Zx1HwIzFcbTOUpYYwPF3G7OXUe2 nd4YcbrRPdSI0N4PhnK9bS3X4kVUK87lgScM3KHHYcItgrFyjxKlJzurXh6dk563x042 IP5lg0VcGRrJZKu37AkCZ5vaPfdL8ZqcApb4o88suki98dxMBy6xIpETk85o7kF9iVSc /wGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699588169; x=1700192969; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VTFUfIchZIUYd4K4NOLrUFa+eXmMnG5MrbzGGJ82u18=; b=Ce5nPiJG8KoFcDp5HC0//lQF7qhnebV2w+Q0eJzy9w/4OhD4O47OHPp4wTdo88e6f8 jMkgyExGTDslb3LQT2jXpKzsw6U9xkgcWkrXjJcmoz4SYTPb3xdjBQCa8l/OhzdAiE2z Kun6Sufv02MfUkoDGavX5SVDpZ3XCA7ba4McEtqaoa2a8duCzMlFACSPIicv9w6AmH9g sWxoKJXiTQciC5vvx0lcRxTDDN1y5xIVxxVAh6PyCMgDe3wj2/1qPXLSbWNhfhab26Mi fGuVmvW4lMMTxXuhdNzA0EXQzg/zxUPEVTjzmOU/NHiErhfEP7x03FE5bN7Mau0o+urk eiRg== X-Gm-Message-State: AOJu0YwW2aDOkw5AUe60mn7i325Uqoc/evDgGd0Ub3eEBuuZc/tv0nai OQMTe89qj+BgqsFSTo/euzg= X-Google-Smtp-Source: AGHT+IEIMNV+ezAPuxdYzg2u/Ay4LApyaqjLYp3ZIRdy4ceNk7JGhQglpMGQHeRPLetW0m2jJJY44w== X-Received: by 2002:a5e:9907:0:b0:7a2:dee5:84b6 with SMTP id t7-20020a5e9907000000b007a2dee584b6mr3433207ioj.21.1699588169376; Thu, 09 Nov 2023 19:49:29 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id o1-20020a056602124100b007a669ac1ef4sm4411847iou.40.2023.11.09.19.49.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Nov 2023 19:49:28 -0800 (PST) Message-ID: <959b4cfd-621f-4785-b08e-21e9300ef6c9@gmail.com> Date: Thu, 9 Nov 2023 20:49:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: PING^1 [PATCH v3] sched: Change no_real_insns_p to no_real_nondebug_insns_p [PR108273] Content-Language: en-US To: Alexander Monakov , Maxim Kuvyrkov Cc: "Kewen.Lin" , GCC Patches , Richard Guenther , Richard Sandiford , Jeff Law , Vladimir Makarov , zhroma@ispras.ru, Andrey Belevantsev , Segher Boessenkool , Peter Bergner , Michael Meissner References: <85b4098e-a72f-d013-ff17-8097971f71ba@linux.ibm.com> <09FEFDAE-698B-4B06-A896-8088B9B31539@linaro.org> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/9/23 10:40, Alexander Monakov wrote: > > On Thu, 9 Nov 2023, Maxim Kuvyrkov wrote: > >> Hi Kewen, >> >> Below are my comments. I don't want to override Alexander's review, and if >> the patch looks good to him, it's fine to ignore my concerns. >> >> My main concern is that this adds a new entity -- forceful skipping of >> DEBUG_INSN-only basic blocks -- to the scheduler for a somewhat minor change >> in behavior. Unlike NOTEs and LABELs, DEBUG_INSNs are INSNS, and there is >> already quite a bit of logic in the scheduler to skip them _as part of normal >> operation_. > > I agree with the concern. I hoped that solving the problem by skipping the BB > like the (bit-rotted) debug code needs to would be a minor surgery. As things > look now, it may be better to remove the non-working sched_block debug counter > entirely and implement a good solution for the problem at hand. I wouldn't lose sleep over this -- if removing a debug counter from this code simplifies the implementation, that's fine with me. I believe they were all added when significant work in the scheduler was more common. > > Can we teach haifa-sched to emit RTX NOTEs with hashes of DFA states on BB > boundaries with -fcompare-debug is enabled? It should make the problem > readily detectable by -fcompare-debug even when scheduling did not diverge. I like it. jeff