From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 62E813858D28 for ; Mon, 8 Apr 2024 21:30:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 62E813858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 62E813858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712611845; cv=none; b=fnd+09sU3aMv+7KHqI76PG7a6G7bBSh9JLz67TMSaaO1i6SOERNl9HzsZd0GSIVAivJ1um2CPf4ogmLT2xgJThngsdwQTnf3JVOT4Ig+dyfnvOoxbrMoBC+6nvXLBIlMVJPBVeQlLMw24JqAS0SRp5Aj8Tskz78ib2lRkEMWVi8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712611845; c=relaxed/simple; bh=nXmzaxtBaDhZF/72fiLzH9QKorTJ9pCrNnXbStAjYQE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=UXTbvcUQmeUpM9gkK8KoaQmfg17K8a7l0hTgSh2hT4YrD+5H28+pDlaoY+feyvH/EDdTVl41nKO4Wc9k3TPWamZe7/0wnwrK4l++dCyxx8i46O81c/mmZV9MbYg0Jd/4QLERVT7udAjKo2HB2grFacIz2XlsCpDuVohlC62azck= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712611843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=25jIt0NJUJmHRMmOnq5pcaWgOLY48objt814ZXIj1K8=; b=DbmbI9zXdy1TYS/bmoMGxvZjG5DLu3emExcLVIhawnt+67hBatpCsl85h+qWbhjcPTnxjY mpQzgiISzD0o6PPZSmFvl2dJ6RQBWrat0Qvd2CH1y6HsbIBEZ1oFXKxs5YxtNvgw8ao/+m QVQn2h5Sxk/akYJ4iU6NnmDjPYvA0nw= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-9-T6NBowMUNVi26Imo-rIrmQ-1; Mon, 08 Apr 2024 17:30:41 -0400 X-MC-Unique: T6NBowMUNVi26Imo-rIrmQ-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-69945716e94so36034966d6.2 for ; Mon, 08 Apr 2024 14:30:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712611841; x=1713216641; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=25jIt0NJUJmHRMmOnq5pcaWgOLY48objt814ZXIj1K8=; b=Rz+6GDtwc0dP9TGslWwy5nOR//4xfU58LiJ6kOz3VkOILz9Nkd0B6aa6DFJYKgptk8 PkVKymm3C6GFXMg3NU9KgBrxvKrkNXSKQ/DAIQ+RDpIkPbHaCnPGkhrDJy1ihfaR+RQr pyL7XyXbw6FFD830dj1OpWy8VE3qVEFJQH56cwxDMGr+shcBQ+y6Azo1s2LruG0eV9jZ /AW7kdDde1S78bTuCGzLT9o21CXdErNH8pejT8HYx3VjZxGYCNdmrha/I3wyDZTkUVGY EnhOr5mi44x4t7ItCKLxj+3mu1GR4kdqZUb2ZmrO3mIuRCRoSspL9RRVxe2py74EV4mx Wj9g== X-Forwarded-Encrypted: i=1; AJvYcCVYvNkdTIATJ8bmAWxBOXdLMqdwsYVjLULSlQlRgHRtGOTXTMelvqmFQwJs3pCYMleXp84fFiYoSRO0yTFI1QGq36OE6utAEg== X-Gm-Message-State: AOJu0YzqEeQtuG/UBWNNVpyJ0Sqhiq5dxM+3X3aHiCgs3PDUPqs8AE5E FLhagubyeci8OkvfVi3AnBND+voC9S1yz8hlYRmSUVuldo/fsA0M2YvgGKq5CMKKmOv+juSeH51 z5lJmtf7fSyC86uZ2d9+qjSbHhkUSj5aY5BtXUQQOg2hYGBQqB+nOAyc= X-Received: by 2002:a05:6214:230e:b0:69b:147e:84e8 with SMTP id gc14-20020a056214230e00b0069b147e84e8mr6150411qvb.35.1712611841074; Mon, 08 Apr 2024 14:30:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFkhdLSvfj3LiRy55RyUnUWpmO/gsnWqRiViPvfGyA3+f3WgJoR0i2QHrBvQRGcHy/AW8JCFw== X-Received: by 2002:a05:6214:230e:b0:69b:147e:84e8 with SMTP id gc14-20020a056214230e00b0069b147e84e8mr6150394qvb.35.1712611840790; Mon, 08 Apr 2024 14:30:40 -0700 (PDT) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id jp9-20020ad45f89000000b00699057a3a54sm3472409qvb.39.2024.04.08.14.30.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 14:30:40 -0700 (PDT) Message-ID: <95a65b47-8154-4586-91bc-6478d5eb55b2@redhat.com> Date: Mon, 8 Apr 2024 17:30:39 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [committed] c++: Fix ICE with weird copy assignment operator [PR114572] To: Jakub Jelinek , gcc-patches@gcc.gnu.org Cc: Tobias Burnus References: From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/5/24 03:35, Jakub Jelinek wrote: > Hi! > > While ctors/dtors don't return anything (undeclared void or this pointer > on arm) and copy assignment operators normally return a reference to *this, > it isn't invalid to return uselessly some class object which might need > destructing, but the OpenMP clause handling code wasn't expecting that. > > The following patch fixes that. > > Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk so > far. > > 2024-04-05 Jakub Jelinek > > PR c++/114572 > * cp-gimplify.cc (cxx_omp_clause_apply_fn): Call build_cplus_new > on build_call_a result if it has class type. > > * testsuite/libgomp.c++/pr114572.C: New test. > > --- gcc/cp/cp-gimplify.cc.jj 2024-04-02 13:07:58.540385210 +0200 > +++ gcc/cp/cp-gimplify.cc 2024-04-04 16:41:50.781008370 +0200 > @@ -2480,6 +2480,8 @@ cxx_omp_clause_apply_fn (tree fn, tree a > TREE_PURPOSE (parm), fn, > i - is_method, tf_warning_or_error); > t = build_call_a (fn, i, argarray); > + if (MAYBE_CLASS_TYPE_P (TREE_TYPE (t))) > + t = build_cplus_new (TREE_TYPE (t), t, tf_warning_or_error); Maybe use build_cxx_call instead of build_call_a? Jason