From: "Martin Liška" <mliska@suse.cz>
To: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>,
gcc-patches@gcc.gnu.org
Cc: Christophe Lyon <christophe.lyon@linaro.org>
Subject: Re: [PATCH] arm: fix option quoting in error messages.
Date: Mon, 7 Mar 2022 14:17:15 +0100 [thread overview]
Message-ID: <96323905-2c31-b877-8429-8f0566c0beaa@suse.cz> (raw)
In-Reply-To: <fe3c673f-54b3-0ef4-98c9-0cd9632ae0ec@foss.arm.com>
[-- Attachment #1: Type: text/plain, Size: 257 bytes --]
On 3/7/22 14:14, Richard Earnshaw wrote:
> Wasn't the complaint also that there should be a space in the text between the 'and"' and the '"%<' on the subsequent line?
Yeah, I overlooked that.
I'm going to push the following patch.
Cheers,
Martin
[-- Attachment #2: 0001-arm-add-missing-space-to-error.patch --]
[-- Type: text/x-patch, Size: 992 bytes --]
From b1d8198e7df616ea80cb648a2c831e2c21f4319f Mon Sep 17 00:00:00 2001
From: Martin Liska <mliska@suse.cz>
Date: Mon, 7 Mar 2022 14:16:21 +0100
Subject: [PATCH] arm: add missing space to error.
PR target/104794
gcc/ChangeLog:
* config/arm/arm.cc (arm_option_override_internal): Add missing
space.
---
gcc/config/arm/arm.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/config/arm/arm.cc b/gcc/config/arm/arm.cc
index 4bf1ef0517d..14b6c804455 100644
--- a/gcc/config/arm/arm.cc
+++ b/gcc/config/arm/arm.cc
@@ -3185,7 +3185,7 @@ arm_option_override_internal (struct gcc_options *opts,
if (arm_stack_protector_guard == SSP_GLOBAL
&& opts->x_arm_stack_protector_guard_offset_str)
{
- error ("incompatible options %<-mstack-protector-guard=global%> and"
+ error ("incompatible options %<-mstack-protector-guard=global%> and "
"%<-mstack-protector-guard-offset=%s%>",
arm_stack_protector_guard_offset_str);
}
--
2.35.1
prev parent reply other threads:[~2022-03-07 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 10:27 Martin Liška
2022-03-07 10:37 ` Kyrylo Tkachov
2022-03-07 13:14 ` Richard Earnshaw
2022-03-07 13:17 ` Martin Liška [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96323905-2c31-b877-8429-8f0566c0beaa@suse.cz \
--to=mliska@suse.cz \
--cc=Richard.Earnshaw@foss.arm.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).