* [PATCH] testsuite, Darwin : Do not claim 'GAS' for cctools assembler.
@ 2021-08-19 20:02 Iain Sandoe
2021-08-26 19:04 ` Mike Stump
0 siblings, 1 reply; 2+ messages in thread
From: Iain Sandoe @ 2021-08-19 20:02 UTC (permalink / raw)
To: GCC Patches
Hi,
Although the cctools assembler is based of GNU GAS, it is from a
very old version (1.38) which does not support many of the features
that the target supports test is expecting***.
tested on i686 and x86_64 darwin versions using the cctools as.
OK for master?
thanks
Iain
*** I guess we could be more clever and parse the output to find a version
and then alter the supports condition to “gas NN”, but I don’t currently
have cycles to implement that.
gcc/testsuite/ChangeLog:
* lib/target-supports.exp: Exclude cctools assembler based on
GAS 1.38.
---
gcc/testsuite/lib/target-supports.exp | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 44465b14b06..ac9daee26b8 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -9454,7 +9454,14 @@ proc check_effective_target_gas { } {
set status [remote_exec host "$gcc_as" "-v /dev/null"]
set as_output [lindex $status 1]
if { [ string first "GNU" $as_output ] >= 0 } {
- set use_gas_saved 1
+ # Some Darwin versions have an assembler which is based on an old
+ # version of GAS (and reports GNU assembler in its -v output) but
+ # but doesn't support many of the modern GAS features.
+ if { [ string first "cctools" $as_output ] >= 0 } {
+ set use_gas_saved 0
+ } else {
+ set use_gas_saved 1
+ }
} else {
set use_gas_saved 0
}
--
2.24.3 (Apple Git-128)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] testsuite, Darwin : Do not claim 'GAS' for cctools assembler.
2021-08-19 20:02 [PATCH] testsuite, Darwin : Do not claim 'GAS' for cctools assembler Iain Sandoe
@ 2021-08-26 19:04 ` Mike Stump
0 siblings, 0 replies; 2+ messages in thread
From: Mike Stump @ 2021-08-26 19:04 UTC (permalink / raw)
To: Iain Sandoe; +Cc: GCC Patches
On Aug 19, 2021, at 1:02 PM, Iain Sandoe <iain@sandoe.co.uk> wrote:
>
> Although the cctools assembler is based of GNU GAS, it is from a
> very old version (1.38) which does not support many of the features
> that the target supports test is expecting***.
>
> tested on i686 and x86_64 darwin versions using the cctools as.
> OK for master?
Ok.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-26 19:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-19 20:02 [PATCH] testsuite, Darwin : Do not claim 'GAS' for cctools assembler Iain Sandoe
2021-08-26 19:04 ` Mike Stump
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).