From: Jeff Law <jeffreyalaw@gmail.com>
To: Richard Sandiford <richard.sandiford@arm.com>,
jlaw@ventanamicro.com, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 6/6] rtl-ssa: Handle call clobbers in more places
Date: Tue, 24 Oct 2023 11:37:53 -0600 [thread overview]
Message-ID: <970415cf-95c9-4df3-846c-fa01a3e0fe21@gmail.com> (raw)
In-Reply-To: <20231024105006.3337671-7-richard.sandiford@arm.com>
On 10/24/23 04:50, Richard Sandiford wrote:
> In order to save (a lot of) memory, RTL-SSA avoids creating
> individual clobber records for every call-clobbered register.
> It instead maintains a list & splay tree of calls in an EBB,
> grouped by ABI.
>
> This patch takes these call clobbers into account in a couple
> more routines. I don't think this will have any effect on
> existing users, since it's only necessary for hard registers.
>
> gcc/
> * rtl-ssa/access-utils.h (next_call_clobbers): New function.
> (is_single_dominating_def, remains_available_on_exit): Replace with...
> * rtl-ssa/functions.h (function_info::is_single_dominating_def)
> (function_info::remains_available_on_exit): ...these new member
> functions.
> (function_info::m_clobbered_by_calls): New member variable.
> * rtl-ssa/functions.cc (function_info::function_info): Explicitly
> initialize m_clobbered_by_calls.
> * rtl-ssa/insns.cc (function_info::record_call_clobbers): Update
> m_clobbered_by_calls for each call-clobber note.
> * rtl-ssa/member-fns.inl (function_info::is_single_dominating_def):
> New function. Check for call clobbers.
> * rtl-ssa/accesses.cc (function_info::remains_available_on_exit):
> Likewise.
OK
jeff
> ---
prev parent reply other threads:[~2023-10-24 17:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 10:50 [PATCH 0/6] rtl-ssa: Various fixes needed for the late-combine pass Richard Sandiford
2023-10-24 10:50 ` [PATCH 1/6] rtl-ssa: Ensure global registers are live on exit Richard Sandiford
2023-10-24 17:21 ` Jeff Law
2023-10-24 10:50 ` [PATCH 2/6] rtl-ssa: Create REG_UNUSED notes after all pending changes Richard Sandiford
2023-10-24 17:22 ` Jeff Law
2023-10-24 10:50 ` [PATCH 3/6] rtl-ssa: Fix ICE when deleting memory clobbers Richard Sandiford
2023-10-24 17:24 ` Jeff Law
2023-10-24 10:50 ` [PATCH 4/6] rtl-ssa: Handle artifical uses of deleted defs Richard Sandiford
2023-10-24 17:26 ` Jeff Law
2023-10-24 10:50 ` [PATCH 5/6] rtl-ssa: Calculate dominance frontiers for the exit block Richard Sandiford
2023-10-24 17:28 ` Jeff Law
2023-10-24 10:50 ` [PATCH 6/6] rtl-ssa: Handle call clobbers in more places Richard Sandiford
2023-10-24 17:37 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=970415cf-95c9-4df3-846c-fa01a3e0fe21@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jlaw@ventanamicro.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).