From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by sourceware.org (Postfix) with ESMTPS id E0AE93858CDB for ; Tue, 24 Oct 2023 17:38:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E0AE93858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E0AE93858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698169091; cv=none; b=GCGeyPNGu1ZcNzdwaKYE7mDGAb0bIr0VbY7JdthChsYGKFN7K/1QmOPqTnSmllStYg86hLsmqx+XetnCfZwZLzVYLTenhOnkitvrVGFAI9ZF2cIBiwgSWLD45ismoZGUu0qWS4kmWTB7xjdnmtmBo4GuyuVHzC9Ydy5Z/z6FTCw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698169091; c=relaxed/simple; bh=5PLYsOuw9RMPytTZwolfXAvNFfHdGzN7LeHFjDFCxiY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=SrEDt6yVpqFhgWJgkP0dj+ttLceATWoFNHOypZkXBYMpzYZm1rfRZjCYmuczjwKvYcSJ7vv52wDYs38L/uTC7Dv0cZ5Ne3eMoveuXwDjco9TYk9vkfwLEcXvC/OCeKrYNrHwNPCoqov/fFNMpkfoezkikioskg/JgWwUOAoanRI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-27d18475ed4so3590624a91.0 for ; Tue, 24 Oct 2023 10:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698169080; x=1698773880; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IlWr5/l0Pq9GJU72M9uOqylxyPLnOGMn63cAJCP+iZk=; b=MLDN0nMI5yi75O3J7t3i35BH18Le7CxoEQT3OayPdUDzyHktr6zzLrrkciWiF8/Je/ sZjOy2t008dbe2doYrXOBZx/cYrpEPdJluxS0KYBntUEfSOdATwuEEQ/mQ7F0GZkYFMx WFWJBHOLnGvim13PCAZxu1Hx7XIyud9SYfaqTHviwnKm85M2Pr74m50YbpcICDaLhRdz IGzO1FIUJtP28+n+EFjGYUifhSGuYnid+v4iL10OKRXre8Y1J8rDxmz6+qptwiKwIvCM IAYMlNi5syGDhQ6XPrjO+03kqsGwWaMIPTSSPcYNWibc+UkFhWpkAbLNIQhuH8hMWYUs zRtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698169080; x=1698773880; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IlWr5/l0Pq9GJU72M9uOqylxyPLnOGMn63cAJCP+iZk=; b=ACfDJ+TezpRk5YNNgibmWcDD4G9yTxkmiZk6ze41pdsM27bF2+zpiEFjsojX1vuKy1 1ojkjlsLADiES7LKUsg9sSe0X77A8MUwbyKr1xo/wCvFvfx3/enx2Y0WUKCMKi82JnMn OxyqYhUd3X08V0BveCP+tV4sg1K3vbNtOJIYVy5CfIh/R1RSg9du9OGIaY7VDTsoTgMB oCapJEuO+1CoLZhQpTKzSxqSFb5u2ORoe3kYzuNUtvs6C5yeuqm2WxiBxiZYEj4kPYnP C9WuHAtAKA5iD78FXYGverqRTey88ANyUg5a+h8kGhvBEFXD0KRzJpedAifA00OuBfRV QROg== X-Gm-Message-State: AOJu0YyNVo/QE5gOpL8dKEF9Ql0sl0APIbVH5rokFBMFpnof2lfe4a+T mrpSJMfkTCExgeBRMjJRYl4= X-Google-Smtp-Source: AGHT+IF16BWUUsDazQiFvIgyRjOPH1WM4c92xNqnSRTUPoQxjrkWzat4Ww7kywGII1MFHKtud/UW3w== X-Received: by 2002:a17:90b:1bc6:b0:27c:ef5d:646d with SMTP id oa6-20020a17090b1bc600b0027cef5d646dmr10899645pjb.17.1698169079732; Tue, 24 Oct 2023 10:37:59 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id ce21-20020a17090aff1500b00274de7c8aacsm8930388pjb.45.2023.10.24.10.37.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Oct 2023 10:37:58 -0700 (PDT) Message-ID: <970415cf-95c9-4df3-846c-fa01a3e0fe21@gmail.com> Date: Tue, 24 Oct 2023 11:37:53 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/6] rtl-ssa: Handle call clobbers in more places Content-Language: en-US To: Richard Sandiford , jlaw@ventanamicro.com, gcc-patches@gcc.gnu.org References: <20231024105006.3337671-1-richard.sandiford@arm.com> <20231024105006.3337671-7-richard.sandiford@arm.com> From: Jeff Law In-Reply-To: <20231024105006.3337671-7-richard.sandiford@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/24/23 04:50, Richard Sandiford wrote: > In order to save (a lot of) memory, RTL-SSA avoids creating > individual clobber records for every call-clobbered register. > It instead maintains a list & splay tree of calls in an EBB, > grouped by ABI. > > This patch takes these call clobbers into account in a couple > more routines. I don't think this will have any effect on > existing users, since it's only necessary for hard registers. > > gcc/ > * rtl-ssa/access-utils.h (next_call_clobbers): New function. > (is_single_dominating_def, remains_available_on_exit): Replace with... > * rtl-ssa/functions.h (function_info::is_single_dominating_def) > (function_info::remains_available_on_exit): ...these new member > functions. > (function_info::m_clobbered_by_calls): New member variable. > * rtl-ssa/functions.cc (function_info::function_info): Explicitly > initialize m_clobbered_by_calls. > * rtl-ssa/insns.cc (function_info::record_call_clobbers): Update > m_clobbered_by_calls for each call-clobber note. > * rtl-ssa/member-fns.inl (function_info::is_single_dominating_def): > New function. Check for call clobbers. > * rtl-ssa/accesses.cc (function_info::remains_available_on_exit): > Likewise. OK jeff > ---