From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 01350385F014 for ; Tue, 30 Apr 2024 09:01:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01350385F014 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 01350385F014 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714467731; cv=none; b=ux4cPj1UldsJmIxNkLp6rKoRBJSYY1WRpAIvHApuz3gWlNrwmf1JpVn2X8cOrp2eiCAWbjjkyHNG9ch61WHWJ3JAQq1pDvuNAgdXLyLh1UJHceMoKqcyE0SiocHLOnaDS2RI+DsUL8oMoI+8MjWEe1QR0HbigH82vtENqhaHf0U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714467731; c=relaxed/simple; bh=TYkeMw8a2ez6n1EzQnH+Kff5XoEWc8C6aqhHt0oQlKA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=rJW415GFEv3qhieVuCPjVgmgRO7FkgzEUfFSSzljpiEFKXwHlf6gd5c+5TV2Hm6qr1oe01S/z1HmNoLti7jwA6zHVyupJCCNdXVefTkBs+pmryC9muF85lAg99gvT0q6EB2fGxoZIUb8LV9y/9Fh6ktYCyCvLY6dcicfsyTkUZU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.5.241] (unknown [10.168.5.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D40B233EEA; Tue, 30 Apr 2024 09:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714467719; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3zetcccsQB8Vx24PQ481vCLqTZdRID6G3FQI5hfh7B4=; b=qUmSrGAyUhnDiMHr+iZ/7yx4hS+R0cv/T4Ln9WJ2wJQYbkyVKXO9CI0zx6RvvrxAx1nVW+ qukr+bT7BesGRJ8ffef66bmBm8+jUzvjfbTEsp/NXVfS3Q+aAkV0RRsJAlLWGhzJ/JrfyO 9GE9L4W/5n1Pk2UTRC3a/CrBC8uDetI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714467719; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3zetcccsQB8Vx24PQ481vCLqTZdRID6G3FQI5hfh7B4=; b=UQ7BWBk8VPgJ79HQXFdXjjH/yXyOIsh4pbOfrLRfxpTdItNVR0oNGFf4nme2ac9LaIalkk VO1o5ZT5VX3S8RCg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714467718; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3zetcccsQB8Vx24PQ481vCLqTZdRID6G3FQI5hfh7B4=; b=TKCqKOYNVr8QzdXy+U8/NQEvs8ObDR/cCFRliFURXeflxK4LlvbOsaEyIrh4v/CjLvJIlv /RTNhUjKa+PMd6Tswr8UcJzv5VIBnxjwG/wggWcsa8sIMHDOz6A+vHXcLd4B2lklT3aTO4 DfpRthk3LM2KgAR8YpWYWouovCa++uU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714467718; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3zetcccsQB8Vx24PQ481vCLqTZdRID6G3FQI5hfh7B4=; b=aSQPzRADa7Hfm5S7I25tcfqZhKiz6+SgShZ3f6ZIM7jk2UcrhwtEjNma4bL3z9opa++L1P z4mN93+fg5ulJyAg== Date: Tue, 30 Apr 2024 11:01:58 +0200 (CEST) From: Richard Biener To: Jakub Jelinek cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] vect: Adjust vect_transform_reduction assertion [PR114883] In-Reply-To: Message-ID: <97116n6s-0126-o42s-0ppo-p04r4195s67q@fhfr.qr> References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -4.30 X-Spam-Level: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.994]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_ZERO(0.00)[0]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[intel.com:email,suse.de:email] X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 30 Apr 2024, Jakub Jelinek wrote: > Hi! > > The assertion doesn't allow IFN_COND_MIN/IFN_COND_MAX, which are > commutative conditional binary operations like ADD/MUL/AND/IOR/XOR, > and can be handled just fine. > In particular, we emit > vminpd %zmm3, %zmm5, %zmm0{%k2} > vminpd %zmm0, %zmm3, %zmm5{%k1} > and > vmaxpd %zmm3, %zmm5, %zmm0{%k2} > vmaxpd %zmm0, %zmm3, %zmm5{%k1} > in the vectorized loops of the first and second subroutine. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk and > 14.1? OK for both. Richard. > 2024-04-30 Jakub Jelinek > Hongtao Liu > > PR tree-optimization/114883 > * tree-vect-loop.cc (vect_transform_reduction): Allow IFN_COND_MIN and > IFN_COND_MAX in the assert. > > * gfortran.dg/pr114883.f90: New test. > > --- gcc/tree-vect-loop.cc.jj 2024-04-17 11:34:02.465185397 +0200 > +++ gcc/tree-vect-loop.cc 2024-04-29 20:41:04.973723992 +0200 > @@ -8505,7 +8505,8 @@ vect_transform_reduction (loop_vec_info > { > gcc_assert (code == IFN_COND_ADD || code == IFN_COND_SUB > || code == IFN_COND_MUL || code == IFN_COND_AND > - || code == IFN_COND_IOR || code == IFN_COND_XOR); > + || code == IFN_COND_IOR || code == IFN_COND_XOR > + || code == IFN_COND_MIN || code == IFN_COND_MAX); > gcc_assert (op.num_ops == 4 > && (op.ops[reduc_index] > == op.ops[internal_fn_else_index ((internal_fn) code)])); > --- gcc/testsuite/gfortran.dg/pr114883.f90.jj 2024-04-29 20:39:39.000871849 +0200 > +++ gcc/testsuite/gfortran.dg/pr114883.f90 2024-04-29 20:39:27.757021972 +0200 > @@ -0,0 +1,53 @@ > +! PR tree-optimization/114883 > +! { dg-do compile } > +! { dg-options "-O2 -fvect-cost-model=cheap" } > +! { dg-additional-options "-march=x86-64-v4" { target i?86-*-* x86_64-*-* } } > + > +subroutine pr114883_1(a, b, c, d, e, f, g, h, o) > + real(8) :: c(1011), d(1011), e(0:1011) > + real(8) :: p, q, f, r, g(1011), h(1011), b, bar > + integer :: o(100), a, t, u > + p = 0.0_8 > + r = bar() > + u = 1 > + do i = 1,a > + do k = 1,1011 > + km1 = max0(k-1,1) > + h(k) = c(k) * e(k-1) * d(km1) > + f = g(k) + h(k) > + if(f.gt.1.e-6)then > + p = min(p,r) > + endif > + end do > + q = 0.9_8 * p > + t = integer(b/q + 1) > + if(t>100)then > + u = t > + endif > + o(u) = o(u) + 1 > + end do > +end subroutine pr114883_1 > +subroutine pr114883_2(a, b, c, d, e, f, g, h, o) > + real(8) :: c(1011), d(1011), e(0:1011) > + real(8) :: p, q, f, r, g(1011), h(1011), b, bar > + integer :: o(100), a, t, u > + p = 0.0_8 > + r = bar() > + u = 1 > + do i = 1,a > + do k = 1,1011 > + km1 = max0(k-1,1) > + h(k) = c(k) * e(k-1) * d(km1) > + f = g(k) + h(k) > + if(f.gt.1.e-6)then > + p = max(p,r) > + endif > + end do > + q = 0.9_8 * p > + t = integer(b/q + 1) > + if(t>100)then > + u = t > + endif > + o(u) = o(u) + 1 > + end do > +end subroutine pr114883_2 > > Jakub > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)