public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Patrick O'Neill <patrick@rivosinc.com>, gcc-patches@gcc.gnu.org
Cc: gnu-toolchain@rivosinc.com
Subject: Re: [PATCH] g++: Rely on dg-do-what-default to avoid running pr102788.cc on non-vector targets
Date: Thu, 9 Nov 2023 18:20:05 -0700	[thread overview]
Message-ID: <974e9e5e-8f07-46dd-b9b9-db8aa46859b5@gmail.com> (raw)
In-Reply-To: <20231102234527.77231-1-patrick@rivosinc.com>



On 11/2/23 17:45, Patrick O'Neill wrote:
> Testcases in g++.dg/vect rely on check_vect_support_and_set_flags
> to set dg-do-what-default and avoid running vector tests on non-vector
> targets. The three testcases in this patch overwrite the default with
> dg-do run.
> 
> Removing the dg-do run directive resolves this issue for non-vector
> targets (while still running the tests on vector targets).
> 
> gcc/testsuite/ChangeLog:
> 
> 	* g++.dg/vect/pr102788.cc: Remove dg-do run directive.
OK.  I'll note your patch has just one file patched, but your comment 
indicates three testcases have this problem.  Did you forget to include 
a couple changes?

If so, those are pre-approved as well.  Just post them for the archiver 
and commit.

Thanks,
jeff

  reply	other threads:[~2023-11-10  1:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 23:45 Patrick O'Neill
2023-11-10  1:20 ` Jeff Law [this message]
2023-11-10 19:21   ` [Committed] " Patrick O'Neill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=974e9e5e-8f07-46dd-b9b9-db8aa46859b5@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gnu-toolchain@rivosinc.com \
    --cc=patrick@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).