From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by sourceware.org (Postfix) with ESMTPS id 141403858D1E for ; Fri, 10 Nov 2023 01:20:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 141403858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 141403858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d36 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699579209; cv=none; b=lzPRU7U9R7EpZB5YOWC1/fc4ehhStpXdz21s+vMoaKDSduvs4ZeK9GdagRysx9Zemh54JgFtXyJSK+DvcQCLgHOb/7ZEslOdNc/aaGv75vXjmlifV8oZs4T+zqfcWdNoyf83gVAoYSwBvInWiuLcn1UkyLJ0Pk+zFzS+xoW55Ig= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699579209; c=relaxed/simple; bh=Sh4zWvcgYLVIN/96LQNW4KLk/MeItGFbGlelw4dx7qI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=o2imimMwT4WNB94LoRAQ9DYtyVRxKgqYxP4edMmHD2Fk0uEZevgw4tY94yAjCDn6NG7EgJd/lRVDE2WCTA46GQSpp7/Pr0sVbE/v63ZI3/PoYHKBH9+Ppeb5MwXdot5reSZfrZEEV9+FON+Az5iKho5dxGJ4uRLLwlUfhWU/d7c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd36.google.com with SMTP id ca18e2360f4ac-7ac61c58d85so58801839f.2 for ; Thu, 09 Nov 2023 17:20:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699579207; x=1700184007; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KDvo+k6sV/FV21oU27xn4k1CQnRvZ+MGSb8qHO66mk4=; b=lLrYxCSBLYVjHfYM9q6va3V7wfQhYh1BlbjK1i+ukbF6Las9D8xQDqgqm8DbKWSGRh KwrgC1UK5EnKtZSBdpkZQBjScN4MuLqL6O/T5ceV227eJMRyC1M/Joxi6UGpoL/raZ1+ bDMAsUSJngKlQtiWeYrH60V+ue8JAc7uTKNjeoQYCdoozgxlHtPNob+Zyt3I5H8qnsXo PeHZPj3MBjoinEgpUgb1W/aapPP/vPyNxrffPmc23fUz6cdItXPu2dS4oCj6DGX6g/7F Y2rSW5tr7EPZKswUSuwvQFkFPsQ1QDfbfd7KY1fV6FM0izpEQCcwLvv1O401vpbZnEg6 hE1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699579207; x=1700184007; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KDvo+k6sV/FV21oU27xn4k1CQnRvZ+MGSb8qHO66mk4=; b=FyldKfDa1DKpmMW4izLYQvsu4UPRjTtLGbFW4xE85QfibJSy1TXoOBDbmoT02qviKS cqk+7JwWc1II4AG/R6AKlBDSphAI13lNSkpcwFHic3xrB+eDOwIL9Kk7/oO7J22SRW4O /jQ8XG16GwlC4JXaldFaz2/lNXte/BmJJGbsvRYv9B0Lwgmw3Xy9NA8etMBapo3yl3LY 5hQUx0Do6ofVDU++p/vSvu4nlQHXmgKKmE+z+SXuC2eR1hOUsuvC2NOTbnbq36Q9S6Z0 25F/aPKJatEInwJg9afEdvuoUjPtCE5Dks0WEOACoOUrX46/MeS2J4DkOlq1zc2yuvUs ys2g== X-Gm-Message-State: AOJu0Yx9kHbGT5PT6PXdnoWHuj3YM3vq4+EYJvvmmsqqiK4ok8ymWQBE htjAFM9Tw0M7O3PBQadar18= X-Google-Smtp-Source: AGHT+IGBdyKH3aLnvPMQ2tMcnSlvx3xNZhvCeKZ8M8uFp4lYFgxmpmL9JCIX+gjl0yIf1jzrU53xrQ== X-Received: by 2002:a05:6602:2d8f:b0:7a9:45f8:6715 with SMTP id k15-20020a0566022d8f00b007a945f86715mr4621794iow.19.1699579207313; Thu, 09 Nov 2023 17:20:07 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id e2-20020a6b5002000000b007b001eee33asm109986iob.12.2023.11.09.17.20.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Nov 2023 17:20:06 -0800 (PST) Message-ID: <974e9e5e-8f07-46dd-b9b9-db8aa46859b5@gmail.com> Date: Thu, 9 Nov 2023 18:20:05 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] g++: Rely on dg-do-what-default to avoid running pr102788.cc on non-vector targets Content-Language: en-US To: Patrick O'Neill , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com References: <20231102234527.77231-1-patrick@rivosinc.com> From: Jeff Law In-Reply-To: <20231102234527.77231-1-patrick@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/2/23 17:45, Patrick O'Neill wrote: > Testcases in g++.dg/vect rely on check_vect_support_and_set_flags > to set dg-do-what-default and avoid running vector tests on non-vector > targets. The three testcases in this patch overwrite the default with > dg-do run. > > Removing the dg-do run directive resolves this issue for non-vector > targets (while still running the tests on vector targets). > > gcc/testsuite/ChangeLog: > > * g++.dg/vect/pr102788.cc: Remove dg-do run directive. OK. I'll note your patch has just one file patched, but your comment indicates three testcases have this problem. Did you forget to include a couple changes? If so, those are pre-approved as well. Just post them for the archiver and commit. Thanks, jeff