From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id F376A3857C50; Tue, 12 Dec 2023 02:33:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F376A3857C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F376A3857C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702348402; cv=none; b=vcY0bVQ4ob7hEkJwsQIV3/xpEqDINcO1/6NhMIWD0yPtTvazDX48S1FDAiY5VKZpRAwZXVpjB6vWmp7V8cn/eiXBkLntnVL4PNqZg2cWEpedi52+KPNdPQUedeczK1RCIJjhm3j6eNrRNggmpkvly8pII/uFF0IDCZ1A8/GhxZo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702348402; c=relaxed/simple; bh=EGnr4qCtfeJLniFj38350+wHZfcUW/YNZg0wDWwAN2c=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=fuXV94lD/3TR9GzWgXR3vgA6xc1+g9a24vSSttxkp0DKTd9U5dqgZg1uzMxOx0Q6Rjz+99cCel0GN0Go4s1rmdCrkDiRvIPRSqCg/hOd17mvBAyxJYlRpzyTOp4MfZ3DNLKc8dwxOIAqw7U+CGo6/Br9JO3IpDsbb3oLyW+NoUI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353722.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3BC2QEpT029294; Tue, 12 Dec 2023 02:33:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=Tlzfzu6KUHlW+l8w1cyPyTsTiggDuVcLM6ImJlbR3pQ=; b=FVSM7/+hHUSC2idkLXOtDnOSgrFU6AMZAihUdLeKW4UPx0TOA7MczTfCNiqOHaFWQblV LGZ3xMhBgOooAOecoPGFumpecUTGuxueN7jMNIInv9j4biVdN8/VKgwllSsn9vb6KZgj 6YWEKbWAzSYspEP2jY2z8gFP9IqRY0XeHKj4Nq+DQiOeu8O7SG/47+5gYjxvGEJ06O9D qFUp+yHcexBaBM3RybYrzq8NfTyrUTlN7Ywh3aaoHiTupBy0qFmynPVr12zHmxUxC23l axTJexPdhLW09hKuxbZQ8Oh1ZSD4jpgcCyRy0Yqsyc0lY0LTvI8mLRtW4CFX8oW2qYI/ 1A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uxcdf2vwj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Dec 2023 02:33:20 +0000 Received: from m0353722.ppops.net (m0353722.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3BC1m9rj029913; Tue, 12 Dec 2023 02:33:19 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uxcdf2vvt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Dec 2023 02:33:19 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3BC0whNq004899; Tue, 12 Dec 2023 02:33:18 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3uw4sk5kx8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Dec 2023 02:33:18 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3BC2XFL317040032 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Dec 2023 02:33:15 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9D5662004B; Tue, 12 Dec 2023 02:33:15 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3DE2820043; Tue, 12 Dec 2023 02:33:13 +0000 (GMT) Received: from [9.200.53.32] (unknown [9.200.53.32]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 12 Dec 2023 02:33:12 +0000 (GMT) Message-ID: <977c7e1a-9fd9-1a86-3cba-fe13e67e6295@linux.ibm.com> Date: Tue, 12 Dec 2023 10:33:11 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH V4 2/3] Using pli for constant splitting Content-Language: en-US To: Jiufu Guo Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, bergner@linux.ibm.com, gcc-patches@gcc.gnu.org References: <20231211032604.3299841-1-guojiufu@linux.ibm.com> <20231211032604.3299841-2-guojiufu@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <20231211032604.3299841-2-guojiufu@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: gMZhQEYEyI--qEx5R-vkcc6hiJkDLlDq X-Proofpoint-ORIG-GUID: C7WmGZk9CU0DGkGWhkd-UAl3jk8Pu5LB Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-11_11,2023-12-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 mlxlogscore=999 priorityscore=1501 adultscore=0 suspectscore=0 lowpriorityscore=0 mlxscore=0 phishscore=0 spamscore=0 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312120019 X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, on 2023/12/11 11:26, Jiufu Guo wrote: > Hi, > > For constant building e.g. r120=0x66666666, which does not fit 'li or lis', > 'pli' is used to build this constant via 'emit_move_insn'. > > While for a complicated constant, e.g. 0x6666666666666666ULL, when using > 'rs6000_emit_set_long_const' to split the constant recursively, it fails to > use 'pli' to build the half part constant: 0x66666666. > > 'rs6000_emit_set_long_const' could be updated to use 'pli' to build half > part of the constant when necessary. For example: 0x6666666666666666ULL, > "pli 3,1717986918; rldimi 3,3,32,0" can be used. > > Compare with previous: > https://gcc.gnu.org/pipermail/gcc-patches/2023-December/639492.html > This verion is refreshed and updated testcase name. > > Bootstrap®test pass on ppc64{,le}. > Is this ok for trunk? OK for trunk, thanks! BR, Kewen > > BR, > Jeff (Jiufu Guo) > > gcc/ChangeLog: > > * config/rs6000/rs6000.cc (rs6000_emit_set_long_const): Add code to use > pli for 34bit constant. > > gcc/testsuite/ChangeLog: > > * gcc.target/powerpc/const-build-1.c: New test. > > --- > gcc/config/rs6000/rs6000.cc | 9 ++++++++- > gcc/testsuite/gcc.target/powerpc/const-build-1.c | 9 +++++++++ > 2 files changed, 17 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/gcc.target/powerpc/const-build-1.c > > diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc > index 017000a4e02..531c40488b4 100644 > --- a/gcc/config/rs6000/rs6000.cc > +++ b/gcc/config/rs6000/rs6000.cc > @@ -10511,7 +10511,14 @@ rs6000_emit_set_long_const (rtx dest, HOST_WIDE_INT c, int *num_insns) > emit_insn (dest_or_insn); > }; > > - if ((ud4 == 0xffff && ud3 == 0xffff && ud2 == 0xffff && (ud1 & 0x8000)) > + if (TARGET_PREFIXED && SIGNED_INTEGER_34BIT_P (c)) > + { > + /* li/lis/pli */ > + count_or_emit_insn (dest, GEN_INT (c)); > + return; > + } > + > + if ((ud4 == 0xffff && ud3 == 0xffff && ud2 == 0xffff && (ud1 & 0x8000)) > || (ud4 == 0 && ud3 == 0 && ud2 == 0 && !(ud1 & 0x8000))) > { > /* li */ > diff --git a/gcc/testsuite/gcc.target/powerpc/const-build-1.c b/gcc/testsuite/gcc.target/powerpc/const-build-1.c > new file mode 100644 > index 00000000000..7e35f8c507f > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/const-build-1.c > @@ -0,0 +1,9 @@ > +/* { dg-do compile { target lp64 } } */ > +/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ > +/* { dg-require-effective-target power10_ok } */ > + > +unsigned long long msk66() { return 0x6666666666666666ULL; } > + > +/* { dg-final { scan-assembler-times {\mpli\M} 1 } } */ > +/* { dg-final { scan-assembler-not {\mli\M} } } */ > +/* { dg-final { scan-assembler-not {\mlis\M} } } */