From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by sourceware.org (Postfix) with ESMTPS id 93BE43858D1E for ; Fri, 10 Nov 2023 22:03:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 93BE43858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 93BE43858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699653786; cv=none; b=he8Lg+YHuvfaSMfmCXmAH4/MSm/MTn/cJAIr4wMwyIPR49svqDk8Uw3SDspiMMlmGhwY4owu3qHRuv4ezpib6y18PSqOXNBovEy3yuymmxqCCj9jrK8YC9bGn4aQzicFEh+vJFZ2+tIn7D4ZS+E5fLYFJ3giFRtxtSoaf33CsiE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699653786; c=relaxed/simple; bh=ur1BxVRgcl8ajj68rY+7ILrg2kEcfvGEZe+VZx296Oc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=aVbbP5h7bcPwM9jlAkKCt9UM4la++NRFqoFrORzLsDbdfdyQYBLpeelIyKDOGEUCVNh4ew5//XUqbj54LRZbEogY4sNE/jRw9a9Fxy+LerKDSXabyOaR4IvYQ+7Pn4GvCGa2njRIrav50a//DE46a1eKwAyvrpPkxMJ1G5cQ1Nc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2c.google.com with SMTP id ca18e2360f4ac-7a92727934eso93551839f.3 for ; Fri, 10 Nov 2023 14:03:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699653784; x=1700258584; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zicD/GQLdtp8OkCeSJdB3kAua4P6W4L0/Qt8ZL9eOJk=; b=d0Yg5CHM/AretZVlWFzZASGkK44eV5yVMIc1nKYVyMmrmajVKR8npjzFT8vzJCzRnC ZZ4FmheTL0pVqZNuXm2NZkP6id2QcoOHRgWfECmsu/o5+BkQkO8uDY8wbbIelwOa1zIr 6+cL3LabU+PJrrAuEk4O+aGmAue1prik59m1Kpsc/AJCs3oHA8T0EM+07NncFh55u/Pc oOyBSSbfASF4hbx9aRlzJzNIdA1lR9/+eaUSHrFG6vT6aHFxR8ryv+/hggbtr/XwGu9x gWusNL/F1H2s6+osc4mWRKYyPP8+GAWzwJ2pDxpiffBranDPSaOmfKbL0A2Q3X3+S5eK EFaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699653784; x=1700258584; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zicD/GQLdtp8OkCeSJdB3kAua4P6W4L0/Qt8ZL9eOJk=; b=SX2t6uNOmLK8+5FhG8+d4HNIxebfLbtcKag0+wjjE08bAy+bN0ywet7+Xjn3fPUXkr Lqk/dLZ5DaFfvodZ5hJJnFVqjNhvVHjUCqnW6F+i4WCoUTVpjrlKuzJOx//h/2vxlsCZ L1iaq8cbJP15FhMvcTuo/jZOYlD6j38JoW/8/w6g23SBQBbEFhmg4m8K1vdVOPetoa/3 uvA20cguRR8fBGOah0UymyWxOAIrQZwTA+OkV1KXpMiY/taWXxd/YEaq1K5l2jyl36FX a1h9nXwVErTfy9AWkOayGfsNIJR9InzPV2RWKNmGOi4vZaQNoFmxkn98+8i65DqMWxVu YXLA== X-Gm-Message-State: AOJu0YyIaw9RDgMpyvccwicbHZJk8FbSbkXc8FEQ8xzarPfnrVa76C3U bkVTDgnPqXhEdhUyVqBC/Qk= X-Google-Smtp-Source: AGHT+IHqahHArpgt1/AIBRnCuZCHjE6ew0Zkzi1AorRON4QPez0pmbnuEOvMi9U+E8l4Zt2K7cQ5Sg== X-Received: by 2002:a05:6602:2ac4:b0:787:1555:efca with SMTP id m4-20020a0566022ac400b007871555efcamr780113iov.5.1699653783800; Fri, 10 Nov 2023 14:03:03 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id p23-20020a02b397000000b0042036f06b24sm87552jan.163.2023.11.10.14.03.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Nov 2023 14:03:03 -0800 (PST) Message-ID: <977e60a7-4ed3-42d2-8f7e-9529d0b90eb0@gmail.com> Date: Fri, 10 Nov 2023 15:03:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] ifcvt: Remove obsolete code for subreg handling in noce_convert_multiple_sets Content-Language: en-US To: Manolis Tsamis , gcc-patches@gcc.gnu.org Cc: Jakub Jelinek , Richard Sandiford References: <20230830101400.1539313-1-manolis.tsamis@vrull.eu> <20230830101400.1539313-5-manolis.tsamis@vrull.eu> From: Jeff Law In-Reply-To: <20230830101400.1539313-5-manolis.tsamis@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/30/23 04:14, Manolis Tsamis wrote: > This code used to handle register replacement issues with SUBREG before > simplify_replace_rtx was introduced. This should not be needed anymore as > new_val has the correct mode and that should be preserved by > simplify_replace_rtx. > > gcc/ChangeLog: > > * ifcvt.cc (noce_convert_multiple_sets_1): Remove old code. So is it the case that this code is supposed to no longer be needed as a result of your kit or it is unnecessary independent of patches 1..3? If the latter then it's OK for the trunk now. Jeff