From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130163 invoked by alias); 3 Nov 2016 17:31:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 130153 invoked by uid 89); 3 Nov 2016 17:31:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=haven, haven=e2, TCL, tcl?= X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Nov 2016 17:31:16 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 0CC378132C; Thu, 3 Nov 2016 18:31:15 +0100 (CET) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id seEKn_0DNgVS; Thu, 3 Nov 2016 18:31:14 +0100 (CET) Received: from [IPv6:2a02:2ab8:224:1:f21f:afff:fe4c:b838] (cacatoes.act-europe.fr [IPv6:2a02:2ab8:224:1:f21f:afff:fe4c:b838]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id BBF1181308; Thu, 3 Nov 2016 18:31:14 +0100 (CET) Subject: Re: [PATCH] DW_TAG_ptr_to_member_type for PMF and DW_AT_{,rvalue_}reference for those To: Jakub Jelinek , Jason Merrill References: <20161102143100.GU3541@tucnak.redhat.com> <20161102154405.GX3541@tucnak.redhat.com> <20161102163326.GY3541@tucnak.redhat.com> Cc: Alexandre Oliva , Keith Seitz , Jan Kratochvil , gcc-patches List From: Pierre-Marie de Rodat Message-ID: <978904a2-f342-1640-3264-ea1fcb549d22@adacore.com> Date: Thu, 03 Nov 2016 17:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161102163326.GY3541@tucnak.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00357.txt.bz2 Hello all, On 11/02/2016 05:33 PM, Jakub Jelinek wrote: > On Wed, Nov 02, 2016 at 04:44:05PM +0100, Jakub Jelinek wrote: >>> You could find an Ada test that uses the code and verify that the >>> output stays the same? >> >> I can try to find the patch that introduced it and if it contained any >> testcases. > > I couldn't find any unfortunately. Pierre, could you please test if the > following patch doesn't regress anything in the Ada debug info area? Yes, DWARF output is hard to test… or at least I haven’t find a way to do so in TCL/DejaGNU. ;-) I have my own Python-based testsuite, which I use everytime I submit a DIE-related patch. As I said on IRC and as richi and I discussed at the last cauldron, the plan would be to manage to port the testcase to GCC’s, but schedule-wise I’m not able to do that these days… For the record I still plan to do it, though! So, just in case someone would need/want to run this testsuite, here it is in its current state: . Anyway, that being said: your patch does not introduce regressions in my testsuite, so it’s fine as far as I’m concerned. :-) Thank you for asking! -- Pierre-Marie de Rodat