public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [committed] Remove compromised sh test
Date: Wed, 26 Jun 2024 07:22:34 -0600	[thread overview]
Message-ID: <9796ab1d-201f-4097-9cc0-cadbc5a6e499@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

Surya's recent patch to IRA improves the code for sh/pr54602-1.c 
slightly.  Specifically it's able to eliminate a save/restore in the 
prologue/epilogue and a bit of register shuffling.

As a result there literally aren't any insns that can be used to fill 
the delay slot of the return, so a nop gets emitted and the test fails.

Given there literally aren't any insns to move into the delay slot, the 
best course of action is to just drop the test.

Pushed to the trunk.

Jeff

[-- Attachment #2: P --]
[-- Type: text/plain, Size: 1375 bytes --]

commit 47b68cda2c4afe32e84c5f18da0196c39e5e0edf
Author: Jeff Law <jlaw@ventanamicro.com>
Date:   Wed Jun 26 07:20:29 2024 -0600

    [committed] Remove compromised sh test
    
    Surya's recent patch to IRA improves the code for sh/pr54602-1.c slightly.
    Specifically it's able to eliminate a save/restore in the prologue/epilogue and
    a bit of register shuffling.
    
    As a result there literally aren't any insns that can be used to fill the delay
    slot of the return, so a nop gets emitted and the test fails.
    
    Given there literally aren't any insns to move into the delay slot, the best
    course of action is to just drop the test.
    
    gcc/testsuite
            * gcc.target/sh/pr54602-1.c: Delete test.

diff --git a/gcc/testsuite/gcc.target/sh/pr54602-1.c b/gcc/testsuite/gcc.target/sh/pr54602-1.c
deleted file mode 100644
index e7fb2a9a642..00000000000
--- a/gcc/testsuite/gcc.target/sh/pr54602-1.c
+++ /dev/null
@@ -1,14 +0,0 @@
-/* Verify that the delay slot is stuffed with register pop insns for normal
-   (i.e. not interrupt handler) function returns.  If everything goes as
-   expected we won't see any nop insns.  */
-/* { dg-do compile }  */
-/* { dg-options "-O1" } */
-/* { dg-final { scan-assembler-not "nop" } } */
-
-int test00 (int a, int b);
-
-int
-test01 (int a, int b, int c, int d)
-{
-  return test00 (a, b) + c;
-}

             reply	other threads:[~2024-06-26 13:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-26 13:22 Jeff Law [this message]
2024-06-26 22:12 ` Oleg Endo
2024-06-26 22:39   ` Jeff Law
2024-06-26 22:44     ` Oleg Endo
2024-06-27  0:30       ` Jeff Law
2024-06-27  1:27         ` Oleg Endo
2024-06-27  1:54           ` Jeff Law
  -- strict thread matches above, loose matches on Subject: below --
2024-06-26 13:21 Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9796ab1d-201f-4097-9cc0-cadbc5a6e499@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).