From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id E01983848025 for ; Wed, 9 Jun 2021 15:14:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E01983848025 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 159F3LZZ005832 for ; Wed, 9 Jun 2021 11:14:59 -0400 Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 392yx9gma7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 09 Jun 2021 11:14:58 -0400 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 159FESFi026307 for ; Wed, 9 Jun 2021 15:14:56 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma04ams.nl.ibm.com with ESMTP id 3900w8a89a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 09 Jun 2021 15:14:56 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 159FErOx23265612 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Jun 2021 15:14:53 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 90DCC5204F; Wed, 9 Jun 2021 15:14:53 +0000 (GMT) Received: from li-23497a81-5215-11cb-9bae-a81330ecc14b.ibm.com (unknown [9.145.92.93]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 688235204E; Wed, 9 Jun 2021 15:14:53 +0000 (GMT) Subject: Re: [PATCH] s390: Add more vcond_mask patterns. To: Robin Dapp , GCC Patches References: <49d520d8-c771-66bd-e657-d02d2990cb0a@linux.ibm.com> <3ad02016-2027-a15c-28b1-4c723e8ede23@linux.ibm.com> From: Andreas Krebbel Message-ID: <97b26a18-9c14-b2ca-e021-0fbbeb92ed94@linux.ibm.com> Date: Wed, 9 Jun 2021 17:14:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: XzNXY8Pd9qOzjhElfEDgn51DGp31ZwRA X-Proofpoint-ORIG-GUID: XzNXY8Pd9qOzjhElfEDgn51DGp31ZwRA X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-06-09_04:2021-06-04, 2021-06-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 priorityscore=1501 adultscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106090073 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2021 15:15:01 -0000 On 6/9/21 2:47 PM, Robin Dapp wrote: >> I think the real problem is the expander name. That's why it could not be found by optab. The second >> mode needs to be the int vector mode of op3. With that change the testcases work as expected: >> >> diff --git a/gcc/config/s390/vector.md b/gcc/config/s390/vector.md >> index c80d582a300d..ab605b3d2cf3 100644 >> --- a/gcc/config/s390/vector.md >> +++ b/gcc/config/s390/vector.md >> @@ -715,7 +715,7 @@ >> DONE; >> }) >> >> -(define_expand "vcond_mask_" >> +(define_expand "vcond_mask_" >> [(set (match_operand:V 0 "register_operand" "") >> (if_then_else:V >> (eq (match_operand: 3 "register_operand" "") > > Ah, yes, it's indeed much simpler that way. Attached the revised > version with the small change and the new tests as a single patch now. > > Regtest and bootstrap was successful. Ok. Thanks! Andreas