From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by sourceware.org (Postfix) with ESMTPS id E8EE63857B98 for ; Thu, 14 Mar 2024 16:55:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E8EE63857B98 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=baylibre.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E8EE63857B98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710435364; cv=none; b=DXqvuX2fLMNPHeCuxiJ8j3ccIkaEzb0ZV0msdvjSN0HKecrbkxGod3Sbgcxi7jhdC0OjEqTbiJ9Z3g+bw64FgsiWgphJ81R16AUTS6Df/FHCxd7LWP0spLj0VrbtQYSUKhW+hh2lj3UIn1xbCiZzUb7JEmcME4zzrTpt4CZyOww= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710435364; c=relaxed/simple; bh=sEwBT8Z9WobXUTzatks5TMTpAfcH1K4V4+F5gutNDWU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=RCJgSzQwQ9+AZd291zDIHR4wVXlvVyU0mpSK8mEZl21AIhP69EF3fBSVFPKpWhOXimvd+9Ee+IRjxKQHIJW7Q42Z97FjCwAGBXww3uvu0uUWXz6nsD5rR06xIgRv4f43m8TwnondIxd4GytqH+nf5I5U6bWnpPw35o8Ulk/mI8o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2d094bc2244so16263921fa.1 for ; Thu, 14 Mar 2024 09:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1710435358; x=1711040158; darn=gcc.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=goiWBgyMseYxYZ1eISolzN3Rq7BM+oqBxBykDMie5Xc=; b=imCYt3TmSnlyJOyvXNPUhMLXfBqfD2aG0vE8W1d41ddQgcyAyiBBk1wOT+wxoAI5o5 yuO5jrCAg2m4OveZ6WbkhAfZ75BIyICb9n/l2SwvBcTDOxbehN3C67puyGnXcI3yLBnv EsxEdDaeppnNtuafZxr2TmQSgZWELvL2nkg9FJe+LlUcqqtpYkUgWmLfnjSVfirf2z3k n2NsFtg6z9hzOwrPSIUvjr13mogZ2DfSEvtFfKupCKtbEWrBTle4Dxo4N8DpDr23mvVA gINU0oW20PQ+XiecA7KRYzmjk4ChPocqS05xEMwct8ljuBP5nQ0Y2yL2JdzG4V87J1oZ CLGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710435358; x=1711040158; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=goiWBgyMseYxYZ1eISolzN3Rq7BM+oqBxBykDMie5Xc=; b=DR1EXawcl0Nbb9/uFSoMUs3swRQgqLTgs6lJA0vDvTH2/uWBLNqkBB7TVJwtjJn7xX iUY9emlR9NoUmmarF93uhawntmO9cyjmaRYR1DIq0gSz2Tn0Tu3BAbl43sj2vDcYmzwi Bznim5OThMOZFeeGHt0PIoNGtYrdecVSosrW5sakSIOMSXnTkEZzyZSdC4VvwKqMZ9uI GX0w2tv4EjHSLaOnf1p3M9POXdu16070CYgydSOYzDDTFcDK29gchq3nelNMFYpStyyD WCvKyZAAePt1NosJAuURW5M11qQJVHB7dCv/F8XWCo0cX/ob6g1zsBL7Vg1qkY6O7/Oq xCYg== X-Forwarded-Encrypted: i=1; AJvYcCXk/I75HeqqFFR0OadHgzW/CURyTAG8r3uubLY5YqdqLg6fxMG7fiN0dPjbGX9EGMq+RnkOTlfp+InUXEEerJeDWMjfuMouzw== X-Gm-Message-State: AOJu0YxYtYX0AeRefApCwM9Zf5E1lqo9K1QDFlA6vuyXW0LwgdXubgsP pC+ZSCRDb+1I2qK6gXMaMxywwdCsWyuRovwWzXC5SSVueI65htWsAv1RpoL8UB0= X-Google-Smtp-Source: AGHT+IE4wHnZvc3LhEyGkJt+zohNcCAIgMzbsnLp+3O6O2R1FSOxZ8ocNEwme4XWfBiiqCWeFmdZtA== X-Received: by 2002:a19:ca07:0:b0:513:8438:c784 with SMTP id a7-20020a19ca07000000b005138438c784mr1512043lfg.23.1710435358033; Thu, 14 Mar 2024 09:55:58 -0700 (PDT) Received: from ?IPV6:2001:16b8:2a97:9a00:1328:ba90:3636:1a76? (200116b82a979a001328ba9036361a76.dip.versatel-1u1.de. [2001:16b8:2a97:9a00:1328:ba90:3636:1a76]) by smtp.gmail.com with ESMTPSA id j3-20020a05600c1c0300b004131310a29fsm3014848wms.15.2024.03.14.09.55.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Mar 2024 09:55:57 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------nPnoG0AYR1gPpLFmJGPSKGsr" Message-ID: <97c66c4e-33ad-44c3-95ae-4255f380a2f2@baylibre.com> Date: Thu, 14 Mar 2024 17:55:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: OpenACC 2.7: front-end support for readonly modifier: Add basic OpenACC 'declare' testing Content-Language: en-US To: Thomas Schwinge , Chung-Lin Tang , gcc-patches@gcc.gnu.org Cc: Tobias Burnus , fortran@gcc.gnu.org References: <87lefaaesb.fsf@euler.schwinge.homeip.net> <87ttqd7m8e.fsf@euler.schwinge.homeip.net> <2f568f7d-807b-41d1-befb-40039e2edb74@pllab.cs.nthu.edu.tw> <87le6mebri.fsf@euler.schwinge.ddns.net> <87sf0s6e9l.fsf@euler.schwinge.ddns.net> From: Tobias Burnus In-Reply-To: <87sf0s6e9l.fsf@euler.schwinge.ddns.net> X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------nPnoG0AYR1gPpLFmJGPSKGsr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi all, hi Thomas & Chung-Lin, Thomas Schwinge wrote: > But I realized another thing: don't we have to handle the 'readonly' > modifier also in Fortran module files, that is, next to the OpenACC > 'declare' 'copyin' handling in 'gcc/fortran/module.cc': > 'AB_OACC_DECLARE_COPYIN' etc.? I bet so; it is not as bad as with the others as it is "only" an optimization hint, but it makes sense to make it available. Note that when you place the 'module' in the same file as the module users ('use'), the compiler might know things because they are in the same translation unit / file not because it is in the module ... > Chung-Lin, please check, via test cases. > 'gfortran.dg/goacc/routine-module*', for example, should provide some > guidance of how to achieve actual module file use, and then do the same > 'scan-tree-dump' as in the current 'readonly' modifier test cases. ... > By means of only emitting a tag > in the module file if the 'readonly' modifier is specified, we should > maintain compatibility with the current 'MOD_VERSION'. That was the idea: If only new information gets added (if used), older compilers still work. This has huge limitations and does not work as well as imagined but here it should work: Older .mod will work with new compilers, even though the reverse might not be true. Tobias --------------nPnoG0AYR1gPpLFmJGPSKGsr--