From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 9E7BB3858D32 for ; Mon, 5 Sep 2022 02:25:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9E7BB3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 284NJcuv028126; Mon, 5 Sep 2022 02:25:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=HzsZB+tsNIHf6AJcVT26yUQSrHHp8xReFij6pK62Jgo=; b=sEnXPqStMgxePLLrbGkcHwL2xCFb1o9pvzy58au5UcTvLaEiTuSfqpfaBopBvtmUnLAI jdBD+rkny32XUKyRLHZzHPYj83F2VpH3U4K3qKkgSi6S2iloY4Ou2H96kstpIWFg1QRz AFwVhH7hgtt4se/MPAXrtLvXr+NeE36dW8EllYVxRV2XWQgB5cbStlx963XvEbDZqU1X VsBYHgOI9Tx2lZKB5gm8NrVsnRCREEWjtrx4f1HzLahYGv9+GxjLEODbdPu335jzM17H qYZAEjJfZofu/ztPGLIrsYKO3DBIly42RY//XU+5Szu9peh07aZmmkmAU5l0JKUO5py5 cg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jd5keb673-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Sep 2022 02:25:25 +0000 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2851jFNi040929; Mon, 5 Sep 2022 02:25:25 GMT Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jd5keb66f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Sep 2022 02:25:25 +0000 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2852Knr7018493; Mon, 5 Sep 2022 02:25:23 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma06fra.de.ibm.com with ESMTP id 3jbx6hsagn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Sep 2022 02:25:23 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2852PLXF40305130 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Sep 2022 02:25:21 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0AFB5A4054; Mon, 5 Sep 2022 02:25:21 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6448DA405F; Mon, 5 Sep 2022 02:25:19 +0000 (GMT) Received: from [9.200.35.246] (unknown [9.200.35.246]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 5 Sep 2022 02:25:19 +0000 (GMT) Message-ID: <97d92a54-304c-182f-531b-e91fa60ef1a4@linux.ibm.com> Date: Mon, 5 Sep 2022 10:25:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] rs6000/test: Fix bswap64-4.c with has_arch_ppc64 [PR106680] Content-Language: en-US To: Segher Boessenkool Cc: Peter Bergner , David Edelsohn , GCC Patches References: <69277846-f587-b79e-f741-a2942d326778@linux.ibm.com> <4e527a22-2dd6-9fa3-b255-4f71b90b77f7@linux.ibm.com> <5d7a002c-829a-da5a-f630-3533084aef0e@linux.ibm.com> <20220901145704.GC25951@gate.crashing.org> <9b27e429-9f34-dc97-7ab6-4e5f6b02324e@linux.ibm.com> <20220902173604.GW25951@gate.crashing.org> From: "Kewen.Lin" In-Reply-To: <20220902173604.GW25951@gate.crashing.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: E2qlxhSxmX-NVkMZ4Evpd0-j0mv9w08_ X-Proofpoint-ORIG-GUID: 6bbAHWVl4jNHMoLcEZqQb7tia9ziTC49 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-09-05_02,2022-08-31_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 suspectscore=0 priorityscore=1501 adultscore=0 phishscore=0 spamscore=0 mlxlogscore=806 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209050009 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: on 2022/9/3 01:36, Segher Boessenkool wrote: > On Fri, Sep 02, 2022 at 08:50:52AM +0800, Kewen.Lin wrote: >> on 2022/9/1 22:57, Segher Boessenkool wrote: >>> These two are independent, but apparently we have a bug here, which will >>> make what you did malfunction in some cases -- the test will not run for >>> ilp32 if you have RUNTESTFLAGS {-m32,-m64}. >> >> Yeah, because of the bug (or call it surprised behavior), > > No, I call it a bug. Because that is what it is! > OK. :) >> the test case can >> fail for some dejaGnu version like 1.5.1 (how it places the dg-options matters). > > Yes, but that is only one way to expose the problem. > > The bug just should be fixed. Agreed. > >> But to be clarified, the order of >> >> /* { dg-options "-O2 -mpowerpc64" } */ >> >> and >> >> /* { dg-require-effective-target has_arch_ppc64 } */ >> >> matters in this proposed fix, not for the line with ilp32. > > Of course :-) > >> has_arch_ppc64 uses current_compiler_flags which only incorporates dg-options >> which is placed before the dg-require-effective-target. I guess it's related >> to how dejaGnu parses lines and sets global variables, for this kind of case, >> we have to put the expected order for now. > > Even just to avoid having to uselessly edit hundreds of testcases, it > would be better to just fix the bug! I think "the bug" here means the "-mpower64" with "-m32/-m64" thing, not the dejaGnu thing mentioned above, then yes. BR, Kewen