From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 07B8E3858D37 for ; Mon, 11 Dec 2023 07:39:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 07B8E3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 07B8E3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702280367; cv=none; b=maoNQTaVhbkPPR8aNgim+tkH/2OKEzB45OMfx2ofxI7LH0GHz7Aq0YWaqWKqye+oiNQRCznU6WVHBQHdUsANJMeMIVB9UXuCyah9gBIX2gYSgY2dg73dcDYQkgj36ix3FU2RsghkQRP5YTw0jNlg2FJLac9pG9ui8YtusmP5HPA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702280367; c=relaxed/simple; bh=BKCfoMImppuwlP+GaTHmKuyc/YrAYXlyn0sv5NCptOc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=H+EJqLpvxyNRAF27035pi5JsJLj2jOpSsr5JkCZP5fmCsxguByN0RVNvytZmL/4ZI9e2cYuLSbHm2NHQvKkYDlsnd4npOWGTJwhbByHFsqxm7l+NPD/u5f0PmytIo5/SKpHf2OkfNlYvFeOwo3Fj1fsXy59bEU7VvMoe7ivnyHU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8E96721F36; Mon, 11 Dec 2023 07:39:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702280364; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AR2J2bfA3KmAdFvz7xIrPgcM/jsx2lOqUf3TezZiFRQ=; b=nSFUbJs6nWsoCW9LH/cwC85G3Cz0CeAyIrLtpZL92ne3tnvZfA+C5oGvodFfHlawal0g8R cQaoLXMEnP/XR1B1bi2CFkMfQTfPt4fgmE6MRb6jS9C5qNpy1xZ0U4rxYQ4aJf5+MaoXnN d7gsoKlNQGTVlxCTAWY+FzLCvVsDJTI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702280364; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AR2J2bfA3KmAdFvz7xIrPgcM/jsx2lOqUf3TezZiFRQ=; b=gDMb+4RvM5ZGEJ0lumIKzogmgQ1eMYfWerbRT6IEiWA/lbvPyuWFYhjaRBwig5F+nO4cB9 X8Xey3NxFU2ZmIDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702280363; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AR2J2bfA3KmAdFvz7xIrPgcM/jsx2lOqUf3TezZiFRQ=; b=u69uVon60cPou6Ozaf/JVVR3Yh/5shVhKl/n4v/hFbG6VGlroIlVJSMueYbQ3WeVoJpsnT 4YcwMGNQgmqRgQwmUNfvXc0eSet0nZuFZY1Cc09wfEnsEixUJUpEadvttgwHHIPqW3GKhC H0tNnnY8DWIUr+TKyaJ016jDa+UheFk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702280363; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AR2J2bfA3KmAdFvz7xIrPgcM/jsx2lOqUf3TezZiFRQ=; b=THVd2YB1yke3zSL2ONtZD1XuhkR/G9CIr9+Mdbl9pxRRI18jVX2rHt68IiMx+81lenWjQA ulqiU/YNFovWkxBA== Date: Mon, 11 Dec 2023 08:38:22 +0100 (CET) From: Richard Biener To: Richard Sandiford cc: Tamar Christina , gcc-patches@gcc.gnu.org, nd@arm.com, jlaw@ventanamicro.com Subject: Re: [PATCH 15/21]middle-end: [RFC] conditionally support forcing final edge for debugging In-Reply-To: Message-ID: <98348n1p-so0r-8n68-79rr-q4p16938501p@fhfr.qr> References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Level: X-Spam-Score: -0.61 Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -1.13 X-Spamd-Result: default: False [-1.13 / 50.00]; TO_DN_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; NEURAL_SPAM_SHORT(2.97)[0.989]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com] X-Spam-Flag: NO X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, 9 Dec 2023, Richard Sandiford wrote: > Tamar Christina writes: > > Hi All, > > > > What do people think about having the ability to force only the latch connected > > exit as the exit as a param? I.e. what's in the patch but as a param. > > > > I found this useful when debugging large example failures as it tells me where > > I should be looking. No hard requirement but just figured I'd ask if we should. > > If it's useful for that, then perhaps it would be worth making it a > DEBUG_COUNTER instead of a --param, for easy bisection. Or even better, make a debug counter that would skip the IV edge and choose the "next". Richard. > Thanks, > Richard > > > > > Thanks, > > Tamar > > > > gcc/ChangeLog: > > > > * tree-vect-loop.cc (vec_init_loop_exit_info): Allow forcing of exit. > > > > --- inline copy of patch -- > > diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc > > index 27ab6abfa854f14f8a4cf3d9fcb1ac1c203a4198..d6b35372623e94e02965510ab557cb568c302ebe 100644 > > --- a/gcc/tree-vect-loop.cc > > +++ b/gcc/tree-vect-loop.cc > > @@ -964,6 +964,7 @@ vec_init_loop_exit_info (class loop *loop) > > if (exits.length () == 1) > > return exits[0]; > > > > +#if 0 > > /* If we have multiple exits we only support counting IV at the moment. Analyze > > all exits and return one */ > > class tree_niter_desc niter_desc; > > @@ -982,6 +983,16 @@ vec_init_loop_exit_info (class loop *loop) > > } > > > > return candidate; > > +#else > > + basic_block bb = ip_normal_pos (loop); > > + if (!bb) > > + return NULL; > > + > > + edge exit = EDGE_SUCC (bb, 0); > > + if (exit->dest == loop->latch) > > + return EDGE_SUCC (bb, 1); > > + return exit; > > +#endif > > } > > > > /* Function bb_in_loop_p > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)