From: Jeff Law <law@redhat.com>
To: Luis Machado <luis.machado@linaro.org>, "H.J. Lu" <hjl.tools@gmail.com>
Cc: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
James Greenhalgh <james.greenhalgh@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH 1/2] Introduce prefetch-minimum stride option
Date: Thu, 24 May 2018 02:51:00 -0000 [thread overview]
Message-ID: <983c0a28-95d1-a9ab-e582-74ab71e4557c@redhat.com> (raw)
In-Reply-To: <4e2b74ae-2c37-1bff-94ed-3a78486f2131@linaro.org>
On 05/23/2018 04:50 PM, Luis Machado wrote:
> On 05/23/2018 07:42 PM, H.J. Lu wrote:
>> On Wed, May 23, 2018 at 3:41 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Wed, May 23, 2018 at 3:35 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>
>>>>>
>>>>> Sorry. Does the following fix it for i686?
>>>>>
>>>>
>>>> Index: gcc/tree-ssa-loop-prefetch.c
>>>> ===================================================================
>>>> --- gcc/tree-ssa-loop-prefetch.c (revision 260625)
>>>> +++ gcc/tree-ssa-loop-prefetch.c (working copy)
>>>> @@ -1014,7 +1014,8 @@
>>>> Â Â fprintf (dump_file,
>>>> Â Â "Step for reference %u:%u (%ld) is less than the mininum "
>>>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ^^^ Please use
>>>> HOST_WIDE_INT_PRINT_DEC
>>>> Â Â "required stride of %d\n",
>>>> - ref->group->uid, ref->uid, int_cst_value (ref->group->step),
>>>> + ref->group->uid, ref->uid,
>>>> + (HOST_WIDE_INT) int_cst_value (ref->group->step),
>>>> Â Â PREFETCH_MINIMUM_STRIDE);
>>>>
>>>>
>>>
>>> Something like this.
>>>
>>> --
>>> H.J.
>>> ---
>>> diff --git a/gcc/tree-ssa-loop-prefetch.c b/gcc/tree-ssa-loop-prefetch.c
>>> index c3e7fd1e529..949a67f360e 100644
>>> --- a/gcc/tree-ssa-loop-prefetch.c
>>> +++ b/gcc/tree-ssa-loop-prefetch.c
>>> @@ -1012,8 +1012,8 @@ should_issue_prefetch_p (struct mem_ref *ref)
>>> Â Â Â Â Â {
>>> Â Â Â Â Â Â Â if (dump_file && (dump_flags & TDF_DETAILS))
>>> Â Â Â fprintf (dump_file,
>>> -Â Â Â Â Â "Step for reference %u:%u (%ld) is less than the mininum "
>>> -Â Â Â Â Â "required stride of %d\n",
>>> +Â Â Â Â Â "Step for reference %u:%u (" HOST_WIDE_INT_PRINT_C
>>> +Â Â Â Â Â ") is less than the mininum required stride of %d\n",
>>> Â Â Â Â Â Â Â ref->group->uid, ref->uid, int_cst_value (ref->group->step),
>>> Â Â Â Â Â Â Â PREFETCH_MINIMUM_STRIDE);
>>> Â Â Â Â Â Â Â return false;
>>
>> I meant:
>>
>> diff --git a/gcc/tree-ssa-loop-prefetch.c b/gcc/tree-ssa-loop-prefetch.c
>> index c3e7fd1e529..e34b78dc186 100644
>> --- a/gcc/tree-ssa-loop-prefetch.c
>> +++ b/gcc/tree-ssa-loop-prefetch.c
>> @@ -1012,8 +1012,8 @@ should_issue_prefetch_p (struct mem_ref *ref)
>> Â Â Â Â Â {
>> Â Â Â Â Â Â Â if (dump_file && (dump_flags & TDF_DETAILS))
>> Â Â Â fprintf (dump_file,
>> -Â Â Â Â Â "Step for reference %u:%u (%ld) is less than the mininum "
>> -Â Â Â Â Â "required stride of %d\n",
>> +Â Â Â Â Â "Step for reference %u:%u (" HOST_WIDE_INT_PRINT_DEC
>> +Â Â Â Â Â ") is less than the mininum required stride of %d\n",
>> Â Â Â Â Â Â Â ref->group->uid, ref->uid, int_cst_value (ref->group->step),
>> Â Â Â Â Â Â Â PREFETCH_MINIMUM_STRIDE);
>> Â Â Â Â Â Â Â return false;
>>
>>
>
> Pushed now. Sorry for the breakage.
>
> For future reference, is there an i686 system on the gcc farm that i can
> use to validate this?
My tester uses gcc45. In theory you could probably also do it in an
i686 chroot on an x86_64 system. My tester does that for testing ppc32
on a ppc64 system.
jeff
next prev parent reply other threads:[~2018-05-24 1:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 13:46 [PATCH 0/2] Add a couple new options to control loop prefetch pass Luis Machado
2018-01-22 14:01 ` [PATCH 1/2] Introduce prefetch-minimum stride option Luis Machado
2018-01-23 9:46 ` Kyrill Tkachov
2018-01-23 13:23 ` Luis Machado
2018-05-01 18:30 ` Jeff Law
2018-05-07 14:10 ` Luis Machado
2018-05-07 15:15 ` H.J. Lu
2018-05-07 15:51 ` Luis Machado
2018-05-14 21:21 ` Luis Machado
2018-05-15 9:59 ` Kyrill Tkachov
2018-05-15 11:21 ` Luis Machado
2018-05-16 9:22 ` Kyrill Tkachov
2018-05-16 11:53 ` Luis Machado
2018-05-22 18:56 ` Luis Machado
2018-05-22 21:21 ` Jeff Law
2018-05-23 20:27 ` H.J. Lu
2018-05-23 22:34 ` Luis Machado
2018-05-23 22:41 ` H.J. Lu
2018-05-23 22:42 ` H.J. Lu
2018-05-23 22:45 ` H.J. Lu
2018-05-23 23:29 ` Luis Machado
2018-05-24 2:51 ` Jeff Law [this message]
2018-05-24 12:21 ` Luis Machado
2018-01-22 14:10 ` [PATCH 2/2] Introduce prefetch-dynamic-strides option Luis Machado
2018-01-23 9:53 ` Kyrill Tkachov
2018-01-23 13:32 ` Luis Machado
2018-05-01 18:31 ` Jeff Law
2018-05-07 14:13 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=983c0a28-95d1-a9ab-e582-74ab71e4557c@redhat.com \
--to=law@redhat.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=james.greenhalgh@arm.com \
--cc=kyrylo.tkachov@foss.arm.com \
--cc=luis.machado@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).