public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Thomas Koenig <tkoenig@netcologne.de>
To: Janne Blomqvist <blomqvist.janne@gmail.com>,
	fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Use __BYTE_ORDER__ predefined macro instead of runtime check
Date: Wed, 22 Nov 2017 18:42:00 -0000	[thread overview]
Message-ID: <984714d2-9243-c60a-adb8-7b92cd9cae3e@netcologne.de> (raw)
In-Reply-To: <1511354047-32527-1-git-send-email-blomqvist.janne@gmail.com>

Hi janne,

> Regtested on x86_64-pc-linux-gnu, Ok for trunk?

Jerry already OK'd this, so you can commit if you want.
What you could do is to hide the macro invocation behind
a macro in libgfortran.h, something like

#define BIG_ENDIAN (__BYTE_ORDER__ == __ORDER_BIG_ENDIAN__)

Also, I have opened PR libfortran/83097 for this, you
can mention this in the ChangeLog entry.

Regards

	Thomas

  parent reply	other threads:[~2017-11-22 18:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-22 12:59 Janne Blomqvist
2017-11-22 16:57 ` Jerry DeLisle
2017-11-22 18:42 ` Thomas Koenig [this message]
2017-11-22 19:22   ` Andreas Schwab
2017-11-22 20:03   ` Janne Blomqvist

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=984714d2-9243-c60a-adb8-7b92cd9cae3e@netcologne.de \
    --to=tkoenig@netcologne.de \
    --cc=blomqvist.janne@gmail.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).